581858 - Firefox button breaks top edge of the window in non-maximized mode.

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

User-Agent:       Mozilla/5.0 (Windows; Windows NT 6.1; WOW64; rv:2.0b3pre) Gecko/20100725 Firefox/3.7a5pre RTSE/1.2.0.20100719
Build Identifier: Mozilla/5.0 (Windows; Windows NT 6.1; WOW64; rv:2.0b3pre) Gecko/20100725 Firefox/3.7a5pre RTSE/1.2.0.20100719

When the Firefox button is active (eg menubar is disabled), the very top of the window doesn't respond to mouse events like hover or click.

Reproducible: Always

Steps to Reproduce:
1. Activate the Firefox button by disabling the menubar.
2. See that the Firefox button goes into the titlebar of the window.
3. Size/position the window so that the top of the window is up against the edge of the screen. (Aero snap the window to the left or right side, or just resize vertically up to the top of the screen.)
4. Move mouse cursor to the top of the window (over the Firefox button, or over the window caption buttons).
Actual Results:  
The Firefox/caption buttons' hover effects aren't shown, and clicks aren't registered on the buttons until you shift the cursor down a few pixels. The cursor also doesn't change to the window resizer icon when you're at the edge of the window over an empty part of the titlebar.

Expected Results:  
The hover effects and clicks work when the cursor is at the extreme edge of the window.

I've tried this on a clean profile on the latest trunk builds.

It's mildly annoying now (I don't resize/close windows that often), but it'll get worse when people start adding "move tabs in titlebar" customizations (I do switch tabs fairly often).

All of this works just fine if the menubar is enabled, by the way.

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Is this maybe related to bug 575243?

Comment 2

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

If Firefox is maximized (not fullscreen), hovering along the top edge will highlight each button (and tab, if it's up there) when you hover over them. (Which is the correct behavior.)

It doesn't show the resizer cursor, but that's like all other programs on Windows 7, so that's also correct behavior. (At least two first two I tested, Skype and Zune.)

Comment 3

[[not reading bugmail]]

This doesn't block the Firefox button bug since its not related to it by code.  This works for me unless you have persona installed then you get no caption buttons. If your using custom userChrome, then its invalid.

Mozilla/5.0 (Windows; Windows NT 6.1; rv:2.0b3pre) Gecko/20100727 Minefield/4.0b3pre ID:20100727164139

You also cannot resize a maximized window here and bug 575243 was only in normal window mode.

Comment 4

[[not reading bugmail]]

You might want to check your mouse settings.

Comment 5

[Jonathan Haas]

I can reproduce this.

Easy steps to reproduce:
- aero-snap the window to the left or right side.
- move the mouse to the top of the screen. (where the window is of course)

Result: Resizer cursor not shown.
Expected: Cursor shown.

Or just move the mouse to the two topmost pixels of the unmaximized window (you may want to use some sort of screen zoom tool). It will not show the resizer cursor and will not respond to mouse events.

Comment 6

[[not reading bugmail]]

I see this now.  Jim, Resizer/clicking hitzone must be offset from the top edge when using custom drawing in the titlebar.

Comment 7

[Alex Faaborg [:faaborg] (Firefox UX)]

maybe a dupe of bug 576312 ?

Comment 8

[Jim Mathies [:jimm]]

WFM

Comment 9

[Jim Mathies [:jimm]]

(In reply to comment #8)
> WFM

Oh, wait, resizer cursor over the fx button after an aero snap to the left? (Resolved won't fix) That's expected.

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

(In reply to comment #9)
> (In reply to comment #8)
> > WFM
> 
> Oh, wait, resizer cursor over the fx button after an aero snap to the left?
> (Resolved won't fix) That's expected.

Not over the fx button, no. If you're over an open part of the titlebar (eg, not the fx or caption buttons), the resizer doesn't show until you move the cursor down a pixel or two. If you're over either the caption or fx buttons, the button's hovered state is not shown (and no resizer is shown) until you move the cursor down a pixel or two.

For comparison, Outlook 2010 shows the resizer over both the open space AND the caption buttons. Skype 5 beta shows the resizer over open space, and hovers over the caption buttons. Firefox 3.6 shows the resizer over everything.

Comment 11

[Jim Mathies [:jimm]]

(In reply to comment #10)
> (In reply to comment #9)
> > (In reply to comment #8)
> > > WFM
> > 
> > Oh, wait, resizer cursor over the fx button after an aero snap to the left?
> > (Resolved won't fix) That's expected.
> 
> Not over the fx button, no. If you're over an open part of the titlebar (eg,
> not the fx or caption buttons), the resizer doesn't show until you move the
> cursor down a pixel or two. If you're over either the caption or fx buttons,
> the button's hovered state is not shown (and no resizer is shown) until you
> move the cursor down a pixel or two.
> 
> For comparison, Outlook 2010 shows the resizer over both the open space AND the
> caption buttons. Skype 5 beta shows the resizer over open space, and hovers
> over the caption buttons. Firefox 3.6 shows the resizer over everything.

Ok, could you keep an eye on bug 575870 and after that lands, check again? I believe it'll be fixed but can't be sure.

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I'm not using Aero Basic, but I'll look for it when it lands.

Comment 13

[Jim Mathies [:jimm]]

(In reply to comment #12)
> I'm not using Aero Basic, but I'll look for it when it lands.

I'm testing with a nightly vs. the patches in bug 574454 and bug 575870. I'm pretty sure this will be WFM after those land.

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

(In reply to comment #13)
> (In reply to comment #12)
> > I'm not using Aero Basic, but I'll look for it when it lands.
> 
> I'm testing with a nightly vs. the patches in bug 574454 and bug 575870. I'm
> pretty sure this will be WFM after those land.

Top window edge shows the resizer for me using your WinXP drawing in the titlebar tryserver build.

Comment 15

[Jim Mathies [:jimm]]

Fixed by the landings in bug 575870 & bug 574454.

Comment 16

[Benjamin Xiao]

I am running Windows 7 Aero and I see this problem as well. The menu button should be moved up 1px when non-maximized and left alone when maximized.