Closed Bug 583616 Opened 10 years ago Closed 9 years ago
icons on OS X bookmark toolbar not constrained to 16x16
Bug 566034 turned on favicons for the OS X toolbar. Looks like we're not correctly limiting the size to 16x16, see bug 566034 comment 17 - 19. STR: 1) Add http://www.stanford.edu/ to bookmark toolbar 2) Notice that icon is 16x32.
Ick. The obvious change would be to set "max-height: 16px", but then the icons are again squished to 14px tall. The problem is that toolkit/themes/pinstripe/global/toolbarbutton.css sets 1px of top/bottom padding on the icon, so the correct min/max-height is actually 18px. Probably should change the other CSS to be 1px of margin, or set the padding on the parent element, but I'm a bit loathe to be making/testing that as a broader change. But maybe I should. :(
Assignee: nobody → dolske
Or you could just set padding:0 only for this icon.
Comment on attachment 461967 [details] [diff] [review] Patch v.1 see comment 2
Duplicate of this bug: 586430
I hit this with Google Reader :(
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b8
Whiteboard: [can land]
Target Milestone: Firefox 4.0b8 → Firefox 4.0b7
You need to log in before you can comment on or make changes to this bug.