584372 - Implement "Reset Tab Grouping" and "Group Tabs by Sites" inside Tab Candy

Status: RESOLVED WONTFIX

(Firefox Graveyard :: Panorama, enhancement)

Description

[Tan Wei Lin Jason [:Ryuji]]

User-Agent:       Mozilla/5.0 (Windows; Windows NT 6.1; WOW64; rv:2.0b3pre) Gecko/20100802 Minefield/4.0b3pre
Build Identifier: Mozilla/5.0 (Windows; Windows NT 6.1; WOW64; rv:2.0b3pre) Gecko/20100802 Minefield/4.0b3pre

Firefox will crash once refresh is selected. Simply all tabs will disappear and the Visual Tab Interface will be left with nothing but empty grey space. You cannot switch to any tab and you will be stuck at the blue/grey Visual Tab Interface. 

Reproducible: Always

Steps to Reproduce:
1. Open Tab Candy build
2. Go to Visual Tab Interface
3. Select Refresh in the Dev Menu
4. All tabs disappear
5. you are stuck at the Visual Tab Interface

Comment 1

[Tan Wei Lin Jason [:Ryuji]]

Selecting Reset in the Dev menu appears to have the same effect as Refresh.

Comment 2

[Ian Gilman [:iangilman]]

I've commented out the "refresh" and "reset" items on the dev menu; we may bring these back (and fix them) in the future if needed for dev work, but they won't be in the shipping version. 

http://hg.mozilla.org/users/edward.lee_engineering.uiuc.edu/tabcandy-central/rev/9932b568e663

Comment 3

[Tan Wei Lin Jason [:Ryuji]]

I know that it is intended for Dev Menu to be removed on the release build. However, shouldn't we provide a way to allow users to "reset" their tab groupings?

Comment 4

[Ian Gilman [:iangilman]]

(In reply to comment #3)
> I know that it is intended for Dev Menu to be removed on the release build.
> However, shouldn't we provide a way to allow users to "reset" their tab
> groupings?

One way to do it would be to reset your sessionstore. 

At any rate, I do think both "start over" and "group by sites" would be nice features to officially have somewhere in the Tab Candy UI. Adding aza for comment.

Comment 5

[Tan Wei Lin Jason [:Ryuji]]

Ian, I agree what you have said. However, this bug need to be fixed in order for "Start Over" (to reset tab groupings) to work. Unless you use a new way to reset tab groupings.

Aza, "Start Over" and "Group by sites" are two good feature that users may use for their own convenience to reset their tab groupings or to automatically group their tabs by similarity. 

I propose that those two feature should have a button of their own just like how the old reset button have.

Comment 6

[(no longer active)]

Mass moving all Tab Candy bugs from Mozilla Labs to Firefox::Tab Candy.  Filter the bugmail spam with "tabcandymassmove".

Comment 7

[Tan Wei Lin Jason [:Ryuji]]

Both Reset Tab Groupings and Group Tab by sites are missing from Current Tab Candy UI. I wonder what is the current status of those feature.

Comment 8

[Patrick]

Changing from Unconfirmed to New

Comment 9

[Aza Raskin [:aza]]

I don't think that we will have this for launch.

Comment 10

[Ed Lee :Mardak]

Marking this WONTFIX means that we'll never want to fix this.

Comment 11

[Aza Raskin [:aza]]

My fault. Leaving this as wontfix as we will add a feature to group tabs by some rubric the details have yet to be fully spec'ed so this bug can be marked resolved.

Comment 12

[Michael Yoshitaka Erlewine [:mitcho]]

Does that mean we should pull out the legacy grouping-by-site code we have in the codebase now?

Comment 13

[Aza Raskin [:aza]]

Yes.

Comment 14

[Aza Raskin [:aza]]

This is something perfect to explore via add-ons, or as a Jetpack that we proffer on first-run experience.