Closed Bug 592586 Opened 14 years ago Closed 14 years ago

Remove code for "group tab by sites"

Categories

(Firefox Graveyard :: Panorama, defect)

Product:
Firefox Graveyard
Component:
Panorama
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 4.0b7

People

(Reporter: mitcho, Assigned: mitcho)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file, 4 obsolete files)

Patch for checkin
3.82 KB, patch
Details | Diff | Splinter Review 
As per bug 584372, this will not be refined or ship, at least for Firefox 4. Let's kill the unused code.
Attached patch Proposed (trivial) patch (obsolete) — — Splinter Review 
Assignee: nobody → mitcho

        Attachment #471021 -
        Flags: review?(dolske)

    
    

    
  
Comment on attachment 471021 [details] [diff] [review]
Proposed (trivial) patch

Sad to see it go, but yes, we should.

        Attachment #471021 -
        Flags: feedback+

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Proposed (trivial) patch v2 (obsolete)
        — 
          — Splinter Review
      

    


  
Also remove GroupItems.getGroupItemWithTitle, which was only used by the "group tab by sites" code.

        Attachment #471021 -
        Attachment is obsolete: true

        Attachment #471867 -
        Flags: review?(dolske)

        Attachment #471021 -
        Flags: review?(dolske)

        Attachment #471867 -
        Flags: review?(dolske) → review?(dietrich)

        Attachment #471867 -
        Flags: review?(dietrich)

        Attachment #471867 -
        Flags: review+

        Attachment #471867 -
        Flags: approval2.0+

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Patch for checkin (obsolete)
        — 
          — Splinter Review
      

    


  

        Attachment #471867 -
        Attachment is obsolete: true

    
    

    
  
And backed out due to Moth test failures.

    
    

    
  
different patch caused the failures, relanded: http://hg.mozilla.org/mozilla-central/rev/d0394b66e5d3
Status: NEW → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b6

    
    

    
  
test failed again: http://pastebin.mozilla.org/783925

backed out: http://hg.mozilla.org/mozilla-central/rev/c3e21097bb78
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

    
    

    
  
This patch, applied on its own, doesn't cause the failures.

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/e1b1e9dfcdaf
Status: REOPENED → RESOLVED
Closed: 14 years ago → 14 years ago
Resolution: --- → FIXED

    
    

    
  
Backed out because of Linux test failures:

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1283899045.1283900225.31464.gz
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Patch for checkin (obsolete)
        — 
          — Splinter Review
      

    


  
Repackaged for rot

        Attachment #471934 -
        Attachment is obsolete: true

    
    

    
  


  
Updated for rot

        Attachment #473279 -
        Attachment is obsolete: true

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/858cb102190c
Status: REOPENED → RESOLVED
Closed: 14 years ago → 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [qa-]
Product: Firefox → Firefox Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: