Closed
Bug 592586
Opened 15 years ago
Closed 15 years ago
Remove code for "group tab by sites"
Categories
(Firefox Graveyard :: Panorama, defect)
Firefox Graveyard
Panorama
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 4.0b7
People
(Reporter: mitcho, Assigned: mitcho)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file, 4 obsolete files)
|
3.82 KB,
patch
|
Details | Diff | Splinter Review |
As per bug 584372, this will not be refined or ship, at least for Firefox 4. Let's kill the unused code.
|
Assignee | |
Comment 1•15 years ago
|
||
Assignee: nobody → mitcho
Attachment #471021 -
Flags: review?(dolske)
|
||
Comment 2•15 years ago
|
||
Comment on attachment 471021 [details] [diff] [review]
Proposed (trivial) patch
Sad to see it go, but yes, we should.
Attachment #471021 -
Flags: feedback+
|
|
Assignee | |
Comment 3•15 years ago
|
||
Committed against tabcandy-central:
http://hg.mozilla.org/users/edward.lee_engineering.uiuc.edu/tabcandy-central/rev/f21648670f61
|
|
Assignee | |
Comment 4•15 years ago
|
||
Also remove GroupItems.getGroupItemWithTitle, which was only used by the "group tab by sites" code.
Attachment #471021 -
Attachment is obsolete: true
Attachment #471867 -
Flags: review?(dolske)
Attachment #471021 -
Flags: review?(dolske)
|
|
Assignee | |
Comment 5•15 years ago
|
||
Committed part 2 of the patch against tabcandy-central as well:
http://hg.mozilla.org/users/edward.lee_engineering.uiuc.edu/tabcandy-central/rev/19f018333edf
|
|
Assignee | |
Updated•15 years ago
|
Attachment #471867 -
Flags: review?(dolske) → review?(dietrich)
|
||
Updated•15 years ago
|
Attachment #471867 -
Flags: review?(dietrich)
Attachment #471867 -
Flags: review+
Attachment #471867 -
Flags: approval2.0+
|
|
Assignee | |
Comment 6•15 years ago
|
||
Attachment #471867 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•15 years ago
|
Keywords: checkin-needed
|
||
Comment 7•15 years ago
|
||
|
|
||
Comment 8•15 years ago
|
||
And backed out due to Moth test failures.
|
|
||
Comment 9•15 years ago
|
||
different patch caused the failures, relanded: http://hg.mozilla.org/mozilla-central/rev/d0394b66e5d3
Status: NEW → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b6
|
|
||
Comment 10•15 years ago
|
||
test failed again: http://pastebin.mozilla.org/783925
backed out: http://hg.mozilla.org/mozilla-central/rev/c3e21097bb78
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
||
Comment 11•15 years ago
|
||
This patch, applied on its own, doesn't cause the failures.
|
|
||
Comment 12•15 years ago
|
||
Status: REOPENED → RESOLVED
Closed: 15 years ago → 15 years ago
Resolution: --- → FIXED
|
|
||
Comment 13•15 years ago
|
||
Backed out because of Linux test failures:
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1283899045.1283900225.31464.gz
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
Assignee | |
Comment 14•15 years ago
|
||
Repackaged for rot
Attachment #471934 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 15•15 years ago
|
||
Updated for rot
Attachment #473279 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•15 years ago
|
Keywords: checkin-needed
|
|
||
Comment 16•15 years ago
|
||
Status: REOPENED → RESOLVED
Closed: 15 years ago → 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
|
||
Updated•15 years ago
|
Whiteboard: [qa-]
|
||
Updated•9 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•