584495 - Assertion JS_HAS_OPTION(acx, JSOPTION_UNROOTED_GLOBAL) in test_access_control.html, test_prompt.html, test_prompt_async.html, test_CrossSiteXHR_origin.html, test_getauthenticationinfo.html, test_hanging.html followed by timeouts, failures, and crashes

Kyle Huey (Exited; not receiving bugmail, old account, do not use)

Reporter

Description

•

14 years ago

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1280952462.1280954168.11128.gz&fulltext=1 Assertion failure: JS_HAS_OPTION(acx, JSOPTION_UNROOTED_GLOBAL), at /builds/slave/mozilla-central-linux-debug/build/js/src/xpconnect/src/xpcjsruntime.cpp:383 Followed by a lot of test failures and then a crash.

Andreas Gal :gal

Assignee

Comment 1

•

14 years ago

That totally sounds like me. When did this start?

Andreas Gal :gal

Assignee

Updated

•

14 years ago

Assignee: general → gal

Andreas Gal :gal

Assignee

Updated

•

14 years ago

blocking2.0: --- → ?

Kyle Huey (Exited; not receiving bugmail, old account, do not use)

Reporter

Comment 2

•

14 years ago

http://hg.mozilla.org/mozilla-central/rev/a0694218d21e is the first changeset it showed up on, but it definitely looks intermittent, so I would guess it's from the latest TM merge.

Kyle Huey (Exited; not receiving bugmail, old account, do not use)

Reporter

Comment 3

•

14 years ago

Bug 583561 has the same assertion.

Comment hidden (Legacy TBPL/Treeherder Robot)

khuey http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1280956368.1280958061.28259.gz Rev3 Fedora 12 mozilla-central debug test mochitests-1/5 on 2010/08/04 14:12:48 s: talos-r3-fed-053 48111 ERROR TEST-UNEXPECTED-FAIL | /tests/content/media/test/test_access_control.html | Can load when redirected to subdomain with allow-origin (element in document) - got "error", expected "loadeddata" 48112 ERROR TEST-UNEXPECTED-FAIL | /tests/content/media/test/test_access_control.html | Can load when redirected to same domain (element in document) - got "error", expected "loadeddata" 48113 ERROR TEST-UNEXPECTED-FAIL | /tests/content/media/test/test_access_control.html | Can load from same domain (element in document) - got "error", expected "loadeddata" 48115 ERROR TEST-UNEXPECTED-FAIL | /tests/content/media/test/test_access_control.html | Can load from different port on same domain with allow-origin (element in document) - got "error", expected "loadeddata" 48117 ERROR TEST-UNEXPECTED-FAIL | /tests/content/media/test/test_access_control.html | Can load cross domain with allow-origin (element in document) - got "error", expected "loadeddata" 48118 ERROR TEST-UNEXPECTED-FAIL | /tests/content/media/test/test_access_control.html | Can load from subdomain with allow-origin (element in document) - got "error", expected "loadeddata" 48121 ERROR TEST-UNEXPECTED-FAIL | /tests/content/media/test/test_access_control.html | Can load when redirected to different domain with allow-origin (element not in document) - got "error", expected "loadeddata" 48123 ERROR TEST-UNEXPECTED-FAIL | /tests/content/media/test/test_access_control.html | Can load when redirected to subdomain with allow-origin (element not in document) - got "error", expected "loadeddata" 48124 ERROR TEST-UNEXPECTED-FAIL | /tests/content/media/test/test_access_control.html | Can load when redirected to same domain (element not in document) - got "error", expected "loadeddata" 48125 ERROR TEST-UNEXPECTED-FAIL | /tests/content/media/test/test_access_control.html | Can load from same domain (element not in document) - got "error", expected "loadeddata" 48127 ERROR TEST-UNEXPECTED-FAIL | /tests/content/media/test/test_access_control.html | Can load from different port on same domain with allow-origin (element not in document) - got "error", expected "loadeddata" 48129 ERROR TEST-UNEXPECTED-FAIL | /tests/content/media/test/test_access_control.html | Can load cross domain with allow-origin (element not in document) - got "error", expected "loadeddata" 48130 ERROR TEST-UNEXPECTED-FAIL | /tests/content/media/test/test_access_control.html | Can load from subdomain with allow-origin (element not in document) - got "error", expected "loadeddata" TEST-UNEXPECTED-FAIL | /tests/content/media/test/test_audio1.html | application timed out after 330 seconds with no output PROCESS-CRASH | /tests/content/media/test/test_audio1.html | application crashed (minidump found) Thread 0 (crashed) TEST-UNEXPECTED-FAIL | automationutils.processLeakLog() | missing output line for total leaks!

Kyle Huey (Exited; not receiving bugmail, old account, do not use)

Reporter

Comment 7

•

14 years ago

Assertion failure: JS_HAS_OPTION(acx, JSOPTION_UNROOTED_GLOBAL) http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1280957594.1280958575.30547.gz

OS: Linux → All

Summary: [Linux] Assertion JS_HAS_OPTION(acx, JSOPTION_UNROOTED_GLOBAL) in test_access_control.html followed by the end of the world → Assertion JS_HAS_OPTION(acx, JSOPTION_UNROOTED_GLOBAL) in test_access_control.html, test_prompt.html followed by the end of the world

Kyle Huey (Exited; not receiving bugmail, old account, do not use)

Reporter

Comment 8

•

14 years ago

I'm going to turn this into a generic bug for tracking test failures that happen with this assertion.

Kyle Huey (Exited; not receiving bugmail, old account, do not use)

Reporter

Comment 9

•

14 years ago

This should definitely block IMO, we're hitting this a lot on Tinderbox and it seems to end in a random crash every time.

Kyle Huey (Exited; not receiving bugmail, old account, do not use)

Reporter

Comment 10

•

14 years ago

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1280957983.1280959042.32690.gz

Summary: Assertion JS_HAS_OPTION(acx, JSOPTION_UNROOTED_GLOBAL) in test_access_control.html, test_prompt.html followed by the end of the world → Assertion JS_HAS_OPTION(acx, JSOPTION_UNROOTED_GLOBAL) in test_access_control.html, test_prompt.html, test_prompt_async.html followed by timeouts, failures, and crashes

Comment hidden (Legacy TBPL/Treeherder Robot)

Kyle Huey (Exited; not receiving bugmail, old account, do not use)

Reporter

Comment 12

•

14 years ago

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1280954358.1280955302.15854.gz

Summary: Assertion JS_HAS_OPTION(acx, JSOPTION_UNROOTED_GLOBAL) in test_access_control.html, test_prompt.html, test_prompt_async.html followed by timeouts, failures, and crashes → Assertion JS_HAS_OPTION(acx, JSOPTION_UNROOTED_GLOBAL) in test_access_control.html, test_prompt.html, test_prompt_async.html, test_CrossSiteXHR_origin.html followed by timeouts, failures, and crashes

Kyle Huey (Exited; not receiving bugmail, old account, do not use)

Reporter

Comment 14

•

14 years ago

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1280954358.1280955352.16249.gz

Phil Ringnalda (:philor)

Comment 15

•

14 years ago

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1280961743.1280962729.16370.gz

Comment hidden (Legacy TBPL/Treeherder Robot)

Andreas Gal :gal

Assignee

Comment 22

•

14 years ago

I still haven't seen a crash stack that is really related to this issue. Any chance of grabbing one of those?

Comment hidden (Legacy TBPL/Treeherder Robot)

(no longer active)

Comment 28

•

14 years ago

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1280974276.1280975279.7330.gz

Comment hidden (Legacy TBPL/Treeherder Robot)

Serge Gautherie (:sgautherie)

Updated

•

14 years ago

Blocks: 438871

Comment hidden (Legacy TBPL/Treeherder Robot)

Phil Ringnalda (:philor)

Comment 41

•

14 years ago

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1281030456.1281033367.16970.gz WINNT 5.2 mozilla-central debug test mochitests-4/5 on 2010/08/05 10:47:36 s: win32-slave16 Assertion failure: JS_HAS_OPTION(acx, JSOPTION_UNROOTED_GLOBAL), at e:/builds/moz2_slave/mozilla-central-win32-debug/build/js/src/xpconnect/src/xpcjsruntime.cpp:383 ... ERROR TEST-UNEXPECTED-FAIL | /tests/modules/plugin/test/test_getauthenticationinfo.html | Test timed out. ... TEST-UNEXPECTED-FAIL | /tests/modules/plugin/test/test_hanging.html | application timed out after 330 seconds with no output

Summary: Assertion JS_HAS_OPTION(acx, JSOPTION_UNROOTED_GLOBAL) in test_access_control.html, test_prompt.html, test_prompt_async.html, test_CrossSiteXHR_origin.html followed by timeouts, failures, and crashes → Assertion JS_HAS_OPTION(acx, JSOPTION_UNROOTED_GLOBAL) in test_access_control.html, test_prompt.html, test_prompt_async.html, test_CrossSiteXHR_origin.html, test_getauthenticationinfo.html, test_hanging.html followed by timeouts, failures, and crashes

Comment hidden (Legacy TBPL/Treeherder Robot)

Phil Ringnalda (:philor)

Comment 60

•

14 years ago

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1281115835.1281116925.20827.gz

Andreas Gal :gal

Assignee

Comment 61

•

14 years ago

Attached patch patch — Details — Splinter Review

We seem to lose the flag somewhere along the way in an unclear manner. The JS context flag handling in Gecko is extremly sketchy and spread out over 20 files. This fight isn't worth it. Its not not a performance problem to reset the flag every time we CC.

Andreas Gal :gal

Assignee

Updated

•

14 years ago

Attachment #463691 - Flags: review?(brendan)

Brendan Eich [:brendan]

Comment 62

•

14 years ago

Comment on attachment 463691 [details] [diff] [review] patch I haven't looked, so talk is cheap, but it seems as though it should be "easy" to spot the bug by inspecting all the JS_{Set,Toggle}Options uses. But we need to stop the assertbotching. /be

Attachment #463691 - Flags: review?(brendan) → review+

Andreas Gal :gal

Assignee

Comment 63

•

14 years ago

I did that. Its not easy. The code is rather bizarre and the flags are cached in various ways in various places and then re-applied. I will add an assert in JSAPI that stops if the flag is ever unset, which should catch the place that does this, but I do that after landing this.

Andreas Gal :gal

Assignee

Comment 64

•

14 years ago

http://hg.mozilla.org/tracemonkey/rev/504bc84513b0

Andreas Gal :gal

Assignee

Comment 65

•

14 years ago

Filed a follow-up bug as bug 585221.

Andreas Gal :gal

Assignee

Updated

•

14 years ago

Whiteboard: [orange] → [orange], fixed-in-tracemonkey

Comment hidden (Legacy TBPL/Treeherder Robot)

Robert Sayre

Updated

•

14 years ago

blocking2.0: ? → beta4+

Robert Sayre

Comment 70

•

14 years ago

didn't compile. backed out. http://hg.mozilla.org/tracemonkey/rev/5a254bcd79f2

Whiteboard: [orange], fixed-in-tracemonkey → [orange]

Comment hidden (Legacy TBPL/Treeherder Robot)

Andreas Gal :gal

Assignee

Comment 74

•

14 years ago

relanded http://hg.mozilla.org/tracemonkey/rev/d3719a8716f5

Whiteboard: [orange] → [orange], fixed-in-tracemonkey

Robert Sayre

Comment 76

•

14 years ago

http://hg.mozilla.org/mozilla-central/rev/d3719a8716f5

Status: NEW → RESOLVED

Closed: 14 years ago

Resolution: --- → FIXED

Comment hidden (Legacy TBPL/Treeherder Robot)

Nobody; OK to take it and work on it

Updated

•

12 years ago

Keywords: intermittent-failure

Nobody; OK to take it and work on it

Updated

•

12 years ago

Whiteboard: [orange], fixed-in-tracemonkey → , fixed-in-tracemonkey