Closed
Bug 584977
Opened 15 years ago
Closed 14 years ago
mark deprecated caps interfaces and methods with [deprecated]
Categories
(Core :: Security: CAPS, defect)
Tracking
()
RESOLVED
FIXED
mozilla5
People
(Reporter: timeless, Assigned: timeless)
References
Details
Attachments
(1 file)
4.77 KB,
patch
|
bzbarsky
:
review+
mossop
:
approval2.0-
|
Details | Diff | Splinter Review |
We have a way to mark interfaces and methods as deprecated which some compilers
are able to use to complain about deprecation. This bug is for sprinkling that
marker into caps idl files.
Please note that at this time we only properly trigger these compile time
warnings with msvc (bug 584953 covers the fixing the gcc side).
Attachment #463471 -
Flags: review? → review?(dveditz)
Comment 2•15 years ago
|
||
Comment on attachment 463471 [details] [diff] [review]
patch
There are still a couple of calls to these in our own tree (CheckLoadURI in nsDocShell and a couple CheckLoadURIStr in drag-n-drop code). How noisy does this get?
I think I need to defer to bz on this one.
Attachment #463471 -
Flags: review?(dveditz) → review?(bzbarsky)
they become build warnings, which today only appear on msvc because for all the other platforms we're broken :).
i'm taking out way more build warnings than i'm putting in and at the moment i'm driving build warnings, so i'd like the flexibility to add some.
![]() |
||
Updated•15 years ago
|
Attachment #463471 -
Flags: review?(bzbarsky) → review+
Attachment #463471 -
Flags: approval2.0?
Comment 4•15 years ago
|
||
Comment on attachment 463471 [details] [diff] [review]
patch
Per bug 584998 comment 2 this doesn't work as expected yet
Attachment #463471 -
Flags: approval2.0? → approval2.0-
Comment 5•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.2
You need to log in
before you can comment on or make changes to this bug.
Description
•