Closed Bug 584977 Opened 10 years ago Closed 9 years ago

mark deprecated caps interfaces and methods with [deprecated]

Categories

(Core :: Security: CAPS, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla5

People

(Reporter: timeless, Assigned: timeless)

References

Details

Attachments

(1 file)

We have a way to mark interfaces and methods as deprecated which some compilers
are able to use to complain about deprecation. This bug is for sprinkling that
marker into caps idl files.

Please note that at this time we only properly trigger these compile time
warnings with msvc (bug 584953 covers the fixing the gcc side).
Attached patch patchSplinter Review
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #463471 - Flags: review?
Attachment #463471 - Flags: review? → review?(dveditz)
Comment on attachment 463471 [details] [diff] [review]
patch

There are still a couple of calls to these in our own tree (CheckLoadURI in nsDocShell and a couple CheckLoadURIStr in drag-n-drop code). How noisy does this get?

I think I need to defer to bz on this one.
Attachment #463471 - Flags: review?(dveditz) → review?(bzbarsky)
they become build warnings, which today only appear on msvc because for all the other platforms we're broken :).

i'm taking out way more build warnings than i'm putting in and at the moment i'm driving build warnings, so i'd like the flexibility to add some.
Attachment #463471 - Flags: review?(bzbarsky) → review+
Attachment #463471 - Flags: approval2.0?
Depends on: 578478
No longer depends on: 584960
Comment on attachment 463471 [details] [diff] [review]
patch

Per bug 584998 comment 2 this doesn't work as expected yet
Attachment #463471 - Flags: approval2.0? → approval2.0-
http://hg.mozilla.org/mozilla-central/rev/205e81133b5f
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.2
Can someone confirm if this is fixed?
You need to log in before you can comment on or make changes to this bug.