585475 - Relocate updating to "About Mozilla" window

Status: VERIFIED FIXED

(Firefox :: General, enhancement)

Description

[imradyurrad]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US) AppleWebKit/534.5 (KHTML, like Gecko) Chrome/6.0.487.0 Safari/534.5
Build Identifier: Mozilla/5.0 (Windows NT 6.1; rv:2.0b4pre) Gecko/20100807 Minefield/4.0b4pre

According to the latest Firefox Button mockups, updating should be moved to the About Mozilla window, much like Chrome.

Reproducible: Always

Comment 1

[Tan Wei Lin Jason [:Ryuji]]

Do you mean the "About Firefox" window?

Comment 2

[imradyurrad]

(In reply to comment #1)
> Do you mean the "About Firefox" window?

It's different in other Mozilla apps that have the About window. In the nightlies, it's "About Minefield."

Comment 3

[Tan Wei Lin Jason [:Ryuji]]

You are right. I forgot about the other Mozilla apps. Does any one have any mock-up of how this should work?

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

It's unclear from the project page if we've worked through the design for this, especially with respect to:

 - where security context information goes
 - how someone gets their toolbars back if they want it
 - where notifications come from
 - who will bake the bread

Minusing, the UX team can renominate if they feel like it must block a release, but I think we can live without it for Firefox 4.

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Ugh, ignore comment 4, wrong bug.

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Have there been any mockups of what the About:Mozilla window should look like in Fx4? 

Would the "Check for Updates" button/link go on the same line as the version number? (Styled like the about:license link, maybe?)

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Is this intended to be Windows-only? It otherwise conflicts with bug 306018 somewhat (people are doing Firefox 4-targeted work in that bug to enable adding menu items to the Mac Application menu).

Comment 8

[:Margaret Leibovic]

Attachment: WIP

Moved "Check for Updates..." from help menu to button in about dialog. Waiting on about dialog re-design decisions before proceeding further.

Comment 9

[:Margaret Leibovic]

Attachment: about dialog with new button

Comment 10

[[not reading bugmail]]

(In reply to comment #8)
> Created attachment 468819 [details] [diff] [review]
> WIP
> 
> Moved "Check for Updates..." from help menu to button in about dialog. Waiting
> on about dialog re-design decisions before proceeding further.

Margaret, I believe bug 306018 comment 55 answered the Mac case and should not be touched here, but Windows for sure should be updated here.

Comment 11

[Markus Amalthea Magnuson]

Yes, this is a completely non-standard location for software updating on Mac. If you look in any other decent piece of Mac software you'll find the update functionality in the application menu after the about item, which is what bug 306018 is all about.

Comment 12

[:Margaret Leibovic]

Because bug 306018 hasn't been resolved yet and we want to maintain update functionality on all platforms, I propose we just move the update functionality to the about dialog for now. Then, when bug 306018 has a patch in the tree, we can file a follow-up bug to remove the update functionality from the about dialog for OSX.

I looked through bug 306018, but I'm not familiar with what goes into menus from the widget side of things, so please correct me if this is a bad idea :)

(Also, as a side note, Chrome has update functionality in the about dialog on OSX. I don't know if this affects our design decisions, but I thought it worth mentioning.)

Comment 13

[Alex Limi (:limi) — Firefox UX Team]

(In reply to comment #12)
> Because bug 306018 hasn't been resolved yet and we want to maintain update
> functionality on all platforms, I propose we just move the update functionality
> to the about dialog for now.

Agreed.

> Then, when bug 306018 has a patch in the tree, we
> can file a follow-up bug to remove the update functionality from the about
> dialog for OSX.

There's no harm in having this particular menu item in both locations. Easier for troubleshooting across platforms, and when you look at the version number (why else would you be in the about dialog? ;), it makes sense to have Check for Updates easily visible.

Comment 14

[José Jeria]

(In reply to comment #12)
> (Also, as a side note, Chrome has update functionality in the about dialog on
> OSX. I don't know if this affects our design decisions, but I thought it worth
> mentioning.)

Difference here is that the user does not need to go to the about dialog to update, since the updates are silent.

I fear that this hides this very important functionality. Mac users do not except the "check for updates" to be in an about dialog.

Comment 15

[Alex Limi (:limi) — Firefox UX Team]

(In reply to comment #14)
> Difference here is that the user does not need to go to the about dialog to
> update, since the updates are silent.
> 
> I fear that this hides this very important functionality. Mac users do not
> except the "check for updates" to be in an about dialog.

Updates are still automatic on the Mac, just not silent. So people don't need to check for updates manually in any case, it's just something they can elect to do. 

(And people on betas and nightlies — like myself — use this functionality very often, but aren't really representative of the general audience :)

Comment 16

[Mike Beltzner [:beltzner, not reading bugmail]]

This will be fixed by the patch in bug 579547

Comment 17

[:Margaret Leibovic]

Fixed by bug 579547

Comment 19

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Verified fixed with latest nightly build on Windows and Linux.

Litmus tests have been updated:
https://litmus.mozilla.org/show_test.cgi?id=9940
https://litmus.mozilla.org/show_test.cgi?id=10031