Closed
Bug 587243
Opened 14 years ago
Closed 14 years ago
Textbox of tab group lost focus immediately by keypress Eenter(Conversion Enter Commit) while IME composition
Categories
(Firefox Graveyard :: Panorama, defect)
Tracking
(blocking2.0 final+)
VERIFIED
FIXED
Firefox 4.0b7
| Tracking | Status | |
|---|---|---|
| blocking2.0 | --- | final+ |
People
(Reporter: alice0775, Assigned: masayuki)
References
Details
(Keywords: inputmethod, Whiteboard: [qa+])
Attachments
(1 file)
|
1.72 KB,
patch
|
Dolske
:
review+
iangilman
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b4pre) Gecko/20100813 Minefield/4.0b4pre ID:20100813041308
Build Identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b4pre) Gecko/20100813 Minefield/4.0b4pre ID:20100813041308
Textbox of tab group lost focus immediately by press Eenter while IME composition.
Reproducible: Always
Steps to Reproduce:
1. Start Minefield with new profile
2. Open TabView
3. Create Tab group
4. Edit title of the tab group by using IME (Microsoft IME or ATOK2006)
Actual Results:
Textbox of tab group lost focus immediately by press Eenter while IME composition
Expected Results:
Should not lose focus
|
Reporter | |
Updated•14 years ago
|
Summary: Textbox of tab group lost focus immediately by press Eenter while IME composition → Textbox of tab group lost focus immediately by keypress Eenter while IME composition
|
|
Reporter | |
Comment 1•14 years ago
|
||
This happens on Windows XP too.
Target Milestone: --- → Firefox 4.0
|
|
Reporter | |
Updated•14 years ago
|
Summary: Textbox of tab group lost focus immediately by keypress Eenter while IME composition → Textbox of tab group lost focus immediately by keypress Eenter(Conversion Enter Commit) while IME composition
|
Assignee | |
Comment 2•14 years ago
|
||
Typically, key events and IME events are dispatched following pattern:
* keydown
* compositionstart
...
* compositionend
* keyup
So, Enter and Esc keyup events are fired when they caused the composition to finish. So, we shouldn't use keyup event for them. And for preventing the parent's keydown handling such as quitting from grouping tab UI, this patch calls stopPropergation() and preventDefault() at handling Enter or Esc key.
This patch uses keydown event for Enter and Esc key handling. And keyup event is also used for adjusting title size and save.
|
|
Assignee | |
Updated•14 years ago
|
blocking2.0: --- → ?
|
||
Comment 3•14 years ago
|
||
Comment on attachment 471517 [details] [diff] [review]
Patch v1.0
Seems fine, ian should take a look though.
Attachment #471517 -
Flags: review?(ian)
Attachment #471517 -
Flags: review?(dolske)
Attachment #471517 -
Flags: review+
|
||
Comment 4•14 years ago
|
||
Comment on attachment 471517 [details] [diff] [review]
Patch v1.0
Looks good to me.
Attachment #471517 -
Flags: review?(ian)
Attachment #471517 -
Flags: review+
Attachment #471517 -
Flags: approval2.0?
|
|
||
Updated•14 years ago
|
blocking2.0: ? → final+
|
|
||
Updated•14 years ago
|
Attachment #471517 -
Flags: approval2.0?
|
|
Assignee | |
Comment 5•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: Firefox 4.0 → Firefox 4.0b6
|
||
Comment 6•14 years ago
|
||
reporter, please verify this is fixed in a current nightly, thanks.
Whiteboard: [qa+]
|
|
Reporter | |
Comment 7•14 years ago
|
||
This was fixed.
Verified on Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b7pre) Gecko/20101001 Firefox/4.0b7pre ID:20101001082844
Status: RESOLVED → VERIFIED
|
||
Updated•9 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•