588454 - Add new test suites (OpenGL, Direct 3D and Direct 2D) to TBPL

Status: VERIFIED FIXED

(Tree Management Graveyard :: TBPL, defect)

Description

[Armen [:armenzg]]

Please add the following test suites to TBPL.

This has high priority since we want to have coverage for beta 5.

The name of the builders are:
* Rev3 WINNT 6.1 $branch {opt|debug} test direct3D
* Rev3 WINNT 6.1 $branch {opt|debug} test reftest-d2d
* Rev3 Fedora 12 $branch {opt|debug} test opengl
* Rev3 Fedora 12x64 $branch {opt|debug} test opengl
* Rev3 MacOSX Leopard 10.5.8 $branch {opt|debug} test opengl
* Rev3 MacOSX Snow Leopard 10.6.2 $branch {opt|debug} test opengl

The later two are not currently being run but they will in the following weeks.

Comment 1

[Arpad Borsos [:Swatinem]]

Attachment: patch

The machines are not yet included in the tinderbox scrape, but it should work.
We desperately need to refactor the name parsing and display though.

Comment 2

[Arpad Borsos [:Swatinem]]

http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/0d90c44b26fa

Comment 3

[Armen [:armenzg]]

Wow that was fast!
Thanks guys.

BTW does this get picked up immediately by the server or will this be picked up in the next server maintenance window?

I can now see the RD2D suites in the noignore TBPL page!! :)

Comment 4

[Arpad Borsos [:Swatinem]]

RD2D was there for some time. Markus will push the new changes live sometime tomorrow.

Comment 5

[Markus Stange [:mstange]]

(In reply to comment #1)
> We desperately need to refactor the name parsing and display though.

Let's do when we update it for bug 586664.

(In reply to comment #3)
> BTW does this get picked up immediately by the server or will this be picked up
> in the next server maintenance window?

I updated the server an hour ago or so, so this is live now. I would have done it yesterday but I couldn't connect to any mozilla.org server then. I thought it had to do with the downtime but it turned out I just had to reboot my machine :)

Comment 6

[Arpad Borsos [:Swatinem]]

The patch was missing the tinderbox parsing parts (must have forgot to qref), will work up a new one.

Comment 7

[Markus Stange [:mstange]]

Heh, so much for my review... though I was wondering why only UserInterface.js needed to be updated when I uploaded it...

Comment 8

[Arpad Borsos [:Swatinem]]

Attachment: refactor machine type handling

This gets rid of the "o" suffix, as != debug = opt.

Comment 9

[Markus Stange [:mstange]]

I'd like to keep the "o" suffix for symmetry, please.

Alternatively we could give Opt and Debug results their own rows, maybe like this:

    * Linux Debug  B M(1 2 3 4 5 oth) C R J X
    * Linux Opt    B M(1 2 3 4 5 oth) C R J X T T T T T T T T T
    * ...

Comment 10

[Arpad Borsos [:Swatinem]]

Attachment: refactor machine type handling

going with the separate row approach as discussed.

Comment 11

[Markus Stange [:mstange]]

Comment on attachment 467386 [details] [diff] [review]
refactor machine type handling

>diff --git a/css/style.css b/css/style.css

> .results .os {
>   float: left;
>-  width: 60px;
>+  width: 90px;
>   word-spacing: 0;
> }

Please make it 100px and add white-space: nowrap; overflow: hidden;.

>diff --git a/js/UserInterface.js b/js/UserInterface.js

>   _resultTitle: function UserInterface__resultTitle(result) {
>-    var type = result.machine.type;
>+    var type = result.machine.type + " " + this._numberForMachine(result.machine) + (result.machine.debug ? " debug" : "");

Let's be explicit and add " opt" here, too. In a tooltip we have all the space we need.

Comment 12

[Arpad Borsos [:Swatinem]]

http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/c9760479e2c8
With nits fixed.

Comment 13

[Armen [:armenzg]]

I can go to http://tests.themasta.com/tinderboxpushlog/?tree=MozillaTry&noignore=1 and see RGL, R3D and R2D.

Thanks guys!

Comment 14

[Arpad Borsos [:Swatinem]]

Attachment: fix performance comparator

Some fallout from the patch, seems like nobody noticed, isn’t anybody using this feature?

Comment 15

[Markus Stange [:mstange]]

Comment on attachment 469496 [details] [diff] [review]
fix performance comparator

Remove the PerformanceComparator.js change.

Comment 16

[Armen [:armenzg]]

Which feature?
AFAIK what I needed showed up. Not that I look at it since I am just a releng and not a dev.

Comment 17

[Arpad Borsos [:Swatinem]]

Nevermind, it will be killed in bug 590960 anyway :D

Comment 18

[Arpad Borsos [:Swatinem]]

http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/8da43e30c313