Run reftests with Direct3D 9 accelerated layers on Windows desktop platform

RESOLVED FIXED

Status

defect
P2
normal
RESOLVED FIXED
9 years ago
6 years ago

People

(Reporter: joe, Assigned: armenzg)

Tracking

other
x86
macOS
Dependency tree / graph

Firefox Tracking Flags

(blocking2.0 beta5+)

Details

Attachments

(2 attachments, 4 obsolete attachments)

Just like bug 580410 - we need to automatically run our reftests with Direct3D 9 accelerated layers. First step is to make sure that they run through to completion, which I will take on before tossing this to RelEng.
Blocks: d3d9-layers
No longer blocks: 581202
Here's the way to run with hardware acceleration:

    export MOZ_ACCELERATED=11
    make reftests

Everything should 'just work' more or less (of course right now we get reftest
failures).
Assignee: joe → armenzg
blocking2.0: --- → beta5+
Status: NEW → ASSIGNED
Priority: -- → P3
I should get to this before the end of the week.

My understanding is that this has higher priority than bug 580410 and that is why I will tackle this first.
Priority: P3 → P2
I am going to enable OpenGL as well on the patch for this bug.

Tons of oranges but it seems that my patches are getting the job done.
http://tinderbox.mozilla.org/showlog.cgi?log=MozillaTest/1281723827.1281724773.25470.gz&fulltext=1

I will have to get my hands on a staging environment for several hours (I could only borrow one for a short time) to make sure that all the suites requested run on all platforms.
These patches have run through staging but as I mentioned on my previous comment. I want to make sure it runs for all platforms rather than just Linux64.

This patch also enables a11y for macosx which is wanted on bug 524775 and I willing to test it.
Attachment #465766 - Flags: feedback?(catlee)
Attachment #465767 - Flags: feedback?(catlee)
Comment on attachment 465767 [details] [diff] [review]
WIP [buildbot-configs] add Direct 3D 9 and OpenGL test suites plus a11y for macosx

Looks sane.  I'm not keen on 'OpenGL' - 'opengl' would be more consistent with the rest of our names.
Attachment #465767 - Flags: feedback?(catlee) → feedback+
Comment on attachment 465766 [details] [diff] [review]
WIP [buildbotcustom] add Direct 3D 9 and OpenGL suites

Same comments about uppercase names vs. lowercase.  I think keeping them all lower case is cleaner.
Attachment #465766 - Flags: feedback?(catlee) → feedback+
Could you guys please have a look at this Direct 3D run and tell me if it looks alright?
http://tinderbox.mozilla.org/showlog.cgi?log=MozillaTest/1281969809.1281970795.8356.gz
(In reply to comment #8)
> Could you guys please have a look at this Direct 3D run and tell me if it looks
> alright?
> http://tinderbox.mozilla.org/showlog.cgi?log=MozillaTest/1281969809.1281970795.8356.gz

The correct log is:
http://tinderbox.mozilla.org/showlog.cgi?log=MozillaTest/1281973439.1281974524.25694.gz
I have correct the naming.
Attachment #465766 - Attachment is obsolete: true
Attachment #466397 - Flags: review?(catlee)
There are curiously few failures in this log, but the failures aren't known so it's probably just fine! Let's go ahead with this.
This patch leaves the a11y suite *not* being run for Mac since it did not work (more info on bug 524775).
(The way of disabling is a little unorthodox. I welcome suggestions)

I chatted with joe and we are going to keep 10.6 without this test suite until they can loan a 10.6 machine from us to see why the test suite did not run correctly (see bug 580410 for more details). Having it enabled would have wasted CPU time since the job would only finish after 330 seconds timeout.
Attachment #465767 - Attachment is obsolete: true
Attachment #466401 - Flags: review?(catlee)
Attachment #466397 - Flags: review?(catlee) → review+
The difference with the previous patch is that we won't enable OpenGL for 10.5 until we figure out the issues with regard the resolution.

This also deals with the unorthodox way of getting read of a11y test suite for Mac.
Attachment #466401 - Attachment is obsolete: true
Attachment #466777 - Flags: review?(catlee)
Attachment #466401 - Flags: review?(catlee)
OK this should address your last comment on IRC with regards of making it a little more general (NOTE we can generalize even more but this does what we need now).

Again, I am only adding new test suites for Fedora and Windows.

I would like to deploy this on tomorrow's downtime if possible.
Attachment #466777 - Attachment is obsolete: true
Attachment #466826 - Flags: review?(catlee)
Attachment #466777 - Flags: review?(catlee)
Attachment #466826 - Flags: review?(catlee) → review+
Blocks: 586793
Comment on attachment 466397 [details] [diff] [review]
[buildbotcustom] Add steps for direct3d and opengl

http://hg.mozilla.org/build/buildbotcustom/rev/994771f2d07f
Attachment #466397 - Flags: checked-in+
Comment on attachment 466826 [details] [diff] [review]
[configs] enable OpenGL for Fedora and Direct3D for Windows

http://hg.mozilla.org/build/buildbot-configs/rev/77df5479bcc9
Attachment #466826 - Flags: checked-in+
Depends on: 588454
This has been deployed.

I have kept the test suite hidden on the Firefox tree until the GFX team brings down the count of permanent oranges to zero. AFAIK it is now on GFX's hand to keep track of these oranges and fix them (bug 586460).
If you find any infrastructure problem please file a separate bug or reopen this one.

Once the test suite is free of permanent oranges please go ahead and un-hide it. By then we should have bug 588454 fixed which currently prevents us from showing on TBPL this test suite.

Ping me on IRC or comment on this bug if you have any following questions.

AFAIK this is RESOLVED FIXED.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
This is perfect, Armen. Thank you.
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.