Closed Bug 588663 Opened 14 years ago Closed 14 years ago

investigate talos impact of 130078

Categories

(Core :: Layout, defect)

Product:
Core
Component:
Layout
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: tnikkel, Unassigned)

References

Details

Using http://perf.snarkfest.net/compare-talos/ we can compare try talos to some m-c talos results. Use these changesets. original rev 48487f904abe a9b21fa2b7ab 3a8430b73a91 8fb3151c8db4 new revision f9eb580dd56b new revision 05a791444e43 origina rev a75699fa48e3 3d4ba021c4dd 55953a91b4d6 f001894b50ea 9480e51be5b7 Some wins, some loses, some things look broken.
Another copy of that tool that might work better http://services.forerunnerdesigns.com/compare-talos/index.php
Links to the results so you don't have to re-enter the info http://services.forerunnerdesigns.com/compare-talos/index.php?oldRevs=48487f904abe,a9b21fa2b7ab,3a8430b73a91,8fb3151c8db4,&newRev=f9eb580dd56b&tests=a11y,tdhtml,tdhtml_nochrome,tp4,tp4_memset,tp4_pbytes,tp4_rss,tp4_shutdown,tp4_xres,dromaeo_basics,dromaeo_css,dromaeo_dom,dromaeo_jslib,dromaeo_sunspider,dromaeo_v8,tsspider,tsspider_nochrome,tgfx,tgfx_nochrome,tscroll,tsvg,tsvg_opacity,ts,ts_cold,ts_cold_generated_max,ts_cold_generated_max_shutdown,ts_cold_generated_med,ts_cold_generated_med_shutdown,ts_cold_generated_min,ts_cold_generated_min_shutdown,ts_cold_shutdown,ts_places_generated_max,ts_places_generated_max_shutdown,ts_places_generated_med,ts_places_generated_med_shutdown,ts_places_generated_min,ts_places_generated_min_shutdown,ts_shutdown,twinopen&submit=true http://services.forerunnerdesigns.com/compare-talos/index.php?oldRevs=a75699fa48e3,3d4ba021c4dd,55953a91b4d6,f001894b50ea,9480e51be5b7&newRev=05a791444e43&tests=a11y,tdhtml,tdhtml_nochrome,tp4,tp4_memset,tp4_pbytes,tp4_rss,tp4_shutdown,tp4_xres,dromaeo_basics,dromaeo_css,dromaeo_dom,dromaeo_jslib,dromaeo_sunspider,dromaeo_v8,tsspider,tsspider_nochrome,tgfx,tgfx_nochrome,tscroll,tsvg,tsvg_opacity,ts,ts_cold,ts_cold_generated_max,ts_cold_generated_max_shutdown,ts_cold_generated_med,ts_cold_generated_med_shutdown,ts_cold_generated_min,ts_cold_generated_min_shutdown,ts_cold_shutdown,ts_places_generated_max,ts_places_generated_max_shutdown,ts_places_generated_med,ts_places_generated_med_shutdown,ts_places_generated_min,ts_places_generated_min_shutdown,ts_shutdown,twinopen&submit=true
Depends on: 589396
New numbers: new rev f46b618cc0ab orig 01d7e7401b33 99367f10f79e 87677ea8efa3 6d8a749a3c57 c6da8fefd6a8 http://services.forerunnerdesigns.com/compare-talos/index.php?oldRevs=01d7e7401b33,99367f10f79e,87677ea8efa3,6d8a749a3c57,c6da8fefd6a8&newRev=f46b618cc0ab&tests=a11y,tdhtml,tdhtml_nochrome,tp4,tp4_memset,tp4_pbytes,tp4_rss,tp4_shutdown,tp4_xres,dromaeo_basics,dromaeo_css,dromaeo_dom,dromaeo_jslib,dromaeo_sunspider,dromaeo_v8,tsspider,tsspider_nochrome,tgfx,tgfx_nochrome,tscroll,tsvg,tsvg_opacity,ts,ts_cold,ts_cold_generated_max,ts_cold_generated_max_shutdown,ts_cold_generated_med,ts_cold_generated_med_shutdown,ts_cold_generated_min,ts_cold_generated_min_shutdown,ts_cold_shutdown,ts_places_generated_max,ts_places_generated_max_shutdown,ts_places_generated_med,ts_places_generated_med_shutdown,ts_places_generated_min,ts_places_generated_min_shutdown,ts_shutdown,twinopen&submit=true new rev cf64eea45e07 orig 160a97bac310 98ad1cc8627e dc804317e500 810ff22372ac 3e4fc3864378 http://services.forerunnerdesigns.com/compare-talos/index.php?oldRevs=160a97bac310,98ad1cc8627e,dc804317e500,810ff22372ac,3e4fc3864378&newRev=cf64eea45e07&tests=a11y,tdhtml,tdhtml_nochrome,tp4,tp4_memset,tp4_pbytes,tp4_rss,tp4_shutdown,tp4_xres,dromaeo_basics,dromaeo_css,dromaeo_dom,dromaeo_jslib,dromaeo_sunspider,dromaeo_v8,tsspider,tsspider_nochrome,tgfx,tgfx_nochrome,tscroll,tsvg,tsvg_opacity,ts,ts_cold,ts_cold_generated_max,ts_cold_generated_max_shutdown,ts_cold_generated_med,ts_cold_generated_med_shutdown,ts_cold_generated_min,ts_cold_generated_min_shutdown,ts_cold_shutdown,ts_places_generated_max,ts_places_generated_max_shutdown,ts_places_generated_med,ts_places_generated_med_shutdown,ts_places_generated_min,ts_places_generated_min_shutdown,ts_shutdown,twinopen&submit=true
I guess Tp4 still needs investigation. Tp4_xres on Linux-32 too. Maybe the latter one would be easier to figure out and give us wins on other platforms if we can fix it.
Tp4_xres on linux 32 is in bytes, so it goes from ~700 bytes to ~2000 bytes. For comparison Tp4_xres on linux 64 is ~13 MB. I compared a build with and without 130078 (not based on the same revision, but fairly close) on linux 64 and the build with 130078 was 1MB smaller. That was only one run, so I don't know if that's enough to see whats going on. Tp4 on mac (32bit) and winxp are the ones that seem to show a regression. All other platforms seem to show an improvement or within the normal bounds.
Discussed linux Tp4_xres numbers on irc with roc and Karl. We concluded there is no way the 32 bit numbers can represent anything meaningful.
new rev 44cbdbf82ad9 orig revs f1b1e827d401 18bb00bd1564 39755990a9ae 13adb6fe5ca0 d207cb43a7bf http://services.forerunnerdesigns.com/compare-talos/index.html?oldRevs=f1b1e827d401,18bb00bd1564,39755990a9ae,13adb6fe5ca0,d207cb43a7bf&newRev=44cbdbf82ad9&tests=a11y,tdhtml,tdhtml_nochrome,tp4,tp4_memset,tp4_pbytes,tp4_rss,tp4_shutdown,tp4_xres,dromaeo_basics,dromaeo_css,dromaeo_dom,dromaeo_jslib,dromaeo_sunspider,dromaeo_v8,tsspider,tsspider_nochrome,tgfx,tgfx_nochrome,tscroll,tsvg,tsvg_opacity,ts,ts_cold,ts_cold_generated_max,ts_cold_generated_max_shutdown,ts_cold_generated_med,ts_cold_generated_med_shutdown,ts_cold_generated_min,ts_cold_generated_min_shutdown,ts_cold_shutdown,ts_places_generated_max,ts_places_generated_max_shutdown,ts_places_generated_med,ts_places_generated_med_shutdown,ts_places_generated_min,ts_places_generated_min_shutdown,ts_shutdown,twinopen&submit=true new rev 03a19452a127 orig revs f1b1e827d401 18bb00bd1564 39755990a9ae 13adb6fe5ca0 d207cb43a7bf http://services.forerunnerdesigns.com/compare-talos/index.html?oldRevs=f1b1e827d401,18bb00bd1564,39755990a9ae,13adb6fe5ca0,d207cb43a7bf&newRev=03a19452a127&tests=a11y,tdhtml,tdhtml_nochrome,tp4,tp4_memset,tp4_pbytes,tp4_rss,tp4_shutdown,tp4_xres,dromaeo_basics,dromaeo_css,dromaeo_dom,dromaeo_jslib,dromaeo_sunspider,dromaeo_v8,tsspider,tsspider_nochrome,tgfx,tgfx_nochrome,tscroll,tsvg,tsvg_opacity,ts,ts_cold,ts_cold_generated_max,ts_cold_generated_max_shutdown,ts_cold_generated_med,ts_cold_generated_med_shutdown,ts_cold_generated_min,ts_cold_generated_min_shutdown,ts_cold_shutdown,ts_places_generated_max,ts_places_generated_max_shutdown,ts_places_generated_med,ts_places_generated_med_shutdown,ts_places_generated_min,ts_places_generated_min_shutdown,ts_shutdown,twinopen&submit=true
As discussed on IRC, paint suppression is likely to be an issue here for the Tp4 numbers.
The automated talos scripts flagged the Tp4 Xres increase and the mac Tp4 increase.
Bug 591435 landed and turned all Tp4 results into mostly wins, and a few no change from per 130078. Calling this resolved.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.