590105 - Make bookmarks panel an arrow panel

Status: RESOLVED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[Robert Kaiser]

Bug 586947 adds a really ugly panel header to the add/edit bookmark panel in the browser window, that should be replaced with making it an arrow panel instead, pointing to the bookmark icon in the url bar.

Comment 1

[Nochum Sossonko [:Natch]]

See Firefox equivalent bug 597557.

Comment 2

[Robert Kaiser]

Bug 597557 and bug 606343, part 3 have landed the Firefox version of this, it seems we are missing or otherwise not having a lot of the style rules for this panel, so porting is very easy, I should have it locally, but need to test as much as possible on Linux (I think we don't really support the correct arrow panel look on Linux yet).

Comment 3

[Robert Kaiser]

Attachment: v1: First try

In theory, this should do it, but I can't test it much on Linux, as arrow panels aren't implemented correctly yet on that platform.

Comment 4

[[e-mail]]

Bah, if only I had a build on which arrow panels worked properly :-(

/me sets about rebuilding...

Comment 5

[Robert Kaiser]

(In reply to comment #4)
> Bah, if only I had a build on which arrow panels worked properly :-(

Oh, I thought you did as you have been doing some reviews over there...

Comment 6

[[e-mail]]

Comment on attachment 495827 [details] [diff] [review]
v1: First try

We need a bug on getting arrow panels to work in Modern, it sort of works but there's some weird effect on the description textbox.

I had a patch to improve the display of this popup (move the button, improve the title) but sadly this patch improves the popup in an incompatible way :-( I wonder whether firefox's bookmark panel still looks this bad.

Comment 7

[Robert Kaiser]

Pushed as http://hg.mozilla.org/comm-central/rev/ecf45b984521

(In reply to comment #6)
> We need a bug on getting arrow panels to work in Modern, it sort of works but
> there's some weird effect on the description textbox.

Sure, filed as bug 617661.

> I had a patch to improve the display of this popup (move the button, improve
> the title) but sadly this patch improves the popup in an incompatible way :-( I
> wonder whether firefox's bookmark panel still looks this bad.

They have a number of CSS rules for this panel which we don't have, so I suspect it might actually look better on their side.