Make bookmarks panel an arrow panel

RESOLVED FIXED in seamonkey2.1b2

Status

SeaMonkey
Bookmarks & History
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Robert Kaiser, Assigned: Robert Kaiser)

Tracking

(Blocks: 1 bug)

Trunk
seamonkey2.1b2
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

2.97 KB, patch
neil@parkwaycc.co.uk
: review+
neil@parkwaycc.co.uk
: ui-review+
Details | Diff | Splinter Review
(Assignee)

Description

7 years ago
Bug 586947 adds a really ugly panel header to the add/edit bookmark panel in the browser window, that should be replaced with making it an arrow panel instead, pointing to the bookmark icon in the url bar.
See Firefox equivalent bug 597557.
(Assignee)

Updated

7 years ago
Summary: Remove ugly panel title and make bookmarks panel an arrow panel → Make bookmarks panel an arrow panel
(Assignee)

Comment 2

7 years ago
Bug 597557 and bug 606343, part 3 have landed the Firefox version of this, it seems we are missing or otherwise not having a lot of the style rules for this panel, so porting is very easy, I should have it locally, but need to test as much as possible on Linux (I think we don't really support the correct arrow panel look on Linux yet).
(Assignee)

Comment 3

7 years ago
Created attachment 495827 [details] [diff] [review]
v1: First try

In theory, this should do it, but I can't test it much on Linux, as arrow panels aren't implemented correctly yet on that platform.
Assignee: nobody → kairo
Status: NEW → ASSIGNED
Attachment #495827 - Flags: ui-review?(neil)
Attachment #495827 - Flags: review?(neil)

Comment 4

7 years ago
Bah, if only I had a build on which arrow panels worked properly :-(

/me sets about rebuilding...
(Assignee)

Comment 5

7 years ago
(In reply to comment #4)
> Bah, if only I had a build on which arrow panels worked properly :-(

Oh, I thought you did as you have been doing some reviews over there...

Comment 6

7 years ago
Comment on attachment 495827 [details] [diff] [review]
v1: First try

We need a bug on getting arrow panels to work in Modern, it sort of works but there's some weird effect on the description textbox.

I had a patch to improve the display of this popup (move the button, improve the title) but sadly this patch improves the popup in an incompatible way :-( I wonder whether firefox's bookmark panel still looks this bad.
Attachment #495827 - Flags: ui-review?(neil)
Attachment #495827 - Flags: ui-review+
Attachment #495827 - Flags: review?(neil)
Attachment #495827 - Flags: review+
(Assignee)

Comment 7

7 years ago
Pushed as http://hg.mozilla.org/comm-central/rev/ecf45b984521

(In reply to comment #6)
> We need a bug on getting arrow panels to work in Modern, it sort of works but
> there's some weird effect on the description textbox.

Sure, filed as bug 617661.

> I had a patch to improve the display of this popup (move the button, improve
> the title) but sadly this patch improves the popup in an incompatible way :-( I
> wonder whether firefox's bookmark panel still looks this bad.

They have a number of CSS rules for this panel which we don't have, so I suspect it might actually look better on their side.
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1b2

Updated

7 years ago
Blocks: 620132

Updated

7 years ago
Blocks: 620417
You need to log in before you can comment on or make changes to this bug.