590350 - In "List view", There is almost same appearance with disabled extension and enabled extension

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Alice0775 White]

Attachment: screenshot

Build Identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b5pre) Gecko/20100824 Minefield/4.0b5pre ID:20100824040950

After landing of bug 585950, 
In "List view", There is almost same appearance with disabled extension and enabled extension.

Text color or background color of extension should have more differences.

Comment 1

[Roland Warmerdam]

Attachment: Changes addon opacity when disabled

Attached a patch that lowers the opacity of the addon's text and icon when it's disabled. Change has been tested in Linux.

Comment 2

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Comment on attachment 473949 [details] [diff] [review]
Changes addon opacity when disabled

It originally used opacity to do this (was removed in bug 585950, I think). Unfortunately, it doesn't look as good as it could, especially on Windows. See bug 562865, and the attached screenshot there. The recommendation in that bug was to just use a lighter color.

We still have a bunch of elements in the addon binding (in extensions.xml) that have class="fade" - which was added to make this easier. I'm fine with not using that, but it should probably be removed if that's the case.

Comment 4

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Attachment: Mockup: notification states of add-ons

For easy reference, here is Boriss's mockup from bug 553658.

Comment 6

[Roland Warmerdam]

Attachment: Adds a grey background gradients and changes the icon opacity

Applies the same background gradient used for the pending disabled state to the disabled state and changes both the pending disabled and disabled states to have a faded icon.

Comment 7

[Blair McBride [:Unfocused] (UNAVAILABLE)]

(In reply to comment #6)
> Created attachment 481367 [details] [diff] [review]
> Adds a grey background gradients and changes the icon opacity
> 
> Applies the same background gradient used for the pending disabled state to the
> disabled state and changes both the pending disabled and disabled states to
> have a faded icon.

Sorry, I should have commented here to make it clear when I reassigned this to myself. Since this bug was sitting for quite awhile without activity, I merged it into the theme work I've done for bug 601022 (along with a bunch of other bugs) - which also ends up changing what needs to be done to make disabled items look right.

Comment 10

[Dave Townsend [:mossop]]

Fixed by bug 601022, file any remaining issues separately

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Marking as verified fixed with builds on all platforms like Mozilla/5.0 (X11;
Linux i686; rv:2.0b8pre) Gecko/20101125 Firefox/4.0b8pre ID:20101125030318