591120 - Change flow of setup wizard

Status: VERIFIED FIXED

(Firefox :: Sync, defect)

Description

[Philipp von Weitershausen [:philikon]]

Mostly involves moving engine and first sync settings into separate Sync Options dialog.

Comment 1

[Philipp von Weitershausen [:philikon]]

The Sync Options dialog looks like another wizard page in the mockup, but I think it makes more sense to implement it was a dialog. It's clearly modal and it will be reused for Reset Sync (yes, we reuse the wizard there right now, but that always felt weird to me).

Comment 2

[Philipp von Weitershausen [:philikon]]

The only problem with making this a dialog is that Reset Sync would lose the confirmation page. But we don't really have it in the wizard anymore, either (unless you count the Setup Complete page as such).

Thoughts?

Comment 3

[Philipp von Weitershausen [:philikon]]

Attachment: v1

This changes the setup flow to match Alex's mockups.

Some notes:

* This does change strings where appropriate, but it might not have covered all. We should probably revise any outstanding strings in a separate bug.

* While the size of the wizard and the styling of certain elements are changed, this isn't meant to include any significant styling changes. See bug 591122 and bug 592839 for those.

Comment 4

[Philipp von Weitershausen [:philikon]]

Attachment: v1.1

Small rev on v1: Also switch over the accesskey when relabeling the buttons (for going into the Sync Options part of the wizard).

Comment 5

[Philipp von Weitershausen [:philikon]]

Attachment: v2

Incorporate faaborg's feedback:
* Rename the "Create you Firefox Sync Account" page to "Account Details" as per mockups.
* Rename and move the "Server" form field as per mockups.
* Check email validity when the textbox loses focus, not on every character.
* Display captcha error messages inline instead of prompting an alert dialog.

Comment 6

[Philipp von Weitershausen [:philikon]]

Attachment: v2.1

One more feedback from faaborg:
* Use syncBrand.shortName (Sync) instead of syncBrand.fullName (Firefox Sync) on Sync Options page.

Comment 7

[Philipp von Weitershausen [:philikon]]

http://hg.mozilla.org/services/fx-sync/rev/03b8a6b3958e

Comment 8

[Kevin Brosnan]

Verified. Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b7pre) Gecko/20100924 Firefox/4.0b7pre