Legacy user images don't show up if they aren't PNGs

VERIFIED FIXED in 5.11.10

Status

P1
normal
VERIFIED FIXED
8 years ago
3 years ago

People

(Reporter: clouserw, Assigned: clouserw)

Tracking

unspecified
5.11.10
Dependency tree / graph

Details

(Assignee)

Description

8 years ago
Zamboni hard codes user images as .png (both in the USER_PIC_* settings and in the UserProfile model).  The good news is, if people upload new images, they are converted to be a .png.  The bad news is, old images aren't.

We should convert the old images to pngs.
(Assignee)

Comment 1

8 years ago
in the script that looks for these files, it should check if $userid.png exists already, and if so just remove the .jpg or .gif.  Otherwise, convert the old image to .png and remove it.
Assignee: nobody → clouserw
Priority: -- → P1
(Assignee)

Comment 2

8 years ago
http://github.com/jbalogh/zamboni/commit/d3a8a4ae6921a20e22061036e40e753b4ec03dd4, will run with next push
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED

Updated

8 years ago
Target Milestone: 5.12 → 5.11.10
My understanding is that we (WebQA) should wait for bug 595247, then have Wil re-run the script on PAMO, before verifying.
Depends on: 595247
(Assignee)

Comment 5

8 years ago
You can verify it right now if you want.  I'm just saying that when that bug runs, it'll reset this, but until it runs, this bug is fixed.
(In reply to comment #5)
> You can verify it right now if you want.  I'm just saying that when that bug
> runs, it'll reset this, but until it runs, this bug is fixed.

Thx; since bug 595247 is now fixed, mind re-running the script?
(Assignee)

Comment 7

8 years ago
(In reply to comment #6)
> (In reply to comment #5)
> > You can verify it right now if you want.  I'm just saying that when that bug
> > runs, it'll reset this, but until it runs, this bug is fixed.
> 
> Thx; since bug 595247 is now fixed, mind re-running the script?

He said it wouldn't be done for a few hours
I spun off a bug for fligtar's pic, which still isn't showing up on prod: bug 596477.
Depends on: 596477
Verified FIXED.
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.