593618 - [d3d9] reftest failures: bugs/433700.html and border-radius/clipping-3.html

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: reftest images

Optimistically filing these together since I think they're the same issue.  These are failing on the try server.

Top image is 433700 (test and ref), bottom is border-radius (test and ref).  Note the extra black in both of the test images.

Comment 1

[Joe Drew (not getting mail)]

This fails in the same way if we're using D3D9 + GDI too.

Comment 2

[Joe Drew (not getting mail)]

Attachment: draw the visible bounds instead of just the visible regions

This seems to fix both these reftests, and is currently running through birch. It makes sense, and seems to replicate some of the logic in ThebesLayerBuffer.

One thing I don't know, though, is if we've got an opaque surface, why isn't the background part of the visible region list?

Comment 3

[Joe Drew (not getting mail)]

Attachment: Update comment, and address Bas's review comments on IRC

Comment 4

[Bas Schouten (:bas.schouten)]

Comment on attachment 472202 [details] [diff] [review]
Update comment, and address Bas's review comments on IRC

Looks good to me, we need to check if our quad isn't covering anything now that is expected to show through this layer because it's not in the visible region. I don't think this is happening right now but if it might be expected going forward we'll need to fix that.

It's not too hard, just requires us to draw a couple of quads and add some logic for texture coordinates. I think this is just fine for now though!

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 472202 [details] [diff] [review]
Update comment, and address Bas's review comments on IRC

You have a problem here, which is that we mark the layer opaque if it's opaque in its visible region. The part outside the region (but inside the region bounds) might be transparent.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

So it's disturbing that your "valid region" can contain areas of the layer that are transparent, but you've rendered them into an opaque buffer.

However, this doesn't seem to be a problem because the layers API guarantees for SetVisibleRegion:
 It is the responsibility
   * of the caller to ensure that content outside this region does not
   * contribute to the final visible window. 
If the state of the window changes so that the problematic area is still marked valid, but becomes visible, then the layer would have to change from opaque to transparent so we'd redraw everything anyway.

So I can't see any real problem here, although the invariants are more subtle that one would like.

Comment 7

[Joe Drew (not getting mail)]

http://hg.mozilla.org/mozilla-central/rev/43a27c6eb652