Bug 581212 (d3d9-layers)

[tracking bug] Turn on Direct3D 9 accelerated layers for at least some subset of hardware

RESOLVED FIXED

Status

()

Core
Graphics
RESOLVED FIXED
7 years ago
4 years ago

People

(Reporter: Joe Drew (not getting mail), Assigned: Joe Drew (not getting mail))

Tracking

(Depends on: 1 bug, {meta})

Trunk
All
Windows XP
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(blocking2.0 beta7+)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Updated

7 years ago
Depends on: 581213
Who owns this?  Need an owner ASAP.
(Assignee)

Comment 2

7 years ago
It's a tracking bug, so it doesn't really need an owner. But let's give it one anyways.
Assignee: nobody → bas.schouten
(Assignee)

Updated

7 years ago
Depends on: 584536
(Assignee)

Updated

7 years ago
Depends on: 585248, 584754, 584539
(Assignee)

Updated

7 years ago
Depends on: 586459
(Assignee)

Updated

7 years ago
Depends on: 586460
Depends on: 588212
Depends on: 589097

Updated

7 years ago
Depends on: 589242
No longer depends on: 588212, 589097
Depends on: 589395

Updated

7 years ago
Keywords: meta

Updated

7 years ago
Blocks: 564978
(Assignee)

Updated

7 years ago
Depends on: 592396
Depends on: 593219
Depends on: 592870
Alias: d3d9-layers
No longer depends on: 584536
Depends on: 584536
No longer depends on: 593219
No longer depends on: 584536
Depends on: 593275
Depends on: 593273
blocking2.0: betaN+ → beta6+
Depends on: 593272
Depends on: 593438
This looks like it is caused by us getting confused about whether we should be using an accelerated layer manager or not. The following fixes the problem but may not be correct:

diff --git a/widget/src/windows/nsWindow.cpp b/widget/src/windows/nsWindow.cpp
--- a/widget/src/windows/nsWindow.cpp
+++ b/widget/src/windows/nsWindow.cpp
@@ -3164,17 +3164,17 @@ nsWindow::GetLayerManager()
 {
   nsWindow *topWindow = GetNSWindowPtr(GetTopLevelHWND(mWnd, PR_TRUE));

   if (!topWindow) {
     return nsBaseWidget::GetLayerManager();
   }

   if (topWindow->GetAcceleratedRendering() != mUseAcceleratedRendering) {
-    mLayerManager = NULL;
+    //mLayerManager = NULL;
     mUseAcceleratedRendering = topWindow->GetAcceleratedRendering();
   }

 #ifndef WINCE
   if (!mLayerManager) {
     nsCOMPtr<nsIPrefBranch2> prefs = do_GetService(NS_PREFSERVICE_CONTRACTID);

     PRBool accelerateByDefault = PR_TRUE;
Depends on: 591155
No longer depends on: 586459
(In reply to comment #3)
Wrong bug.
(Assignee)

Updated

7 years ago
Depends on: 593450
(Assignee)

Comment 5

7 years ago
Created attachment 471966 [details] [diff] [review]
set layers.accelerate-all to true on windows
Assignee: bas.schouten → joe
Attachment #471966 - Flags: review?(vladimir)
(Assignee)

Updated

7 years ago
Depends on: 593521
(Assignee)

Updated

7 years ago
Depends on: 593530
(Assignee)

Updated

7 years ago
Depends on: 593471
No longer depends on: 593471
(Assignee)

Updated

7 years ago
No longer depends on: 593450
Attachment #471966 - Flags: review?(vladimir) → review+
(Assignee)

Comment 6

7 years ago
http://hg.mozilla.org/mozilla-central/rev/2fd612733112
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
(Assignee)

Comment 7

7 years ago
Backed out because roc's reftest patch bounced, and without that we don't have reftest coverage of d3d9.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Updated

7 years ago
Depends on: 593600

Updated

7 years ago
Depends on: 593603
Depends on: 593618
Depends on: 593647
(Assignee)

Comment 8

7 years ago
http://hg.mozilla.org/mozilla-central/rev/fd13b6ce36bd
Status: REOPENED → RESOLVED
Last Resolved: 7 years ago7 years ago
Resolution: --- → FIXED
(Assignee)

Updated

7 years ago
No longer depends on: 593603
(Assignee)

Updated

7 years ago
No longer depends on: 593600

Comment 9

7 years ago
Seems that all Intel Graphics users still get a crash at startup with layers.accelerate-all set to true. Now that it's enabled by default all of them will get a crash ;)

Crash ID leads to this bug (see latest comments): https://bugzilla.mozilla.org/show_bug.cgi?id=590695

Comment 10

7 years ago
Mozilla/5.0 (Windows NT 5.1; rv:2.0b6pre) Gecko/20100905 Firefox/4.0b6pre

Hmmm ... I got a black window, only the locationbar was white. No crash though. This is on a Lenovo T400 laptop with XP SP3 on it, with the typical Intel GMA graphics crap (X4500HD).

  Graphics

        Adapter Description

        Vendor ID
        0000

        Device ID
        0000

        Adapter RAM
        Unknown

        Adapter Drivers
        Unknown

        Driver Version

        Driver Date

        Direct2D Enabled
        false

        DirectWrite Enabled
        false

      GPU Accelerated Layers Enabled
      1/1 Direct3D 9

Error Console:
Direct3D 9 DeviceManager Initialized Succesfully.
Driver: igxprd32.dll
Description: Mobile Intel(R) 4 Series Express Chipset Family
Version: 6.14.10.4990

When I change layers.accelerate-all to true, it becomes :


  Graphics

        Adapter Description

        Vendor ID
        0000

        Device ID
        0000

        Adapter RAM
        Unknown

        Adapter Drivers
        Unknown

        Driver Version

        Driver Date

        Direct2D Enabled
        false

        DirectWrite Enabled
        false

      GPU Accelerated Layers Enabled
      0/2

After playing around in other applications (I'm typing this in a Firefox
3.6.8), the browser went into normal mode again, and was perfectly usable.

Comment 11

7 years ago
(In reply to comment #9)
> Seems that all Intel Graphics users still get a crash at startup with
> layers.accelerate-all set to true. 

not all.
no crash here.

Mobile Intel(R) 945 Express Chipset Family
Intel(R) GMA 950

main driver : igxprd32.dll
version : 6.14.0010.4926

XP SP3

I don't know why D2D/D3D off by default (new/clean profile) on this PC.
passed DirectDraw/D3D test by DirectX tool(dxdiag).


BTW, what is system requirement (some subset of hardware in bug title) ?

Comment 12

7 years ago
Ok, seems that "new" Intel graphics Chips aren't crashing, or it's OS or driver dependant.

I know at least that GMA 950 and GM 3150 crashes on startup. Thats the first
and second Intel ATOM generation. Means a lot of Netbook and Nettop users.

Maybe it's OS or driver dependant and thats why it doesn't crash on XP for pal-moz. Im using GMA 950 on Win7 and it crashes on startup. Newest Intel driver is installed of course.
Depends on: 590695

Comment 13

7 years ago
Nice it works now fine on XP :) no more http://img840.imageshack.us/f/renderingproblem.png/ or https://bugzilla.mozilla.org/show_bug.cgi?id=589357
though the Rendering speed of Tab Candy didn't really enhanced that much but no truncation issues @ least anymore :)

Updated

7 years ago
Depends on: 593738

Comment 14

7 years ago
I don't know if there's a more appropriate bug or page collating this information but FWIW on the following Dell/Win7 system I get an entirely black window (except for the Aero glass areas) with the latest nightly unless I turn off layers.accelerate-all.

Mozilla/5.0 (Windows NT 6.1; rv:2.0b6pre) Gecko/20100905 Firefox/4.0b6pre

Adapter Description: Intel(R) G41 Express Chipset
Vendor ID: 8086
Device ID: 2e32
Adapter RAM: Unknown
Adapter Drivers: igdumdx32 igd10umd32
Driver Version: 8.15.10.2119
Driver Date: 4-21-2010
Direct2D Enabled: true
DirectWrite Enabled: true

Updated

7 years ago
Depends on: 593839
Depends on: 593860
Depends on: 593792
Depends on: 593750

Updated

7 years ago
Depends on: 593858
Depends on: 593888
Depends on: 593879

Updated

7 years ago
Depends on: 593666

Updated

7 years ago
Depends on: 593600

Updated

7 years ago
Depends on: 593961

Updated

7 years ago
Depends on: 593833

Updated

7 years ago
Depends on: 594254

Updated

7 years ago
Depends on: 594255

Updated

7 years ago
Depends on: 594275

Updated

7 years ago
Depends on: 594299

Comment 15

7 years ago
Just noticed, the animated throbber on tbpl isn't animating with this on and d2d enabled. Not sure if one of the blocking bugs matches up for this. I can file a new one if need be.

Comment 16

7 years ago
(In reply to comment #15)
> Just noticed, the animated throbber on tbpl isn't animating with this on and
> d2d enabled. Not sure if one of the blocking bugs matches up for this. I can
> file a new one if need be.

actually, I'm not sure that throbber ever animated. nm! I can reproduce with this off. NM!
Depends on: 594774

Updated

7 years ago
Depends on: 593779
Depends on: 595471
Depends on: 596152

Comment 17

7 years ago
I think we need more hardware accel. on systems with XP!
Tab Candy is a bit faster now.. but still.. SLOW!

Please, don't release 4.0 with current state of acceleration..

Updated

7 years ago
Depends on: 598754

Updated

7 years ago
Depends on: 590568, 618556

Updated

7 years ago
Depends on: 612007

Updated

7 years ago
Depends on: 620287

Updated

7 years ago
Depends on: 622384
Depends on: 621994

Updated

6 years ago
Depends on: 644787

Updated

6 years ago
Depends on: 645872

Updated

6 years ago
No longer depends on: 645872

Updated

6 years ago
Depends on: 660264

Updated

6 years ago
Depends on: 693191
You need to log in before you can comment on or make changes to this bug.