594458 - Merge Discovery Pane into zamboni template

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Discovery Pane, defect, P1)

Description

[Justin Scott [:fligtar]]

Please take the assets from bug 582433 and update our discovery pane template in Zamboni (currently at https://services.addons.mozilla.org/en-US/firefox/discovery/4.0b5pre/Darwin )

We're hoping to launch this on Tuesday. This initial landing won't need QA or l10n quite yet as we'll still have a number of things left to do in upcoming releases to get it ready.

Comment 1

[Jeff Balogh (:jbalogh)]

(In reply to comment #0)
> We're hoping to launch this on Tuesday. This initial landing won't need QA or
> l10n quite yet as we'll still have a number of things left to do in upcoming
> releases to get it ready.

Strings should still be marked for L10n because it sucks to add that in later.

Comment 2

[Gregory Koberger (:gkoberger)]

http://github.com/jbalogh/zamboni/commit/2f3a1f1

Comment 3

[Justin Scott [:fligtar]]

A couple outstanding issues that Greg is aware of:
* The JS file isn't being minified and is 404, making the carousel and other parts of the page quite angry

* The lack of 'pre' placeholder is still showing up.

I'm planning to work on this a bit this weekend, so if someone can help him with the JS file that would be awesome.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Justin, what's left to do until we can start testing the discovery pane?

Stephen, is the web content part something your team will take care of?

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #4)
> Justin, what's left to do until we can start testing the discovery pane?
> 
> Stephen, is the web content part something your team will take care of?

We should probably talk; you might be more familiar with it than us, but we'll certainly test it from our side too (links, validation, API).

Mocks here: http://people.mozilla.com/~chowse/drop/amo/discovery/
Spec: https://docs.google.com/Doc?docid=0Acwo2Bn17-PrZGZudHRobnJfNDJ0cTV0NjRnZA&hl=en

Comment 6

[Justin Scott [:fligtar]]

Re-opening as comment #3 (item 1) is still blocking any further progress on this.

Comment 7

[Gregory Koberger (:gkoberger)]

http://github.com/jbalogh/zamboni/commit/88b2729

Darn quotation marks

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to comment #5)
> > Stephen, is the web content part something your team will take care of?
> 
> We should probably talk; you might be more familiar with it than us, but we'll
> certainly test it from our side too (links, validation, API).

Sorry, I forgot about it during this week. :/ But it looks like that you already work on the content part. So I can cover the client.

We are live with the first version and this bug should be verified fixed.