594624 - [D2D][D3D9] Content Type switches not supported properly

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Bas Schouten (:bas.schouten)]

When CanUseOpaqueSurface() changes during the lifetime of a layer, when using just GDI this causes the texture to be recreated. With D2D this does not happen since it always uses a D3DFMT_A8R8G8B8, and the surface content type determines how its drawn. We should verify this and recreate the surface if needed.

Comment 1

[Bas Schouten (:bas.schouten)]

Attachment: Toss out surface on content type change

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

We should be able to get a reftest here.

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 473317 [details] [diff] [review]
Toss out surface on content type change

Seems like this should be a function instead of duplicating the code. Make sure you put the #ifdef CAIRO_HAS_D2D_SURFACE inside the function so that you don't clutter up the callers. You should also put together a reftest for this.

Comment 4

[Bas Schouten (:bas.schouten)]

Attachment: Toss out surface on content type change v2

Adjusted for review comments. Will create a reftest for this tomorrow.

Comment 5

[Bas Schouten (:bas.schouten)]

Attachment: Reftest for content type changes

This reftest seems to do the job, it's the most reduced thing I can come up with.

Comment 6

[Bas Schouten (:bas.schouten)]

http://hg.mozilla.org/mozilla-central/rev/d0f924de4cf7
http://hg.mozilla.org/mozilla-central/rev/085ee83e9775