Last Comment Bug 595027 - Failing hg clone step was green
: Failing hg clone step was green
Product: Release Engineering
Classification: Other
Component: Other (show other bugs)
: other
: x86 Linux
: -- major (vote)
: ---
Assigned To: Ben Hearsum (:bhearsum)
: 596709 600337 (view as bug list)
Depends on:
Blocks: 505512 releng-downtime
  Show dependency treegraph
Reported: 2010-09-09 16:57 PDT by Nick Thomas [:nthomas]
Modified: 2013-08-12 21:54 PDT (History)
3 users (show)
bhearsum: needs‑treeclosure+
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---


Description Nick Thomas [:nthomas] 2010-09-09 16:57:24 PDT
A couple of linux64 slaves timed out cloning the try repo 
  command timed out: 3600 seconds without output, killing pid 2734
  program finished with exit code -1
but the step was green so the job continued (failing at the very start of compile).

Jobs refs: 
Linux x86-64 tryserver build #2793
Linux x86-64 tryserver leak test #2763

Suspected regression from bug 505512.
Comment 1 Ben Hearsum (:bhearsum) 2010-09-10 05:29:05 PDT
I'll have a look.
Comment 2 Ben Hearsum (:bhearsum) 2010-09-10 07:34:50 PDT
So, the upstream code doesn't check the return code of the command if log_eval_func is set -- this changed mid-development, which is probably why regex_log_evaluator isn't checking the return code. The following upstream changeset will fix us up:

Requires a Buildbot restart on tm*, pm01 and pm03.
Comment 3 John Ford [:jhford] CET/CEST Berlin Time 2010-09-10 09:19:46 PDT
(In reply to comment #2)
> Requires a Buildbot restart on tm*, pm01 and pm03.

Do we need to restart try master as well?
Comment 4 Ben Hearsum (:bhearsum) 2010-09-10 09:25:23 PDT
Yes, good catch!
Comment 5 Ben Hearsum (:bhearsum) 2010-09-13 13:49:48 PDT
Tested this fix in staging today, worked fine:

Failed to clone build tools, halted there, the step was white.
Comment 6 Nick Thomas [:nthomas] 2010-09-15 22:10:09 PDT
*** Bug 596709 has been marked as a duplicate of this bug. ***
Comment 7 Nick Thomas [:nthomas] 2010-09-19 10:57:06 PDT
It'd be great if we could have buildbot return 'version-rev' for 'buildbot --version', where rev is the revision of the code in our buildbot repo. I think that should be as easy as modifying master/buildbot/ after landing any changes.
Comment 8 Ben Hearsum (:bhearsum) 2010-09-28 13:46:03 PDT
*** Bug 600337 has been marked as a duplicate of this bug. ***
Comment 9 Ben Hearsum (:bhearsum) 2010-10-04 07:41:30 PDT
This landed.

Note You need to log in before you can comment on or make changes to this bug.