595087 - Android splash screen does not dismiss when accelerated layers is enabled

Status: RESOLVED DUPLICATE of bug 605063

(Core Graveyard :: Widget: Android, defect)

Description

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch

This patch implements nsSplashScreen for android and sends the progress events over the android java bridge.

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch

Comment 2

[Michael Wu [:mwu]]

What patches do I need to apply this one?

Comment 3

[Brad Lassey [:blassey] (use needinfo?)]

I have it applied over the patch on bug 594553

Comment 4

[Michael Wu [:mwu]]

Comment on attachment 473971 [details] [diff] [review]
patch

I don't see a splashscreen with this patch.

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 473971 [details] [diff] [review]
patch

do you have --enable-splashscreen in your mozconfig?

Comment 6

[Michael Wu [:mwu]]

(In reply to comment #5)
> Comment on attachment 473971 [details] [diff] [review]
> patch
> 
> do you have --enable-splashscreen in your mozconfig?

Turned it on and it crashed. Cleaned the embedding/android directory and then it started working. Will have to look into that at some point.

Comment 7

[Brad Lassey [:blassey] (use needinfo?)]

Probably need to add a dependency on autoconf.mk for our preprocessed files

Comment 8

[Michael Wu [:mwu]]

Comment on attachment 473971 [details] [diff] [review]
patch

This does feel faster. It seems to feel faster regardless of whether we update the progress bar or not. Wonder what's going on.

Comment 9

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: updated to trunk, but broken

--enable-splashscreen/--disable-splashscreen don't seem to reliably enable/disable the progress meter.  With both, non-GL fennec starts fine, but also with both, I never see anything drawn with GL.  This is on a galaxy s.

Comment 10

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

(Note: I deleted $objdir/embedding/android in between changing --*-splashscreen.)

Comment 11

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

With --disable-splashscreen removed from my mozconfig, I don't get the splash screen; SW layers draw just fine; GL layers don't ever draw to screen.

Comment 12

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

This doesn't need to block b2 anymore since GL compositing has been pushed back to b3.

Comment 13

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

There's a r+'d patch for this in bug 6050632; will land that soon.