Closed Bug 595168 Opened 14 years ago Closed 14 years ago

[OS X] Some Flash content does not play with CS5-installed Flash 10.1.52.15 and 10.1.52.14

Categories

(External Software Affecting Firefox Graveyard :: Flash (Adobe), defect)

Product:
External Software Affecting Firefox Graveyard
Component:
Flash (Adobe)
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking2.0 final+)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
blocking2.0 --- final+

People

(Reporter: st3fan, Unassigned)

References

Details

(Keywords: regression)

Attachments

(1 file)

Debug Log file
23.03 KB, text/plain
Details 
Symptoms: Flash content does not play on my iMac 27". For example when going to youtube I do get audio but the player stays black.

Note: It looks like the time base of the flash player is messed up. When I move around or random click in the browser I see the flash app progress frame by frame.

Note: This iMac has a ATI Radeon HD 4850.

This happens with 4.0b5 and also with the nightly of Sep/10 on a recent
27" iMac with OS X 10.6.4. Those same builds do correctly display youtube
videos (or other flash content) on my MacBook Pro with 10.6.4 though.

I have started Firefox with an empty profile to be sure this is not happening
because of an extension.
Stefan, does it work with earlier 4.0 betas?  With 3.6?
(In reply to comment #1)
> Stefan, does it work with earlier 4.0 betas?  With 3.6?

In 3.6.9 all is fine. I've tried all 4.0 betas going to back b1 and the same thing happens.

I just discovered that it very much depends on the site:

 - playing (flash) videos from vimeo.com works well http://vimeo.com/14434107
 - playing videos from youtube.com fails http://www.youtube.com/watch?v=J---aiyznGQ
 - playing videos from video.google.com fails http://video.google.com/videoplay?docid=3897010229726822034

I've looked in the source to make sure these are flash videos and not HTML5 <video> ones.

It really looks like the plugin does not get enough time. When i click in the browser, or hit random keys, i see the video step forward. Maybe an event scheduling thing?
Oh forgot to mention: every time when the video fails, the audio is fine.
Stefan, would you be willing to try nightlies to find the day when the problem started?
Sure. I will do a binary search on the nightlies to find the breaking point. Can you recommend a date period that I should try?
Firefox 3.6 branched off of trunk on August 13, 2009.  So presumably a trunk nightly from then would not show the bug.  And a trunk nightly from around beta1 would, right?
Found it. This broke between

 2010-04-20-03-mozilla-central (works)

and

 2010-04-21-03-mozilla-central (fails)
Stefan, what are the changeset ids (the HTTP urls from about:buildconfig) for those two builds?
(In reply to comment #8)
> Stefan, what are the changeset ids (the HTTP urls from about:buildconfig) for
> those two builds?

You can actually get them from the build info .txt files alongside the builds.

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=5f229488969c&tochange=cdc8bf25220e

Bug 555281?  Bug 555290's also in there, and there may be other culprits in bugs I don't recognize, but CA sounds like the place to start.

Stefan, what Flash version do you have?  Is it the same on both Macs?
Component: Graphics → Plug-ins
Keywords: regression
QA Contact: thebes → plugins
Yeah, CoreAnimation seems pretty likely.
Blocks: 555281
blocking2.0: --- → ?
On the iMac (that fails):

    File: Flash Player.plugin
    Version: 10.1.52.15
    Shockwave Flash 10.1 r52

On the MacBook Pro (that works):

    File: Flash Player.plugin
    Version: 10.0.45
    Shockwave Flash 10.0 r45

Oh! So Flash 10.1 also introduced the hardware accelerated playback. Could that have something to do with it?
It does look like a problem with CoreAnimation. Make sure to try it with Flash 10.1.81.24 just in case. I'll investigate if I can find any known problems with your graphics card and CoreAnimation.
BenWa, is there something that we can do here for Firefox 4? Or should this be closed out as a flash bug? Blocking on getting resolution to that.
Assignee: nobody → b56girard
blocking2.0: ? → betaN+
A new version of Flash just came out from Adobe -- 10.1r85.  Make sure to also try that.
(In reply to comment #13)
> BenWa, is there something that we can do here for Firefox 4? Or should this be
> closed out as a flash bug? Blocking on getting resolution to that.

I doubt at this point that this is a Flash bug.

(In reply to comment #0)

> Note: It looks like the time base of the flash player is messed up. When I move
> around or random click in the browser I see the flash app progress frame by
> frame.

Does this always happens? Try resizing the window slowly and continuously, every time the dimensions change the frame should play giving a roughly smooth playback. If this is the case then it is likely that refresh is not working. This would point to CoreAnimation drawing model being negotiated instead of InvalidatingCoreAnimation drawing model that supports the expected refresh behavior.

Please let me know if that is the case or not. If not I'll provide you with a custom debug tryserver build that will give us proper diagnostics.
Benoit, resizing the window slowly does indeed result it roughly smooth playback. 

This is on 4.0b6 on OS X 10.6.5 with Flash 10.1.52.15.
Here's a custom debug build. I added some extra output to know what rendering model is being used:

http://stage.mozilla.org/pub/mozilla.org/firefox/tryserver-builds/b56girard@gmail.com-ba1d1972e12d/tryserver-macosx-debug/firefox-4.0b7pre.en-US.mac.dmg

If you could extract it, run it from command line, reproduce the issue and attach the log.
Attached file Debug Log file — 
Here is the log for your debug build. I started firefox-bin, created a new profile, went to youtube.com and then opened a movie there.
Thanks. The correct InvalidatingCoreAnimation rendering model is being negotiated as expected. We expected the plugin to notify the browser when the image is changing but we're not seeing any invalidation calls.

This could be a flash bug but I'm not entirely sure at this point.
OS: Mac OS X → Windows 7
OS: Windows 7 → Mac OS X
Well I was tired of firing up Safari or 3.6 every time I wanted to watch a video so I have actually gone to adobe.com to download the most recent Flash plugin. 

What i have installed now is version 10.1.85.3

Videos now play fine in all browsers I have on this iMac: Safari, FF 3.6 and FF 4.0.
Great, your older flash version was likely just not behaving the way we expected. Feel free to reopen the bug if you get this issue again with the latest flash version.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → INVALID
Personally I am fine with this, but I am worried that this will result in a lot of questions from users who will upgrade to 4.0. Specially since things worked fine on 3.6.x with the same Flash plugin.

Maybe Mozilla also needs to rethink the Flash strategy on OS X now that Apple is not shipping with Flash pre-installed anymore.
(In reply to comment #22)
> Personally I am fine with this, but I am worried that this will result in a lot
> of questions from users who will upgrade to 4.0. Specially since things worked
> fine on 3.6.x with the same Flash plugin.

At the very least it will require that we blocklist that version of Flash, yes. Do we know if it's only that one version, or if it's all 10.1 versions that aren't the most recent?

> Maybe Mozilla also needs to rethink the Flash strategy on OS X now that Apple
> is not shipping with Flash pre-installed anymore.

This is irrelevant for this bug as it has nothing to do with our "Flash strategy." No need to make mountains out of molehills. Something's broken between at least that one version of Flash and Firefox 4, and we should document and understand:

 - what that is,
 - what we're going to do about it (blocklist the version or fix the underlying issue)
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
Summary: Flash content does not play → [OS X] Flash content does not play with Flash 10.1.52.15 (others?)
>At the very least it will require that we blocklist that version of Flash, yes.
>Do we know if it's only that one version, or if it's all 10.1 versions that
aren't the most recent?

Do we keep an archive of Flash installers? I can walk through those and find out which ones cause problems on this specific hardware.
> Do we keep an archive of Flash installers? I can walk through those and find
> out which ones cause problems on this specific hardware.

We don't, but Adobe does: http://kb2.adobe.com/cps/142/tn_14266.html

What makes you think it's hardware dependent?
I know that a few older versions of 10.1 negotiate the Cocoa input model but do not support it correctly, this was fixed after the rendering refresh was fixed. So if we go through past version we should make sure key input is also working.

If we do go with blacklisting versions then we will likely have to blacklist not just this version but most (all?) the 10.1 version prior to 10.1r85. If we allow any version prior to 10.1r85 then we should test each manually.
Note that even Flash 10.1r85 (the current version) has a bug that's a potential show-stopper -- IME input is broken in it on the trunk.  See bug 587667.

According to bug 587667 comment #6, Adobe has an internal fix, which should (presumably) appear in a future release.
(In reply to comment #27)
> Note that even Flash 10.1r85 (the current version) has a bug that's a potential
> show-stopper -- IME input is broken in it on the trunk.  See bug 587667.

Flashback to 2008, le sigh.

On this bug's issue, though. Is there a fix we can/should make on our side to resolve this, or is the resolution to blacklist the versions of Flash?
The fix we could make would be to force a 60FPS on our side to force refresh which has unacceptable performance.

The more reasonable solution is to tell Flash that we don't support Cocoa/CoreAnimation for the specific versions where their implementation does not work with our implementation. This solution does not work for 64-bit & OOPP and isn't a trivial change.
Mitigating factor note - Apple has apparently stopped shipping Flash on Mac OS X which means anybody with a new Mac won't run into this bug since they'll have to download the latest Flash from Adobe.
Assignee: b56girard → joshmoz
(In reply to comment #30)
> Mitigating factor note - Apple has apparently stopped shipping Flash on Mac OS
> X which means anybody with a new Mac won't run into this bug since they'll have
> to download the latest Flash from Adobe.

I expect that many Firefox 4 users will be people who already have Macs; we need moar mitigation ;)
I don't remember seeing a bug like this in any official release of Flash. Here is a statement from Adobe on the availability of Flash 10.1:

"The first public release of Flash Player 10.1 is version 10.1.53.64. Flash Player version 10.1.52.14.1 and 10.1.52.15 were included with initial release of Adobe Creative Suite® 5 and Flash Professional CS5."

The reporter was running a version of Flash that was only released with Adobe Creative Suite and never generally available as a web release.

I installed every generally available version of Flash (10.1.53.64, 10.1.82.76, 10.1.85.3) and checked the videos the reporter cited as not working. All of the videos work with the latest Firefox 4 nightly build and every generally available version of Flash.
blocking2.0: betaN+ → final+
Summary: [OS X] Flash content does not play with Flash 10.1.52.15 (others?) → [OS X] Some Flash content does not play with CS5-installed Flash 10.1.52.15 and 10.1.52.14
Given the information in comment 32 I would be fine with blocking Flash 10.1.52.15 and 10.1.52.14 in Firefox 4. This is a small enough subset of users, and probably a more advanced subset of users, that I don't want to try to backport an ugly fix like the 60-fps timer (if that would even work).
Depends on: 608697
I filed bug 608697 about blocklisting Flash 10.1.52.15 and 10.1.52.14 in Firefox 4 for Mac OS X. That bug is marked blocking2.0final+ and the Flash bug has been resolved in released version of Flash so I'm changing this to a Flash bug and marking it fixed.
Assignee: joshmoz → nobody
Component: Plug-ins → Flash (Adobe)
Product: Core → Plugins
QA Contact: plugins → adobe-flash
Version: unspecified → 10.x
Status: REOPENED → RESOLVED
Closed: 14 years ago → 14 years ago
Resolution: --- → FIXED
(In reply to comment #32)

> The reporter was running a version of Flash that was only released with Adobe
> Creative Suite and never generally available as a web release.

Indeed, I did install a trial of Adobe CS5 at one point. Wow I had no idea that had also installed an unofficial Flash version.

Note that everything did work fine in Firefox 3.6 and Safari. So whatever this Flash bug is, it is only triggered in Firefox 4.0. Not sure if that is relevant anymore.
Version and milestone values are being reset to defaults as part of product refactoring.
Version: 10.x → unspecified
Product: External Software Affecting Firefox → External Software Affecting Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: