595339 - Strip out HTML from API URLs with version < 1.5

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: API, defect, P2)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

See bug bug 571547, especially https://bugzilla.mozilla.org/show_bug.cgi?id=571547#c15, for history.

We should strip out HTML from API queries such as https://preview.addons.mozilla.org/en-US/firefox/api/1.3/search/firefoxcup.

These show up in the Add-ons Manager: https://bugzilla.mozilla.org/attachment.cgi?id=450698

Comment 1

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

Which fields need this?

Description?
Summary?

anything else?

Comment 2

[Dave Townsend [:mossop]]

We use the following text fields from the API in 3.6: name, summary, description, eula. I don't know which of those can contain HTML but if they can then they should be stripped.

Comment 3

[Justin Scott [:fligtar]]

Everything except name should be stripped, as I think we auto-link in EULAs now too (or will eventually)

Comment 4

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

http://github.com/jbalogh/zamboni/commit/8f23b4d

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

https://preview.addons.mozilla.org/en-US/firefox/api/1.3/search/spamfire still has, in its <description>, the following:

"For more information on how this works <a href = "http://www.youtube.com/watch?v=g6J89CAH8es">Watch our aweome video</a>"

Comment 6

[Wil Clouser [:clouserw]]

Yeah, that's weird.  I checked this out and it looks like that URL is half remora and half zamboni.  I filed bug 603673 to figure that out, but the zamboni ones are working correctly, so reclosing this.

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://preview.addons.mozilla.org/en-US/firefox/api/1.3/search/spamfire.

Comment 8

[Jeff Balogh (:jbalogh)]

http://jinja.pocoo.org/templates/#striptags

Comment 9

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

F, that's okay - I bet they don't have a "Just Kidding" option.