The default bug view has changed. See this FAQ.

Need support for customizing toolbars which are outside of the toolbox

RESOLVED FIXED in mozilla2.0b7

Status

()

Toolkit
Toolbars and Toolbar Customization
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: mano, Assigned: mano)

Tracking

({dev-doc-complete})

unspecified
mozilla2.0b7
dev-doc-complete
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(blocking2.0 beta7+)

Details

Attachments

(2 attachments)

Created attachment 474756 [details] [diff] [review]
patch

For the addon bar (see bug 574688) we need support for customizing toolbars which are outside of the DOM toolbox. An "external toolbar" would be a toolbar that its parent is *not* a toolbox, and on which a "toolboxid" attribute is set.
Attachment #474756 - Flags: review?(enndeakin)
Summary: Need support for customizng toolbars which are unside of the toolbox → Need support for customizing toolbars which are outside of the toolbox

Updated

7 years ago
Blocks: 590543
blocks landing of status bar removal, so blocks beta 6.
blocking2.0: --- → beta6+

Comment 2

7 years ago
Comment on attachment 474756 [details] [diff] [review]
patch

> function unwrapToolbarItems()
> {
>-  var paletteItems = gToolbox.getElementsByTagName("toolbarpaletteitem");
>-  var paletteItem;

You want to leave the declaration of paletteItem in.
Attachment #474756 - Flags: review?(enndeakin) → review+
Comment on attachment 474756 [details] [diff] [review]
patch

This is needed for the new addon-bar.
Attachment #474756 - Flags: approval2.0?
Keywords: checkin-needed
Comment on attachment 474756 [details] [diff] [review]
patch

I haven't noticed that beta6+ was set.
Attachment #474756 - Flags: approval2.0?
http://hg.mozilla.org/mozilla-central/rev/17d4ccd186bd
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b6

Comment 6

7 years ago
in removeToolboxListeners()it should be removeEventListener..
Created attachment 474937 [details] [diff] [review]
for immediate checkin....

Thanks!
Attachment #474756 - Attachment is obsolete: true
Status: RESOLVED → REOPENED
Keywords: checkin-needed
Resolution: FIXED → ---

Updated

7 years ago
Keywords: dev-doc-needed

Updated

7 years ago
Duplicate of this bug: 590543
pushed the followup: http://hg.mozilla.org/mozilla-central/rev/e523182f9639
Status: REOPENED → RESOLVED
Last Resolved: 7 years ago7 years ago
Resolution: --- → FIXED

Updated

7 years ago
Keywords: checkin-needed

Updated

7 years ago
Attachment #474756 - Attachment is obsolete: false
Duplicate of this bug: 579506

Updated

7 years ago
Depends on: 612588
Documentation updated:

https://developer.mozilla.org/en/XUL/toolbar
https://developer.mozilla.org/en/XUL/toolbox

New pages:

https://developer.mozilla.org/en/XUL/Property/externalToolbars
https://developer.mozilla.org/en/XUL/Property/toolboxid

Also referenced here:

https://developer.mozilla.org/en/Firefox_4_for_developers#Miscellaneous_XUL_changes
Keywords: dev-doc-needed → dev-doc-complete

Updated

6 years ago
Depends on: 652842
You need to log in before you can comment on or make changes to this bug.