595937 - Need support for customizing toolbars which are outside of the toolbox

Status: RESOLVED FIXED

(Toolkit :: Toolbars and Toolbar Customization, defect)

Description

[Asaf Romano (gone)]

Attachment: patch

For the addon bar (see bug 574688) we need support for customizing toolbars which are outside of the DOM toolbox. An "external toolbar" would be a toolbar that its parent is *not* a toolbox, and on which a "toolboxid" attribute is set.

Comment 1

[Dietrich Ayala (:dietrich)]

blocks landing of status bar removal, so blocks beta 6.

Comment 2

[Neil Deakin]

Comment on attachment 474756 [details] [diff] [review]
patch

> function unwrapToolbarItems()
> {
>-  var paletteItems = gToolbox.getElementsByTagName("toolbarpaletteitem");
>-  var paletteItem;

You want to leave the declaration of paletteItem in.

Comment 3

[Asaf Romano (gone)]

Comment on attachment 474756 [details] [diff] [review]
patch

This is needed for the new addon-bar.

Comment 4

[Asaf Romano (gone)]

Comment on attachment 474756 [details] [diff] [review]
patch

I haven't noticed that beta6+ was set.

Comment 5

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/17d4ccd186bd

Comment 6

[alta88]

in removeToolboxListeners()it should be removeEventListener..

Comment 7

[Asaf Romano (gone)]

Attachment: for immediate checkin....

Thanks!

Comment 9

[Dietrich Ayala (:dietrich)]

pushed the followup: http://hg.mozilla.org/mozilla-central/rev/e523182f9639

Comment 11

[Eric Shepherd [:sheppy]]

Documentation updated:

https://developer.mozilla.org/en/XUL/toolbar
https://developer.mozilla.org/en/XUL/toolbox

New pages:

https://developer.mozilla.org/en/XUL/Property/externalToolbars
https://developer.mozilla.org/en/XUL/Property/toolboxid

Also referenced here:

https://developer.mozilla.org/en/Firefox_4_for_developers#Miscellaneous_XUL_changes