Closed Bug 595937 Opened 9 years ago Closed 9 years ago

Need support for customizing toolbars which are outside of the toolbox

Categories

(Toolkit :: Toolbars and Toolbar Customization, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla2.0b7
Tracking Status
blocking2.0 --- beta7+

People

(Reporter: mano, Assigned: mano)

References

Details

(Keywords: dev-doc-complete)

Attachments

(2 files)

Attached patch patchSplinter Review
For the addon bar (see bug 574688) we need support for customizing toolbars which are outside of the DOM toolbox. An "external toolbar" would be a toolbar that its parent is *not* a toolbox, and on which a "toolboxid" attribute is set.
Attachment #474756 - Flags: review?(enndeakin)
Summary: Need support for customizng toolbars which are unside of the toolbox → Need support for customizing toolbars which are outside of the toolbox
Blocks: 590543
blocks landing of status bar removal, so blocks beta 6.
blocking2.0: --- → beta6+
Comment on attachment 474756 [details] [diff] [review]
patch

> function unwrapToolbarItems()
> {
>-  var paletteItems = gToolbox.getElementsByTagName("toolbarpaletteitem");
>-  var paletteItem;

You want to leave the declaration of paletteItem in.
Attachment #474756 - Flags: review?(enndeakin) → review+
Comment on attachment 474756 [details] [diff] [review]
patch

This is needed for the new addon-bar.
Attachment #474756 - Flags: approval2.0?
Comment on attachment 474756 [details] [diff] [review]
patch

I haven't noticed that beta6+ was set.
Attachment #474756 - Flags: approval2.0?
http://hg.mozilla.org/mozilla-central/rev/17d4ccd186bd
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b6
in removeToolboxListeners()it should be removeEventListener..
Status: RESOLVED → REOPENED
Keywords: checkin-needed
Resolution: FIXED → ---
Keywords: dev-doc-needed
Duplicate of this bug: 590543
pushed the followup: http://hg.mozilla.org/mozilla-central/rev/e523182f9639
Status: REOPENED → RESOLVED
Closed: 9 years ago9 years ago
Resolution: --- → FIXED
Attachment #474756 - Attachment is obsolete: false
Duplicate of this bug: 579506
Depends on: 612588
Depends on: 652842
You need to log in before you can comment on or make changes to this bug.