597601 - Clicking in the empty space in a group should not take you into a tab

Status: VERIFIED FIXED

(Firefox Graveyard :: Panorama, defect, P2)

Description

[Ian Gilman [:iangilman]]

Aza has come to the conclusion that we should disable the "clicking anywhere in a group takes you into the last tab you used" feature.

Comment 1

[Aza Raskin [:aza]]

It is a true story.

In particular, now that we have smaller targets and I've had a chance to use it, I've found that I accidentally click the background enough that it is a frustrating behavior.

Comment 2

[Raymond Lee [:raymondlee]]

Attachment: v1

Also, removed a test (bug 587040) which interacts with the group empty space.

Ian: we are removing a feature, do we still need a test for this?

Comment 3

[Ian Gilman [:iangilman]]

Comment on attachment 477447 [details] [diff] [review]
v1

Looks good. I'll leave it to Dietrich whether we need a test.

Comment 4

[Ian Gilman [:iangilman]]

Comment on attachment 477447 [details] [diff] [review]
v1

Reassigning review to dolske while dietrich is jammed up with b7 stuff.

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 477447 [details] [diff] [review]
v1

a=beltzner, with a feeling of conflict

I still think the cost of switching between groups ends up being pretty high here. If I'm flipping between A and B, it's harder to hit the tab that I was on with this change. We should make sure the "last selected tab in the group" is clearly indicated graphically.

Comment 6

[Raymond Lee [:raymondlee]]

Attachment: Patch for check-in

Comment 7

[Raymond Lee [:raymondlee]]

(In reply to comment #5)
> Comment on attachment 477447 [details] [diff] [review]
> v1
> 
> a=beltzner, with a feeling of conflict
> 
> I still think the cost of switching between groups ends up being pretty high
> here. If I'm flipping between A and B, it's harder to hit the tab that I was on
> with this change. We should make sure the "last selected tab in the group" is
> clearly indicated graphically.

Filed a followup bug 603237

Comment 8

[Ian Gilman [:iangilman]]

http://hg.mozilla.org/mozilla-central/rev/6c6c129302fc

Comment 9

[Tracy Walker [:tracy]]

verified with nightly minefield builds of 20101021