Closed Bug 597601 Opened 9 years ago Closed 9 years ago

Clicking in the empty space in a group should not take you into a tab

Categories

(Firefox Graveyard :: Panorama, defect, P2)

defect

Tracking

(Not tracked)

VERIFIED FIXED
Firefox 4.0

People

(Reporter: iangilman, Assigned: raymondlee)

References

Details

(Whiteboard: [b8][interaction][good first bug])

Attachments

(1 file, 1 obsolete file)

Aza has come to the conclusion that we should disable the "clicking anywhere in a group takes you into the last tab you used" feature.
It is a true story.

In particular, now that we have smaller targets and I've had a chance to use it, I've found that I accidentally click the background enough that it is a frustrating behavior.
Whiteboard: [b8][interaction]
Target Milestone: --- → Firefox 4.0
Whiteboard: [b8][interaction] → [b8][interaction][good first bug]
Blocks: 597043
Assignee: ian → raymond
Status: NEW → ASSIGNED
Attached patch v1 (obsolete) — Splinter Review
Also, removed a test (bug 587040) which interacts with the group empty space.

Ian: we are removing a feature, do we still need a test for this?
Attachment #477447 - Flags: feedback?(ian)
Comment on attachment 477447 [details] [diff] [review]
v1

Looks good. I'll leave it to Dietrich whether we need a test.
Attachment #477447 - Flags: review?(dietrich)
Attachment #477447 - Flags: feedback?(ian)
Attachment #477447 - Flags: feedback+
Comment on attachment 477447 [details] [diff] [review]
v1

Reassigning review to dolske while dietrich is jammed up with b7 stuff.
Attachment #477447 - Flags: review?(dietrich) → review?(dolske)
Attachment #477447 - Flags: review?(dolske) → review+
Attachment #477447 - Flags: approval2.0?
Comment on attachment 477447 [details] [diff] [review]
v1

a=beltzner, with a feeling of conflict

I still think the cost of switching between groups ends up being pretty high here. If I'm flipping between A and B, it's harder to hit the tab that I was on with this change. We should make sure the "last selected tab in the group" is clearly indicated graphically.
Attachment #477447 - Flags: approval2.0? → approval2.0+
Blocks: 603237
Attachment #477447 - Attachment is obsolete: true
(In reply to comment #5)
> Comment on attachment 477447 [details] [diff] [review]
> v1
> 
> a=beltzner, with a feeling of conflict
> 
> I still think the cost of switching between groups ends up being pretty high
> here. If I'm flipping between A and B, it's harder to hit the tab that I was on
> with this change. We should make sure the "last selected tab in the group" is
> clearly indicated graphically.

Filed a followup bug 603237
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/6c6c129302fc
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
verified with nightly minefield builds of 20101021
Status: RESOLVED → VERIFIED
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.