597792 - Use the placeholder attribute of <input> instead of hacks to set a default name for tab groups

Status: RESOLVED DUPLICATE of bug 619440

(Firefox Graveyard :: Panorama, defect, P4)

Description

[Frank Yan (:fryn)]

Hacks are suboptimal. HTML5 is better.

We should be using something like
<input placeholder="&tabview.groupItem.defaultName;" />
to set the default name of tab groups.

See instances of defaultName in
http://mxr.mozilla.org/mozilla-central/source/browser/base/content/tabview/groupitems.js

Comment 1

[Aza Raskin [:aza]]

Frank, do you want to take care of this?

Comment 2

[Sean Dunn]

(In reply to comment #1)
> Frank, do you want to take care of this?

The fix for bug 589132 would make this moot, since the placeholder string is now stored in a DIV label. The INPUT is only shown when it's focused.

Comment 3

[Frank Yan (:fryn)]

(In reply to comment #2)
> The fix for bug 589132 would make this moot, since the placeholder string is
> now stored in a DIV label. The INPUT is only shown when it's focused.

Why do we need the DIV label in the first place?

Comment 4

[Aza Raskin [:aza]]

So this sounds like a invalid!

Comment 5

[Frank Yan (:fryn)]

Oh, I see. Using a DIV like that to crop the title seems rather hacky, imho.
Unfortunately, we don't support CSS text-overflow: ellipsis.
I wonder if <input> can use text-overflow.
I don't feel that strongly about this, so I'm okay with the INVALID resolution.

Comment 6

[Tracy Walker [:tracy]]

marking invalid per latest comments.