619440 - Group item title field should use HTML5 placeholder

Status: VERIFIED FIXED

(Firefox Graveyard :: Panorama, enhancement, P4)

Description

[Michael Yoshitaka Erlewine [:mitcho]]

Right now we have some special case code in order to display the "Name this tab group..." text and icon on unnamed groups. I believe all of this JS is unnecessary and it would all be cleaner if we used a placeholder attribute on the title input field and then styled it with :-moz-placeholder .

This most likely would require a litmus test as I'm not sure how an automated test for this would be written.

Comment 1

[Michael Yoshitaka Erlewine [:mitcho]]

Attachment: Video of patch v1

Looks like this means we would have to get rid of the behavior whereby the pencil icon stays when you enter a name for the first time, and gracefully disappears later... but I think making this all CSS is enough benefit. Aza, thoughts?

Comment 2

[Michael Yoshitaka Erlewine [:mitcho]]

Attachment: Patch v1

Quick first patch... note all the JS we can get rid of!

Note: this patch only includes necessary CSS changes for Mac, not yet other themes.

Comment 3

[Ian Gilman [:iangilman]]

Comment on attachment 497870 [details] [diff] [review]
Patch v1

Looks great!

Comment 4

[Ian Gilman [:iangilman]]

Comment on attachment 497870 [details] [diff] [review]
Patch v1

>-  -moz-margin-begin: 3px;
>+  -moz-margin-start: 3px;

Thanks for catching this, by the way! While you're in here, please fix the other one (title-shield)... for some reason it's only in the Mac theme.

Comment 5

[Michael Yoshitaka Erlewine [:mitcho]]

Attachment: Patch v1.1

- Applied the same treatment to winstripe and gnomestripe.
- Took care of that one last -moz-margin-begin

Comment 6

[Ian Gilman [:iangilman]]

Comment on attachment 499533 [details] [diff] [review]
Patch v1.1

Lovely

Comment 7

[Dão Gottwald [:dao]]

Comment on attachment 499533 [details] [diff] [review]
Patch v1.1

>-.title-container:hover input.name {
>+.title-container:hover input.name, .title-container input.name:focus {

Break the line after the comma.

Comment 8

[Michael Yoshitaka Erlewine [:mitcho]]

Attachment: Patch v1.2

Thanks Dāo. Fixed.

Comment 9

[Michael Yoshitaka Erlewine [:mitcho]]

Pushed patch v1.2 to try today. Passed.

Comment 10

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 501073 [details] [diff] [review]
Patch v1.2

a=beltzner

Comment 11

[Michael Yoshitaka Erlewine [:mitcho]]

Attachment: Patch for checkin

Pushed to try as well, just to be safe.

Comment 12

[Michael Yoshitaka Erlewine [:mitcho]]

Passed try.

Comment 13

[Ian Gilman [:iangilman]]

http://hg.mozilla.org/mozilla-central/rev/f9537a28ce19

Comment 14

[Tracy Walker [:tracy]]

verified with minefield build of 20110217