598360 - [SeaMonkey] mochitest-5: failing test_notifications.html and test_prompt.html due to doorhangers

Status: VERIFIED FIXED

(Toolkit :: Password Manager, defect)

Description

[Justin Wood (:Callek)]

Attachment: Change the helper functions

SeaMonkey is failing with:

s: cb-seamonkey-linux-01
5853 ERROR TEST-UNEXPECTED-FAIL | /tests/toolkit/components/passwordmgr/test/test_notifications.html | Got popupNotifications
5860 ERROR TEST-UNEXPECTED-FAIL | /tests/toolkit/components/passwordmgr/test/test_notifications.html | [SimpleTest/SimpleTest.js, window.onerror] An error occurred - aPopupNote is undefined at http://mochi.test:8888/tests/toolkit/components/passwordmgr/test/notification_common.js:23
5871 ERROR TEST-UNEXPECTED-FAIL | /tests/toolkit/components/passwordmgr/test/test_prompt.html | Got popupNotifications
6122 ERROR TEST-UNEXPECTED-FAIL | /tests/toolkit/components/passwordmgr/test/test_prompt.html | [SimpleTest/SimpleTest.js, window.onerror] An error occurred - aPopupNote is undefined at http://mochi.test:8888/tests/toolkit/components/passwordmgr/test/notification_common.js:23


Password manager tests depend on doorhanger and not all applications have that

This patch has passed Firefox-Try and I intend to test locally tonight.

Comment 1

[Justin Dolske [:Dolske]]

Comment on attachment 477169 [details] [diff] [review]
Change the helper functions

I think it would be simplest to just disable this test on Seamonkey, since you guys are implementing doorhangers anyway.

I intend to remove the notification bar support from login manager at some point anyway (it's silly to support 3 prompting methods), so there's no advantage to making the tests work both ways.

Comment 2

[Justin Wood (:Callek)]

Attachment: v2

I didn't find this a good choice, but its not necessarily a bad choice. I decided it wasn't worth trying to pick out the dependant files and just remove the main test files. While here I figured it easiest to kill off the privatebrowsing one as well, even though it doesn't fail on SeaMonkey

Comment 3

[Justin Wood (:Callek)]

Attachment: v2.1

better still, change autoconf.mk to config.mk (which does pull in autoconf) This way we also get the clearer MOZ_SUITE from app-config.mk

Comment 4

[Justin Wood (:Callek)]

Comment on attachment 478997 [details] [diff] [review]
v2.1

...and this actually is more build-config that passwordmanager at this point, so additional-review-requesting khuey

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Should these be ifeq ($(MOZ_BUILD_APP),browser)?  Do these tests make sense for Fennec?

Comment 6

[Justin Wood (:Callek)]

http://hg.mozilla.org/mozilla-central/rev/12c86c62af80

Comment 7

[Legacy TBPL/Treeherder Robot]

mitchell.field%live.com.au
http://tinderbox.mozilla.org/showlog.cgi?log=Build-System/1299089822.1299090477.15909.gz
Rev3 Fedora 12x64 build-system opt test mochitests-5/5 on 2011/03/02 10:17:02

s: talos-r3-fed64-054
5151 ERROR TEST-UNEXPECTED-FAIL | /tests/toolkit/components/passwordmgr/test/test_prompt.html | OBSERVER FAILED: No matching logins
5193 ERROR TEST-UNEXPECTED-FAIL | /tests/toolkit/components/passwordmgr/test/test_prompt.html | Test timed out.

Comment 8

[Serge Gautherie (:sgautherie)]

(In reply to Justin Wood (:Callek) from comment #6)
> http://hg.mozilla.org/mozilla-central/rev/12c86c62af80

+
http://hg.mozilla.org/mozilla-central/rev/db37d1272fbf
"use topsrcdir instead of DEPTH"

Comment 9

[Serge Gautherie (:sgautherie)]

(In reply to TinderboxPushlog Robot from comment #7)
> mitchell.field%live.com.au
> http://tinderbox.mozilla.org/showlog.cgi?log=Build-System/1299089822.
> 1299090477.15909.gz

Not SeaMonkey, Doesn't look like this bug...