635825 - [SeaMonkey] mochitest-5: reenable test_notifications.html and test_prompt.html

Status: VERIFIED FIXED

(Toolkit :: Password Manager, defect)

Description

[Serge Gautherie (:sgautherie)]

These 2 tests were disabled in bug 598360.
Bug 595810 should be fixing the 'doorhanger notfications' part.

Fwiw, check bug 479427.

Comment 1

[Justin Wood (:Callek)]

serge, if a run locally (or through tb-try with proper mozconfig/patch) passes with these tests enabled, rs+=me to re-enable them.

If not, please document (in here is fine) what needs to be done (or what _specific_ bugs, that also have clear items) need to be done to get these meaningfully enabled.

Failing a passing run, or explanation on what is relevant to get them enabled, I'll close this as INVALID in the interim.

Comment 2

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) Re-enable test_notifications.html, test_privbrowsing.html and test_prompt.html on SeaMonkey [Checked in: Comments 2 and 5]

[Mozilla/5.0 (Windows NT 5.0; rv:13.0a1) Gecko/20120201 Firefox/13.0a1 SeaMonkey/2.10a1] (nightly, 2012-02-01-00-30-09-comm-central-trunk)

These 3 tests succeed locally.

*****

https://hg.mozilla.org/mozilla-central/rev/0e840cf44d2d


[Approval Request Comment]
No risk, test-only.

Comment 3

[Serge Gautherie (:sgautherie)]

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1335969970.1335970783.14591.gz&fulltext=1
WINNT 5.2 comm-central-trunk debug test mochitests-5/5 on 2012/05/02 07:46:10
{
5389 INFO TEST-END | /tests/toolkit/components/passwordmgr/test/test_notifications.html | finished in 21560ms

5391 INFO TEST-PASS | /tests/toolkit/components/passwordmgr/test/test_privbrowsing.html | Private browsing service is not available

6411 INFO TEST-END | /tests/toolkit/components/passwordmgr/test/test_prompt.html | finished in 28350ms
}

V.Fixed

Comment 4

[Alex Keybl [:akeybl]]

Comment on attachment 620243 [details] [diff] [review]
(Av1) Re-enable test_notifications.html, test_privbrowsing.html and test_prompt.html on SeaMonkey
[Checked in: Comments 2 and 5]

[Triage Comment]
Test only change, approved for Aurora 14 and Beta 13.

Comment 5

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 620243 [details] [diff] [review]
(Av1) Re-enable test_notifications.html, test_privbrowsing.html and test_prompt.html on SeaMonkey
[Checked in: Comments 2 and 5]

http://hg.mozilla.org/releases/mozilla-aurora/rev/b0718c6f08a6
http://hg.mozilla.org/releases/mozilla-beta/rev/517b484c48e0

[Bitrot fixed upon checkin]

Comment 6

[Serge Gautherie (:sgautherie)]

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey-Aurora/1336356275.1336358595.28923.gz&fulltext=1
WINNT 5.2 comm-aurora debug test mochitests-5/5 on 2012/05/06 19:04:35

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey-Beta/1336350229.1336351277.22132.gz&fulltext=1
WINNT 5.2 comm-beta debug test mochitests-5/5 on 2012/05/06 17:23:49

seamonkey2.11 and seamonkey2.10: verified.