Last Comment Bug 598644 - Clean up SeaMonkey packaging files post libxul switch
: Clean up SeaMonkey packaging files post libxul switch
Status: RESOLVED FIXED
:
Product: SeaMonkey
Classification: Client Software
Component: Build Config (show other bugs)
: Trunk
: All All
: -- minor (vote)
: seamonkey2.1b1
Assigned To: Robert Kaiser
:
Mentors:
Depends on: 394502 599605
Blocks: 534689 SM-OOPP
  Show dependency treegraph
 
Reported: 2010-09-22 07:57 PDT by Mark Banner (:standard8)
Modified: 2010-09-27 14:40 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
adapt packaging for libxul world (12.33 KB, patch)
2010-09-22 13:25 PDT, Robert Kaiser
bugspam.Callek: review+
Details | Diff | Splinter Review
error out on packaging if we're not libxul (742 bytes, patch)
2010-09-22 16:20 PDT, Robert Kaiser
bugspam.Callek: review+
Details | Diff | Splinter Review

Description Mark Banner (:standard8) 2010-09-22 07:57:12 PDT
Bug 394502 switched to libxul. As a result there's lots of shared/static build addition and removals for each file to cleanup to get only what is needed for libxul builds.
Comment 1 Robert Kaiser 2010-09-22 10:32:15 PDT
From all I'm seeing, we're not missing any files we need to package, so this is minor. That said, we can remove all support for packaging anything else but the now-default "fatlibxul" builds.

Also, on removed-files, we can clean up enough to only support coming from any build that was actually released for 2.x including milestones as well as nightlies from the last week or so.
Comment 2 Robert Kaiser 2010-09-22 13:25:32 PDT
Created attachment 477631 [details] [diff] [review]
adapt packaging for libxul world

This patch adapts packaging for the new world where we only support libxul builds there. This is basically nothing else than removal of any shared libs from packaging, adding the new startup cache that now builds since we switched, and removing any support for other build variants from removed-files (i.e. make it remove anything from possibly previously shipped shared builds).

I *think* there might be further cleanup possible for removed-files but I don't want to dig into what files exactly we shipped in what release - at least, not at this moment.
Comment 3 Robert Kaiser 2010-09-22 13:26:34 PDT
Oh, what I meant to say wrt review, I'll take whoever of you will get to it first.
Comment 4 Justin Wood (:Callek) (Away until Aug 29) 2010-09-22 15:29:06 PDT
Comment on attachment 477631 [details] [diff] [review]
adapt packaging for libxul world

 I didn't line-by-line review this, but it looks good.

I'll double-check package-compare _after_ this lands.
Comment 5 Jens Hatlak (:InvisibleSmiley) 2010-09-22 15:55:13 PDT
I just built on Win7 (current MozillaBuild + pymake) with --disable-libxul --disable-ipc (and without the patch from this bug) after pymake failed without those (no time to investigate yet), and now have a build that compiled but doesn't start anymore due to a missing xpcom_core.dll (I'm building the installer ZIP and extracting it, so am deliberately subject to packaging issues). Is this bug about removing the ability to build with the above options, and was it ever supposed to work? I got the impression it should after reading Standard8's posting to m.d.a.seamonkey ("Landing libxul on comm-central").
Comment 6 Robert Kaiser 2010-09-22 16:14:54 PDT
Landed as http://hg.mozilla.org/comm-central/rev/3bffdd67505f

Jens, try clobbering and not using any of those two options. And yes, shared builds with that config are not much tested right now.
Comment 7 Robert Kaiser 2010-09-22 16:20:57 PDT
Created attachment 477757 [details] [diff] [review]
error out on packaging if we're not libxul

Actually, Jens's statement reminded me we also should port that little block that makes it clear that we only support libxul for packaging now.
Comment 8 Robert Kaiser 2010-09-22 18:05:18 PDT
Comment on attachment 477757 [details] [diff] [review]
error out on packaging if we're not libxul

Landed that followup as http://hg.mozilla.org/comm-central/rev/2caef1a38423
Comment 9 Jens Hatlak (:InvisibleSmiley) 2010-09-27 14:40:47 PDT
(In reply to comment #5)
> I just built on Win7 (current MozillaBuild + pymake) with --disable-libxul
> --disable-ipc (and without the patch from this bug) after pymake failed without
> those (no time to investigate yet)

Filed bug 600023 for that (sorry for the noise).

Note You need to log in before you can comment on or make changes to this bug.