Remove button styling for buttons added to Addon Bar

RESOLVED FIXED in Firefox 4.0b9

Status

()

Firefox
Theme
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: Paul [pwd], Assigned: dao)

Tracking

Trunk
Firefox 4.0b9
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [addon bar][target-betaN])

Attachments

(1 attachment, 3 obsolete attachments)

(Reporter)

Description

7 years ago
User-Agent:       Mozilla/5.0 (Windows NT 6.1; rv:2.0b7pre) Gecko/20100923 Firefox/4.0b7pre
Build Identifier: Mozilla/5.0 (Windows NT 6.1; rv:2.0b7pre) Gecko/20100923 Firefox/4.0b7pre

Buttons added to the Addon Bar currently receive the same styling as those added to the Navigation Bar when in fact the styling should be closer to that of buttons added to the Tab Bar.

Reproducible: Always
(Reporter)

Updated

7 years ago
Blocks: 574688
(Reporter)

Updated

7 years ago
Version: unspecified → Trunk
Well, then when I put all my widgets down there, what we really need to do this right is update the addon bar so its actually to be styled by the default theme.  

All those things on it to be the styled similarly.  Removing the buttons will just make it more statusbar like, weather its by glass or like the nav or bookmarks bar, themed or by lwtheme.
(Reporter)

Comment 2

7 years ago
The plan is to retain some button styling, just not the default navigation bar button styling as those buttons feel cumbersome. I'm sure the UX Team has some ideas on this, if not, I'll be sure to try and come up with a mockup.
(Reporter)

Comment 3

7 years ago
Created attachment 478239 [details]
Opera styling

Here is how Opera have styled their bottom bar. I propose we mimic the button style.
A mockup would be great, thanks Paul.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: uiwanted
(Reporter)

Comment 5

7 years ago
Created attachment 479351 [details]
Add-on Bar Button Styling Mockup

Apologies for the wait.

This shows the button in their three different states.
(Reporter)

Comment 6

7 years ago
Created attachment 483842 [details]
Add-on Bar Button Styling Tweaks

I tried to play with the userChrome to get it to look proper, but had problems getting the borders and backgrounds back when hovering over the button. That said, it also raised some user experience concerns in cases of buttons with drop downs. It just didn't look intuitive. Anyway, this is a compromise I came up with.
Whiteboard: [addon bar]
(Assignee)

Updated

7 years ago
Assignee: nobody → dao
Component: General → Theme
QA Contact: general → theme
(Assignee)

Updated

7 years ago
Depends on: 604531
(Assignee)

Comment 7

7 years ago
Created attachment 492321 [details] [diff] [review]
patch
Attachment #492321 - Flags: review?(dietrich)
(Reporter)

Comment 8

7 years ago
Can we avoid pushing this until we get UX feedback on bug 609559. As it might negate this work.
(Reporter)

Updated

7 years ago
Attachment #479351 - Attachment is obsolete: true
(Reporter)

Updated

7 years ago
Attachment #483842 - Attachment is obsolete: true
(Reporter)

Updated

7 years ago
Attachment #478239 - Attachment is obsolete: true
(Assignee)

Comment 9

7 years ago
(In reply to comment #8)
> Can we avoid pushing this until we get UX feedback on bug 609559.

No, I certainly don't want to wait for that bug. I don't think it would work for jetpack items anyway.
(Reporter)

Comment 10

7 years ago
(In reply to comment #9)
> (In reply to comment #8)
> > Can we avoid pushing this until we get UX feedback on bug 609559.
> 
> No, I certainly don't want to wait for that bug. I don't think it would work
> for jetpack items anyway.

Then post your argument against it in that bug so as that when the UX Team do review the idea, they're able to take your well grounded arguments into consideration.
Comment on attachment 492321 [details] [diff] [review]
patch

thanks! patch doesn't apply however, and also do you need to make linux changes?
(Assignee)

Comment 12

7 years ago
(In reply to comment #11)
> Comment on attachment 492321 [details] [diff] [review]
> patch
> 
> thanks! patch doesn't apply however, and also do you need to make linux
> changes?

It applies on top of bug 604531. Linux should be fine already.
Comment on attachment 492321 [details] [diff] [review]
patch

After testing the patch, and loading some add-ons into the bar, I think this needs a couple of pixels on the right margin. The buttons look a bit crunched together otherwise. r=me with that change.
Attachment #492321 - Flags: review?(dietrich) → review+
(Assignee)

Comment 14

7 years ago
(In reply to comment #13)
> Comment on attachment 492321 [details] [diff] [review]
> patch
> 
> After testing the patch, and loading some add-ons into the bar, I think this
> needs a couple of pixels on the right margin. The buttons look a bit crunched
> together otherwise. r=me with that change.

On Windows, Linux, OS X or all of them?
(Assignee)

Comment 15

7 years ago
(In reply to comment #14)
> (In reply to comment #13)
> > Comment on attachment 492321 [details] [diff] [review] [details]
> > patch
> > 
> > After testing the patch, and loading some add-ons into the bar, I think this
> > needs a couple of pixels on the right margin. The buttons look a bit crunched
> > together otherwise. r=me with that change.
> 
> On Windows, Linux, OS X or all of them?

ping?
This was on Linux. I didn't test the patch on Mac or Windows.
(Assignee)

Comment 17

7 years ago
Sounds like we should have a separate bug on that. I haven't touched Linux since it doesn't have the button styling that this bug refers to.
(Assignee)

Updated

7 years ago
Attachment #492321 - Flags: approval2.0?
(Assignee)

Updated

7 years ago
Blocks: 598921
Whiteboard: [addon bar] → [addon bar][target-betaN]
Attachment #492321 - Flags: approval2.0? → approval2.0+
(Assignee)

Comment 18

6 years ago
http://hg.mozilla.org/mozilla-central/rev/08c0399c5ff3
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Keywords: uiwanted
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b9
Depends on: 620059
Shouldn't the buttons have a hover effect? Not having one gives no tactile response that an icon is actually a button. IMHO this is especially important on the Windows theme, when there is little visual differentiation between a button's enabled and disabled states.
(Assignee)

Comment 20

6 years ago
(In reply to comment #19)
> Shouldn't the buttons have a hover effect?

If you're using a classic Windows theme, bug 589236 is the bug you should watch.
You need to log in before you can comment on or make changes to this bug.