600891 - Add privacy policy link to site footer on bugzilla.mozilla.org

Status: VERIFIED FIXED

(bugzilla.mozilla.org :: General, defect, P2)

Description

[Luis Villa [Outside Counsel; for non-law use [e-mail]]]

bmo should have links to the mozilla.org privacy policy in the footer and in the account creation text.

The appropriate policy is:
http://www.mozilla.org/about/policies/privacy-policy.html

Comment 1

[Reed Loden [:reed]]

Why is this bug marked confidential?

Comment 2

[Luis Villa [Outside Counsel; for non-law use [e-mail]]]

Because it is a legal matter and is intended to be privileged. I did not realize I would be cc'ing non-employees; if you do not object, I'll remove you from cc, Reed.

Comment 3

[Reed Loden [:reed]]

(In reply to comment #2)
> Because it is a legal matter and is intended to be privileged. I did not
> realize I would be cc'ing non-employees; if you do not object, I'll remove you
> from cc, Reed.

Considering I'm probably the one that would implement it, you would be doing yourself a disfavor by un-CC'ing me. ;)

I'm happy to add this... was just more curious why something like this would need to be privileged/confidential.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Adding links to a page sure doesn't sound like something that needs to be done in a private bug, even if the reasoning behind it is related to legal requirements. There's no real need to get into the reasoning given that there don't seem to be any objections, so I don't see any reasons to keep this bug hidden from the public. Am I missing something?

Comment 5

[Fred Wenzel [:wenzel]]

It's up to Legal if they want to keep this as confidential. Luis, if you decide these bugs should be in the Moco group, please also mark bug 606586 as such. Thanks.

Comment 6

[David Lawrence [:dkl]]

Attachment: Patch to add privacy policy footer to bottom of each page (v1)

Creates new extension for 3.6 called BMOFooter that just adds this link for now. The template will go in the normal BMO extension for 4.0.

Dave

Comment 7

[Reed Loden [:reed]]

Comment on attachment 501418 [details] [diff] [review]
Patch to add privacy policy footer to bottom of each page (v1)

>+# The Initial Developer of the Original Code is YOUR NAME

The Mozilla Foundation.

>+# The Initial Developer of the Original Code is YOUR NAME

Same.

>+<style>#footer .outro { text-align:left; padding-left:1ex; padding-bottom:1ex; }</style>

Should be in a .css file, no?

>+<a href="http://www.mozilla.org/about/policies/privacy-policy.html">Mozilla Privacy Policy</a>

Use the https:// version, else you get HTTPS to HTTP warnings. Also, "Privacy Policy" (without the Mozilla) might be better.

>=== modified file 'template/en/default/global/footer.html.tmpl'
>--- template/en/default/global/footer.html.tmpl	2010-09-08 02:34:32 +0000
>+++ template/en/default/global/footer.html.tmpl	2011-01-05 19:55:55 +0000
<snip>

Upstream this?

Comment 8

[David Lawrence [:dkl]]

Attachment: Patch to add privacy policy footer to bottom of each page (v2)

New patch with suggested changes.

Comment 9

[Reed Loden [:reed]]

Comment on attachment 501478 [details] [diff] [review]
Patch to add privacy policy footer to bottom of each page (v2)

>+# The Initial Developer of the Original Code is The Mozilla Foundation 

Missing period.

>=== added file 'extensions/BMOFooter/template/en/default/hook/global/header-additional_header.html.tmpl'
>--- extensions/BMOFooter/template/en/default/hook/global/header-additional_header.html.tmpl	1970-01-01 00:00:00 +0000
>+++ extensions/BMOFooter/template/en/default/hook/global/header-additional_header.html.tmpl	2011-01-05 22:51:35 +0000
>@@ -0,0 +1,1 @@
>+<link rel="stylesheet" type="text/css" href="extensions/BMOFooter/web/footer.css">

Ugh. Is there no way to just add stuff to an existing stylesheet? Bugzilla already has too many stylesheets as it is, and I'd prefer not to slow things down by adding to that. If there's not a way to add one using the extension system, just add it to the bmo custom global.css directly.

Comment 10

[Gervase Markham [:gerv]]

Some thoughts:

- You could just make this part of BMOHeader rather than create a whole new extension
- The extension docs say you don't need a Config.pm (move the NAME constant to Extension.pm)
- The extension docs also say you can have an extension which is just templates, so you don't need either .pm file!
- Yes, let's try and avoid having to load another style sheet. (I agree the extensibility of the style system leaves a little to be required at the moment.)

Gerv

Comment 11

[David Lawrence [:dkl]]

Attachment: Patch to add privacy policy footer to bottom of each page (v3)

New patch with suggest changes (v3).

Comment 12

[David Lawrence [:dkl]]

Bug 623608 created for adding intro/outro hooks to footer.html.tmpl.

Comment 13

[Gervase Markham [:gerv]]

Comment on attachment 501667 [details] [diff] [review]
Patch to add privacy policy footer to bottom of each page (v3)

I wouldn't add the intro hook unless we are using it. (Could lead to confusion later.) Otherwise, this looks great to me.

I suggest you wait until the outcome of your hook addition request upstream before making this change in 4.0.

Gerv

Comment 14

[David Lawrence [:dkl]]

Committing to: bzr+ssh://[e-mail]/bmo/3.6/                                                                         added extensions/BMOHeader/template/en/default/hook/global/footer-outro.html.tmpl
modified skins/custom/global.css
modified template/en/default/global/footer.html.tmpl                                                                 Committed revision 7220.

Will wait til the upstream request is fulfilled to commit this to 4.0 and then close this bug.

Dave

Comment 15

[David Lawrence [:dkl]]

Upstream hooks added so closing this bug now.

Comment 16

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://bugzilla.mozilla.org/.