[SeaMonkey] crash [@ nsNetscapeProfileMigratorBase::CopyCookies(int)]

RESOLVED FIXED in Thunderbird 3.3a1

Status

MailNews Core
Profile Migration
--
blocker
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: Bruno 'Aqualon' Escherl, Assigned: Bruno 'Aqualon' Escherl)

Tracking

({crash, fixed-seamonkey2.0.11, topcrash})

1.9.1 Branch
Thunderbird 3.3a1
crash, fixed-seamonkey2.0.11, topcrash
Dependency tree / graph
Bug Flags:
blocking-seamonkey2.0.9 -
blocking-seamonkey2.0.11 +

Firefox Tracking Flags

(Not tracked)

Details

(crash signature, URL)

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
Created attachment 480378 [details] [diff] [review]
return NS_ERROR_FAILURE if source profile is not available (branch version)

Bug 525513 forgot to fix the call from nsThunderbirdProfileMigrator::Migrate(), so this still crashes for SeaMonkey 2.0.x users (it's one of the topcrashers for 2.0.8). Would be nice if this could still make it into 2.0.9.

The attached branch patch also applies to trunk.
Flags: blocking-seamonkey2.0.9?
Attachment #480378 - Flags: review?(neil)
(Assignee)

Updated

7 years ago
Assignee: nobody → aqualon
Status: NEW → ASSIGNED

Comment 1

7 years ago
This is #14 on 2.0.8 topcrashes with 100 crashes in the last week, .67% of overall crashes, and we have already rolled 2.0.9 builds, this doesn't look respin-worthy to me, even if it's an annoyance.
For 2.0.10, we'll really want it, though.
Flags: blocking-seamonkey2.0.9?
Flags: blocking-seamonkey2.0.9-
Flags: blocking-seamonkey2.0.10+

Updated

7 years ago
Attachment #480378 - Flags: review?(neil) → review+
(Assignee)

Updated

7 years ago
Keywords: checkin-needed
Whiteboard: checkin-needed for c-c 1.9.1 branch and trunk
Comment on attachment 480378 [details] [diff] [review]
return NS_ERROR_FAILURE if source profile is not available (branch version)

Checked in on c-c: http://hg.mozilla.org/comm-central/rev/1575284f0f7a
Attachment #480378 - Flags: approval-seamonkey2.0.10?

Updated

7 years ago
Keywords: checkin-needed
Whiteboard: checkin-needed for c-c 1.9.1 branch and trunk
Nits, while here again:

1)
Bug 525513 comment 10:
"can you put the return NS_ERROR_FAILURE; on its own line"?

2)
http://mxr.mozilla.org/comm-central/search?string=GetSourceProfile&case=1&find=%2Fmigration%2F.*%5C.cpp%24
http://mxr.mozilla.org/comm-central/source/suite/profile/migration/src/nsSeamonkeyProfileMigrator.cpp#94
{
153   if (!mSourceProfile) {
154     GetSourceProfile(aProfile);
155     if (!mSourceProfile)
156       return NS_ERROR_FILE_NOT_FOUND;
}
Could you s/NS_ERROR_FAILURE/NS_ERROR_FILE_NOT_FOUND/g?
(Or the other way round, but use the same error everywhere.)

Thanks.

Updated

7 years ago
Attachment #480378 - Flags: approval-seamonkey2.0.10? → approval-seamonkey2.0.10+

Comment 4

7 years ago
Pushed http://hg.mozilla.org/releases/comm-1.9.1/rev/a60b91cc7a4a.
(Assignee)

Comment 5

7 years ago
Thanks for the checkins, marking this bug as fixed.

I'll file a followup bug for the cleanup from comment 3.
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
(Assignee)

Updated

7 years ago
Blocks: 601715
(In reply to comment #5)
> I'll file a followup bug for the cleanup from comment 3.

Bug 601715
Keywords: fixed-seamonkey2.0.10
Summary: crash [@ nsNetscapeProfileMigratorBase::CopyCookies(int)] → [SeaMonkey] crash [@ nsNetscapeProfileMigratorBase::CopyCookies(int)]
Target Milestone: --- → Thunderbird 3.3a1
No longer blocks: 601715
Depends on: 601715
Crash Signature: [@ nsNetscapeProfileMigratorBase::CopyCookies(int)]
You need to log in before you can comment on or make changes to this bug.