601715 - Cleanup of migration code

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Bruno 'Aqualon' Escherl]

https://bugzilla.mozilla.org/show_bug.cgi?id=601347#c3 mentioned some places in the code that need a cleanup.

Comment 1

[Serge Gautherie (:sgautherie)]

{{
Serge Gautherie (:sgautherie)      2010-10-03 07:54:46 PDT

Nits, while here again:

1)
Bug 525513 comment 10:
"can you put the return NS_ERROR_FAILURE; on its own line"?

2)
http://mxr.mozilla.org/comm-central/search?string=GetSourceProfile&case=1&find=%2Fmigration%2F.*%5C.cpp%24
http://mxr.mozilla.org/comm-central/source/suite/profile/migration/src/nsSeamonkeyProfileMigrator.cpp#94
{
153   if (!mSourceProfile) {
154     GetSourceProfile(aProfile);
155     if (!mSourceProfile)
156       return NS_ERROR_FILE_NOT_FOUND;
}
Could you s/NS_ERROR_FAILURE/NS_ERROR_FILE_NOT_FOUND/g?
(Or the other way round, but use the same error everywhere.)

Thanks.
}}

Comment 2

[Edmund Wong (:ewong)]

Attachment: Cleaned up migration code. (v1)

Comment 3

[Mark Banner (:standard8)]

(In reply to comment #2)
> Created attachment 520501 [details] [diff] [review]
> Cleaned up migration code. (v1)

This seems a Thunderbird specific patch, did you mean to include it here? (I'd really like Thunderbird related patches to be in Thunderbird product, or mailnews core if we can associate them there).

Comment 4

[Edmund Wong (:ewong)]

Attachment: Cleaned up migration code. (v2)

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 524181 [details] [diff] [review]
Cleaned up migration code. (v2)

Ok, thanks for the SM patch, this in principle looks fine, but I'm not going to have time to test it in SM, so I'm going to redirect review on this.

Comment 6

[Philip Chee]

Pushed:
http://hg.mozilla.org/comm-central/rev/2801b5ea8e04
http://hg.mozilla.org/releases/comm-2.0/rev/a94acd5abd0d