Closed Bug 601360 Opened 9 years ago Closed 9 years ago

Workaround as much as possible to be able to build with Clang on Mac OS X

Categories

(Firefox Build System :: General, defect)

x86
Windows 7
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Nomis101, Unassigned)

References

Details

Attachments

(1 file, 1 obsolete file)

This Bug is for keeping a patch to workaround as much as possible issues in Mozilla code to be able to build with Clang, until this issues are fixed.
The initial patch is from: http://llvm.org/bugs/show_bug.cgi?id=5511
Attached patch Workaround patch v1 (obsolete) — Splinter Review
This patch works with the current trunk from 2. October. I've got this patch from John Regehr and added a hack to workaround an issue with jsgcinlines.h
This patch also includes the fixes for Bug 579788, Bug 579786 and Bug 583460.
(In reply to comment #2)
> How is this bug different from bug 574346?

Bug 574346 is a tracking Bug. This Bug is for hosting a patch that is partly a hack and not a fix, so the issues in /widgets/cocoa can be fixed. See https://bugzilla.mozilla.org/show_bug.cgi?id=583460#c7
OS: Mac OS X → Windows 7
+ 600901 and 600900.
Attachment #480389 - Attachment is obsolete: true
OS: Windows 7 → Mac OS X
Comment on attachment 480796 [details] [diff] [review]
Workaround patch v2

>   const nsDefaultStringComparator defaultComparator;
>-  const nsASCIICaseInsensitiveStringComparator ciComparator;
>+  const nsASCIICaseInsensitiveStringComparator ciComparator = nsASCIICaseInsensitiveStringComparator();
Out of interest, why doesn't the default comparator need an explicit initialiser?
(In reply to comment #5)
> Comment on attachment 480796 [details] [diff] [review]
> Workaround patch v2
> 
> >   const nsDefaultStringComparator defaultComparator;
> >-  const nsASCIICaseInsensitiveStringComparator ciComparator;
> >+  const nsASCIICaseInsensitiveStringComparator ciComparator = nsASCIICaseInsensitiveStringComparator();
> Out of interest, why doesn't the default comparator need an explicit
> initialiser?

I have only copied this from llvm Bug 5511. If you are interested in details for this patch, its better to ask Eli Friedman who has written this lines. I only can say, that Clang doesn't produce an error for this.
OS: Mac OS X → Windows 7
Can we close this bug? I think 574346 is tracking all that we need and with newer clangs we shouldn't need any workaround.
Yes, you are right. We can close this, because its not needed anymore.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.