603049 - Buttons in about:addons have no style in latest Windows XP hourly

Status: VERIFIED DUPLICATE of bug 595842

(Toolkit :: Add-ons Manager, defect)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b8pre) Gecko/20101007 Firefox/4.0b8pre
Build Identifier: 

In the most recent hourly for Windows XP ( http://hg.mozilla.org/mozilla-central/rev/7e7c7a311e0d ), the "Options", "Disable", and "Remove" buttons have no styling, appearing as regular linked text.

They still appear correct in the previous night's nightly on XP, and it looks fine in the latest hourly on Windows 7.

On IRC, bz says those buttons have explicit -moz-appearance: none styling, according to DOMi, but when I check (on both XP and 7), DOMi shows them with -moz-appearance: button.

On IRC, aja says that something seems to be flipping -moz-appearance off, then back on upon a scroll event.

Reproducible: Always

Actual Results:  
Buttons have no styling on XP

Expected Results:  
Buttons are styled like buttons.

Screenshot: http://img.photobucket.com/albums/v444/KWierso/buttons.png

Comment 1

[Timothy Nikkel (:tnikkel)]

Caused by bug 595656 maybe?

Comment 2

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Broken cset: 649c9ec0ebad
Working cset: 81cc6c82dc08

Comment 3

[aja+bugzilla]

I though perhaps related to bug 601366 at first, but it landed late on the 6th, and 7th's nightly was okay.

Comment 4

[aja+bugzilla]

(In reply to comment #3)
> I though perhaps related to bug 601366 at first, but it landed late on the 6th,
> and 7th's nightly was okay.

err....and 8th's nightly was okay, too.

Don't know it this is related or not, but scrollbar appearance with AOM panels gets lost, too.

Requesting blocking since the "buttonless links" don't even have a normal link appearance (i.e. no link color, nor underline, nor change on hover).

Comment 5

[Paul [pwd]]

I'm also seeing this on Windows 7 32 bit.

Comment 6

[aja+bugzilla]

(In reply to comment #4)
> Don't know it this is related or not, but scrollbar appearance with AOM panels
> gets lost, too.
This has been filed as Bug 603120

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

(In reply to comment #5)
> I'm also seeing this on Windows 7 32 bit.

I don't. Maybe I have some extension forcing the styling.

Comment 8

[pal-moz]

(In reply to comment #5)
> I'm also seeing this on Windows 7 32 bit.

WFM on Win 7 32bit.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to comment #2)
> Broken cset: 649c9ec0ebad
> Working cset: 81cc6c82dc08

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=81cc6c82dc08&tochange=649c9ec0ebad

There is only bug 595656 but it hasn't been changed any CSS for the buttons. Do you also see it in Safe Mode?

Comment 10

[Dave Townsend [:mossop]]

It seems highly likely that the changes we made in bug 595656 are triggering some other effect, maybe bug 601366 is related as comment 3 suggests.

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Yeah, I can also see it now on the Win7 VMware box. No styling. Same applies to bug 603120 which is about scrollbars.

Comment 12

[Paul [pwd]]

Attachment: Screenshot of problem

Comment 13

[patrickjdempsey]

Seeing this on Oct 09 build on XP as well as 2000, both with virtually clean profiles.

Comment 14

[Dave Townsend [:mossop]]

I'm reliably informed that this will be fixed by bug 595842

Comment 15

[imradyurrad]

I'm also experiencing this on Win7 so I doubt it's an extension issue.

Comment 16

[pal-moz]

(In reply to comment #15)
> I'm also experiencing this on Win7 so I doubt it's an extension issue.

still fine here on Win 7.

did check with new profile ?

Comment 17

[Dave Townsend [:mossop]]

We're reasonably sure we know what is going on here, we don't need additional people saying that it does or doesn't work for them right now.

Comment 18

[Shadow912]

Doesn't work.
Confirm this issue on Mozilla/5.0 (Windows NT 5.1; rv:2.0b8pre) Gecko/20101011 Firefox/4.0b8pre Build ID: 20101011041543 and Mozilla/5.0 (Windows NT 5.1; rv:2.0b8pre) Gecko/20101010 Thunderbird/3.3a1pre Build ID: 20101010040417, both with clean profiile

Comment 19

[eyal gruss]

the rectangulars come and go

Comment 20

[Alan Thomas]

FWIW, this also affects HTTP error pages that appear inside the about:addons frame. See bug 603151 comment 0.

Comment 22

[[not reading bugmail]]

(In reply to comment #19)
> the rectangulars come and go

I have been noticing that if I scroll, the buttons come back, and then they disappear again after about 10 seconds of no movement. I think this is what you mean.

FWIW, I have not experienced this bug at all till two days ago, when I think I had ran 3.6.10 on top of my current Fx 4 profile though I also have plenty of addons installed, otherwise it was fine.

Comment 23

[[not reading bugmail]]

(In reply to comment #22)
> FWIW, I have not experienced this bug at all till two days ago, when I think I
> had ran 3.6.10 on top of my current Fx 4 profile though I also have plenty of
> addons installed, otherwise it was fine.

I guess this might not be it.  But I was able to reproduce with Windows 7 if use hardware acceleration when available is unchecked.  Which would disable D2D.

Comment 24

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Now that we ship beta7 from mozilla-central, shouldn't this block beta 7? It's a highly visible malfunction of the UI.

Comment 25

[Henrik Skupin [:whimboo][⌚️UTC+2]]

oh wait.. that should go to bug 595842.

Comment 27

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Looks good in todays build. Marking as verified dupe.