Closed Bug 603272 Opened 9 years ago Closed 9 years ago

starting private browsing from the taskbar button in Win7 doesn't launch Minefield

Categories

(Firefox :: Private Browsing, defect)

x86_64
Windows 7
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 4.0b8
Tracking Status
blocking2.0 --- final+

People

(Reporter: LogosZer0, Assigned: ehsan)

References

Details

(Keywords: regression)

Attachments

(1 file, 2 obsolete files)

User-Agent:       Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b8pre) Gecko/20101010 Firefox/4.0b8pre
Build Identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b8pre) Gecko/20101010 Firefox/4.0b8pre

just as it says, using the taskbar button on Win7 to launch Minefield in private browsing mode doesn't do anything, Minefield just doesn't start.

Reproducible: Always
Version: unspecified → Trunk
Mozilla/5.0 (Windows NT 6.1; rv:2.0b8pre) Gecko/20101017 Firefox/4.0b8pre

Able to reproduce. Minefield doesn't start when clicking the Taskbar and Start Menu button to "Enter Private Browsing".
Build worked : 
Mozilla/5.0 (Windows NT 6.1; rv:2.0b7pre) Gecko/20101004 Firefox/4.0b7pre
http://hg.mozilla.org/mozilla-central/rev/192c38466579

Build broken: 
Mozilla/5.0 (Windows NT 6.1; rv:2.0b7pre) Gecko/20101005 Firefox/4.0b7pre
http://hg.mozilla.org/mozilla-central/rev/10a6b2c105ae

Pushlog: 
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=192c38466579&tochange=10a6b2c105ae
Status: UNCONFIRMED → NEW
Ever confirmed: true
I can just guess bug 568816, cc-ing ehsan
Keywords: regression
Blocks: 568816
Yeah, dupe of bug 601391.
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
blocking2.0: --- → ?
Can you please include the exact steps to reproduce this bug?
(In reply to comment #5)
> Can you please include the exact steps to reproduce this bug?

1) close your nightly down completely
2) select enter private browsing mode from the jump list

nothing happens.

If you have a browser open already it works.
(In reply to comment #6)
> (In reply to comment #5)
> > Can you please include the exact steps to reproduce this bug?
> 
> 1) close your nightly down completely
> 2) select enter private browsing mode from the jump list
> 
> nothing happens.
> 
> If you have a browser open already it works.

Does the same thing happen if you run ./firefox -private-toggle from the command line?
(In reply to comment #7)
> (In reply to comment #6)
> > (In reply to comment #5)
> > > Can you please include the exact steps to reproduce this bug?
> > 
> > 1) close your nightly down completely
> > 2) select enter private browsing mode from the jump list
> > 
> > nothing happens.
> > 
> > If you have a browser open already it works.
> 
> Does the same thing happen if you run ./firefox -private-toggle from the
> command line?

C:\Program Files (x86)\Minefield>firefox.exe -private-toggle

doesn't seem to launch either. :(
yeah it's just that. Was already clear in my first post here...takes one second to reproduce.
Attached patch Patch (v1) (obsolete) — Splinter Review
This is totally my oversight in bug 568816.  The fix is really simple.  We basically didn't support nsISessionStore.init(null) calls correctly, so the initService stuff that I added in that bug didn't really work.
Attachment #488260 - Flags: review?(paul)
Component: General → Private Browsing
QA Contact: general → private.browsing
Attached patch Patch (v2) (obsolete) — Splinter Review
Attachment #488260 - Attachment is obsolete: true
Attachment #488295 - Flags: review?(paul)
Attachment #488260 - Flags: review?(paul)
Comment on attachment 488295 [details] [diff] [review]
Patch (v2)

Much better this way around :) I'd say "write a test" but that's not really in the realm of possible right now. r=me
Attachment #488295 - Flags: review?(paul) → review+
Attachment #488295 - Flags: approval2.0?
Gavin, would you mind approving this, please?
Comment on attachment 488295 [details] [diff] [review]
Patch (v2)

Need to also adjust the comment above init() per IRC discussion.
Attachment #488295 - Flags: approval2.0? → approval2.0-
Attached patch Patch (v3)Splinter Review
With comment updated.
Attachment #488295 - Attachment is obsolete: true
Attachment #493007 - Flags: approval2.0?
Attachment #493007 - Flags: approval2.0? → approval2.0+
Whiteboard: [needs landing]
http://hg.mozilla.org/mozilla-central/rev/f6ac6dfa9688
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: in-litmus?
Resolution: --- → FIXED
Whiteboard: [needs landing]
Target Milestone: --- → Firefox 4.0b8
blocking2.0: ? → final+
It is working, but if you use this, the entry in the jumplist is still labeled "Enter private browsing" then instead of "Quit private browsing". Maybe someone (who also knows how to fix it) can confirm that and file a new bug?
I think there is a bug for that.
(In reply to comment #18)
> I think there is a bug for that.

I really could not find any, filed bug 620580.
Depends on: 631973
Flags: in-litmus?
You need to log in before you can comment on or make changes to this bug.