603272 - starting private browsing from the taskbar button in Win7 doesn't launch Minefield

Status: RESOLVED FIXED

(Firefox :: Private Browsing, defect)

Description

[logos]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b8pre) Gecko/20101010 Firefox/4.0b8pre
Build Identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b8pre) Gecko/20101010 Firefox/4.0b8pre

just as it says, using the taskbar button on Win7 to launch Minefield in private browsing mode doesn't do anything, Minefield just doesn't start.

Reproducible: Always

Comment 1

[aravindm]

Mozilla/5.0 (Windows NT 6.1; rv:2.0b8pre) Gecko/20101017 Firefox/4.0b8pre

Able to reproduce. Minefield doesn't start when clicking the Taskbar and Start Menu button to "Enter Private Browsing".

Comment 2

[aravindm]

Build worked : 
Mozilla/5.0 (Windows NT 6.1; rv:2.0b7pre) Gecko/20101004 Firefox/4.0b7pre
http://hg.mozilla.org/mozilla-central/rev/192c38466579

Build broken: 
Mozilla/5.0 (Windows NT 6.1; rv:2.0b7pre) Gecko/20101005 Firefox/4.0b7pre
http://hg.mozilla.org/mozilla-central/rev/10a6b2c105ae

Pushlog: 
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=192c38466579&tochange=10a6b2c105ae

Comment 3

[Marco Bonardo [:mak]]

I can just guess bug 568816, cc-ing ehsan

Comment 4

[[not reading bugmail]]

Yeah, dupe of bug 601391.

Comment 5

[(no longer active)]

Can you please include the exact steps to reproduce this bug?

Comment 6

[Jim Mathies [:jimm]]

(In reply to comment #5)
> Can you please include the exact steps to reproduce this bug?

1) close your nightly down completely
2) select enter private browsing mode from the jump list

nothing happens.

If you have a browser open already it works.

Comment 7

[(no longer active)]

(In reply to comment #6)
> (In reply to comment #5)
> > Can you please include the exact steps to reproduce this bug?
> 
> 1) close your nightly down completely
> 2) select enter private browsing mode from the jump list
> 
> nothing happens.
> 
> If you have a browser open already it works.

Does the same thing happen if you run ./firefox -private-toggle from the command line?

Comment 8

[Jim Mathies [:jimm]]

(In reply to comment #7)
> (In reply to comment #6)
> > (In reply to comment #5)
> > > Can you please include the exact steps to reproduce this bug?
> > 
> > 1) close your nightly down completely
> > 2) select enter private browsing mode from the jump list
> > 
> > nothing happens.
> > 
> > If you have a browser open already it works.
> 
> Does the same thing happen if you run ./firefox -private-toggle from the
> command line?

C:\Program Files (x86)\Minefield>firefox.exe -private-toggle

doesn't seem to launch either. :(

Comment 9

[logos]

yeah it's just that. Was already clear in my first post here...takes one second to reproduce.

Comment 10

[(no longer active)]

Attachment: Patch (v1)

This is totally my oversight in bug 568816.  The fix is really simple.  We basically didn't support nsISessionStore.init(null) calls correctly, so the initService stuff that I added in that bug didn't really work.

Comment 11

[(no longer active)]

Attachment: Patch (v2)

Comment 12

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Comment on attachment 488295 [details] [diff] [review]
Patch (v2)

Much better this way around :) I'd say "write a test" but that's not really in the realm of possible right now. r=me

Comment 13

[(no longer active)]

Gavin, would you mind approving this, please?

Comment 14

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 488295 [details] [diff] [review]
Patch (v2)

Need to also adjust the comment above init() per IRC discussion.

Comment 15

[(no longer active)]

Attachment: Patch (v3)

With comment updated.

Comment 16

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/f6ac6dfa9688

Comment 17

[Christian Ascheberg]

It is working, but if you use this, the entry in the jumplist is still labeled "Enter private browsing" then instead of "Quit private browsing". Maybe someone (who also knows how to fix it) can confirm that and file a new bug?

Comment 18

[[not reading bugmail]]

I think there is a bug for that.

Comment 19

[Christian Ascheberg]

(In reply to comment #18)
> I think there is a bug for that.

I really could not find any, filed bug 620580.