603624 - Only blacklist I9000 devices with Android 2.1 (Linux 2.6.29).

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jacob Bramley [:jbramley]]

It seems as though the problem with the JITs on the I9000 devices is restricted to Android 2.1 (with Linux 2.6.29). We should only blacklist on these devices.

There is no public 2.2 image available for testing at this time, but others have identified that the JITs work correctly on some unofficial images. With this patch, the JITs should start working once 2.2 rolls out to real devices.

Comment 1

[Jacob Bramley [:jbramley]]

By the way, I found the kernel version of my Captivate device using adb. I'm assuming that there's no variation between I9000 devices running Android 2.1.

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

(Forgot to attach patch?  Unless I'm misunderstanding comment #0)

Comment 3

[Jacob Bramley [:jbramley]]

(In reply to comment #2)
> (Forgot to attach patch?  Unless I'm misunderstanding comment #0)

No, I just haven't written it. It's a relatively simple patch.

Comment 4

[Jacob Bramley [:jbramley]]

Attachment: Don't blacklist i9000 unless it's running 2.6.29.

Untested!

Comment 5

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Comment on attachment 482561 [details] [diff] [review]
Don't blacklist i9000 unless it's running 2.6.29.

This logic of this test bothers me somewhat (should be, |if !blacklisted device or blacklisted but kernel version > bad rev|), but this is all gross hacky stuff that's going to be axed in the not-so-distant future anyway.  Need r? from dvander.

Comment 6

[Brad Lassey [:blassey] (use needinfo?)]

pushed http://hg.mozilla.org/mozilla-central/rev/fe92d201e2c4