Closed Bug 603624 Opened 11 years ago Closed 11 years ago

Only blacklist I9000 devices with Android 2.1 (Linux 2.6.29).

Categories

(Core :: JavaScript Engine, defect)

ARM
Android
defect
Not set
major

Tracking

()

RESOLVED FIXED
Tracking Status
fennec 2.0b3+ ---

People

(Reporter: jbramley, Unassigned)

References

Details

Attachments

(1 file)

It seems as though the problem with the JITs on the I9000 devices is restricted to Android 2.1 (with Linux 2.6.29). We should only blacklist on these devices.

There is no public 2.2 image available for testing at this time, but others have identified that the JITs work correctly on some unofficial images. With this patch, the JITs should start working once 2.2 rolls out to real devices.
By the way, I found the kernel version of my Captivate device using adb. I'm assuming that there's no variation between I9000 devices running Android 2.1.
(Forgot to attach patch?  Unless I'm misunderstanding comment #0)
(In reply to comment #2)
> (Forgot to attach patch?  Unless I'm misunderstanding comment #0)

No, I just haven't written it. It's a relatively simple patch.
tracking-fennec: --- → ?
Attachment #482561 - Flags: feedback?(jones.chris.g)
tracking-fennec: ? → 2.0+
tracking-fennec: 2.0+ → 2.0b2+
Comment on attachment 482561 [details] [diff] [review]
Don't blacklist i9000 unless it's running 2.6.29.

This logic of this test bothers me somewhat (should be, |if !blacklisted device or blacklisted but kernel version > bad rev|), but this is all gross hacky stuff that's going to be axed in the not-so-distant future anyway.  Need r? from dvander.
Attachment #482561 - Flags: feedback?(jones.chris.g) → feedback+
Attachment #482561 - Flags: review?(dvander)
Attachment #482561 - Flags: review?(dvander) → review+
tracking-fennec: 2.0b2+ → 2.0+
tracking-fennec: 2.0+ → 2.0b3+
Whiteboard: [fennec-checkin-postb2][has-patch]
pushed http://hg.mozilla.org/mozilla-central/rev/fe92d201e2c4
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fennec-checkin-postb2][has-patch]
Blocks: 638963
You need to log in before you can comment on or make changes to this bug.