603958 - (fx40-p12n-es-CL) [es-CL] Firefox 4.0 productization review for Spanish (Chile)

Status: RESOLVED FIXED

(Mozilla Localizations :: es-CL / Spanish (Chile), defect)

Description

[Staś Małolepszy :stas]

As you might have seen in the newsgroups or on the Mozilla blog, there's a couple of changes to search engines planned for the 4.0 release for en-US: <http://groups.google.com/group/mozilla.dev.l10n/msg/81073d8d67e1c4c3>. We would like to use this opportunity to review the current productization setup for Spanish (Chile) and make any changes that you think will be good for our users.

What is a productization review?
================================

Here's what we're interested in:
* search engines,
* protocol handlers,
* feed readers,
* live bookmark.
You can see what your locale currently ships with at <http://hg.mozilla.org/l10n/l10n-src-verification/file/default/reference/browser/2.0/es-CL>

Please take a moment and review the choice of services available by default in your locale. If there have been any new services that have recently gained popularity and that offer good value for the users, please suggest adding them to your locale. On the other hand, if there are services that lost credibility (e.g. display too many adds) or have poor user experience, consider suggesting that we remove them. If in doubt, feel free to make a suggestion and we'll look at it together. You might find the guidelines at <https://wiki.mozilla.org/L10n:Productization> and <https://wiki.mozilla.org/L10n:Firefox/Productization> helpful, too.

Required changes
================

There's two things I would like to draw your attention to (if applicable):

1) if you have a google.xml file in your `searchplugins` directory, please remove it,

2) Bloglines is closing down on November 1st and we need to remove it from the feed reader options for all locales (see bug 595485). We suspect that it will make sense to move Google Reader up to the first position (if your locale has it). We will be offering technical help with this change, either in form of ready-made patches or a mass-landing by one of the l10n-drivers. If you don't think that moving Google Reader up is a good idea for your locale, please let us know!

Changes in en-US and en-GB
==========================

Here's the changes that we will be making in en-US and en-GB:
* add Bing as the 3rd general search engine (see bug 603298),
* remove Answers,
* remove Creative Commons.

We're making these changes in en-US and en-GB because we feel that they follow the recent market trends and user preferences in the US and the UK. We would like to go through the same thought process for your locale and see if any of these changes would make sense in Spanish (Chile) builds as well. If you decide that implementing these changes would be in your users' best interest then please go ahead and include them in the patch you'll attach to this bug.


Implementation
==============

Please make suggestions for changes and attach patches that Seth, Axel or I will review. Please note that since Bing provides a global plugin which does the locale detection itself, you will only need to add "bing" to your list.txt if you decide to include it. The XML file will be automatically pulled from en-US.

Once a review is granted, you can land the patch on l10n-central if your locale actively maintains it. Otherwise, please wait for further instructions which will be put in the comments of this bug and announced in mozilla.dev.l10n (we're still unsure when the branching will happen). Please do not land any changes except for the required ones (google.xml, Bloglines) on 1.9.2.

If you do not wish to make any changes, let us know, and we'll only work on removing Bloglines.

Thanks!

Comment 1

[Seth Bindernagel]

Bloglines still remains in your 1.9.2 repository.  Please prepare a patch to remove it. 

Also, if you have any productization changes to make for Firefox 4, like the Bing suggestion listed in comment 0, please provide a patch to make that change on l10n-central.  Thank you.

Comment 2

[Emilio Sepulveda]

Attachment: Patch for remove bloglines from 1.9.2 es-CL

Comment 3

[Emilio Sepulveda]

Attachment: Patch for add Bing and remove bloglines from Fx4 es-CL

Comment 4

[Seth Bindernagel]

Comment on attachment 493334 [details] [diff] [review]
Patch for add Bing and remove bloglines from Fx4 es-CL

This will not work.  browser.contentHandlers.types needs to start with 0.  So, you patch should look like this:

browser.contentHandlers.types.0.title=Google
browser.contentHandlers.types.0.uri=http://fusion.google.com/add?feedurl=%s
browser.contentHandlers.types.1.title=My Yahoo
browser.contentHandlers.types.1.uri=http://add.my.yahoo.com/rss?url=%s
browser.contentHandlers.types.2.title=Netvibes
browser.contentHandlers.types.2.uri=http://www.netvibes.com/subscribe.php?url=%s

Also, you can watch out for any unnecessary lines or spaces that might be added, just for cleanliness sake.

Finally, I see you want to replace Yahoo with Bing in your browser's search engine order.  That's fine.  But, you still intend to keep Yahoo as it is listed in your list.txt, correct?  If that's the case, it looks fine.

Please make the changes and flag me again for the next review.

Comment 5

[Seth Bindernagel]

Comment on attachment 493333 [details] [diff] [review]
Patch for remove bloglines from 1.9.2 es-CL

Same feedback repeated:  browser.contentHandlers.types needs to start with 0.  So,
your patch should look like this:

browser.contentHandlers.types.0.title=Google
browser.contentHandlers.types.0.uri=http://fusion.google.com/add?feedurl=%s
browser.contentHandlers.types.1.title=My Yahoo
browser.contentHandlers.types.1.uri=http://add.my.yahoo.com/rss?url=%s
browser.contentHandlers.types.2.title=Netvibes
browser.contentHandlers.types.2.uri=http://www.netvibes.com/subscribe.php?url=%s

Please make the changes and reattach.  Thanks!

Comment 6

[Emilio Sepulveda]

Attachment: Patch for add Bing and remove bloglines from Fx4 es-CL

Replaces patch 493334

Comment 7

[Emilio Sepulveda]

Attachment: Patch for remove bloglines from 1.9.2 es-CL

Comment 8

[Seth Bindernagel]

Comment on attachment 493478 [details] [diff] [review]
Patch for add Bing and remove bloglines from Fx4 es-CL

Please check this in to l10n-central and add a comment that references bug 603959 and the change.  Please don't forget to sign off.

Comment 9

[Seth Bindernagel]

Comment on attachment 493480 [details] [diff] [review]
Patch for remove bloglines from 1.9.2 es-CL

I am uncertain about the mobile/.DS_Store piece that I see in this patch.  I believe that is something to do with Mac OSX.  I have flagged Stas for a review on this because I don't think we want any of that to hit our repo.  However, I could be wrong and it might not matter.

Comment 10

[Staś Małolepszy :stas]

Comment on attachment 493480 [details] [diff] [review]
Patch for remove bloglines from 1.9.2 es-CL

The mobile/.DS_Store part of the patch is harmless, it's a binary file, and the patch only applies to text files. 

Please apply the patch and commit.

That said, please remove this file when you get a chance and preferably add 

  syntax: glob
  .DS_Store

to your .hgignore (create this file in your local clone if it doesn't exist and commit it).

Comment 11

[Emilio Sepulveda]

Committed: 1.9.2: http://hg.mozilla.org/releases/l10n-mozilla-1.9.2/es-CL/rev/a33c4ad0efb2
and Fx4:  http://hg.mozilla.org/l10n-central/es-CL/rev/3ac96e0fe368

Thanks!

Comment 12

[Seth Bindernagel]

Emilio, after you have tested your changes and signed off on these changesets, can you resolve this bug as fixed please?  Thanks

Comment 13

[Staś Małolepszy :stas]

https://hg.mozilla.org/l10n/l10n-src-verification/rev/5a58ed040152

Comment 14

[Seth Bindernagel]

Resolving this fixed.