604018 - (fx40-p12n-th) [th] Firefox 4.0 productization review for Thai

Status: RESOLVED FIXED

(Mozilla Localizations :: th / Thai, defect)

Description

[Staś Małolepszy :stas]

As you might have seen in the newsgroups or on the Mozilla blog, there's a couple of changes to search engines planned for the 4.0 release for en-US: <http://groups.google.com/group/mozilla.dev.l10n/msg/81073d8d67e1c4c3>. We would like to use this opportunity to review the current productization setup for Thai and make any changes that you think will be good for our users.

What is a productization review?
================================

Here's what we're interested in:
* search engines,
* protocol handlers,
* feed readers,
* live bookmark.
You can see what your locale currently ships with at <http://hg.mozilla.org/l10n/l10n-src-verification/file/default/reference/browser/2.0/th>

Please take a moment and review the choice of services available by default in your locale. If there have been any new services that have recently gained popularity and that offer good value for the users, please suggest adding them to your locale. On the other hand, if there are services that lost credibility (e.g. display too many adds) or have poor user experience, consider suggesting that we remove them. If in doubt, feel free to make a suggestion and we'll look at it together. You might find the guidelines at <https://wiki.mozilla.org/L10n:Productization> and <https://wiki.mozilla.org/L10n:Firefox/Productization> helpful, too.

Required changes
================

There's two things I would like to draw your attention to (if applicable):

1) if you have a google.xml file in your `searchplugins` directory, please remove it,

2) Bloglines is closing down on November 1st and we need to remove it from the feed reader options for all locales (see bug 595485). We suspect that it will make sense to move Google Reader up to the first position (if your locale has it). We will be offering technical help with this change, either in form of ready-made patches or a mass-landing by one of the l10n-drivers. If you don't think that moving Google Reader up is a good idea for your locale, please let us know!

Changes in en-US and en-GB
==========================

Here's the changes that we will be making in en-US and en-GB:
* add Bing as the 3rd general search engine (see bug 603298),
* remove Answers,
* remove Creative Commons.

We're making these changes in en-US and en-GB because we feel that they follow the recent market trends and user preferences in the US and the UK. We would like to go through the same thought process for your locale and see if any of these changes would make sense in Thai builds as well. If you decide that implementing these changes would be in your users' best interest then please go ahead and include them in the patch you'll attach to this bug.


Implementation
==============

Please make suggestions for changes and attach patches that Seth, Axel or I will review. Please note that since Bing provides a global plugin which does the locale detection itself, you will only need to add "bing" to your list.txt if you decide to include it. The XML file will be automatically pulled from en-US.

Once a review is granted, you can land the patch on l10n-central if your locale actively maintains it. Otherwise, please wait for further instructions which will be put in the comments of this bug and announced in mozilla.dev.l10n (we're still unsure when the branching will happen). Please do not land any changes except for the required ones (google.xml, Bloglines) on 1.9.2.

If you do not wish to make any changes, let us know, and we'll only work on removing Bloglines.

Thanks!

Comment 1

[Seth Bindernagel]

Bloglines still remains in your 1.9.2 repository.  Please prepare a patch to remove it and flag Seth for a review.

Also, if you have any productization changes to make for Firefox 4, like the Bing suggestion listed in comment 0, please provide a patch to make that change on l10n-central.

Comment 2

[Keng Susumpow]

Attachment: patch for mozilla-central

- remove bloglines
- move google reader up to the top
- add bing

Comment 3

[Keng Susumpow]

Attachment: patch for mozilla-1.9.2

- remove bloglines
- move google reader to the top

Comment 4

[Keng Susumpow]

Firefox 4.0 productization for Thai and there're 2 remaining things under discussion

- Live bookmark
- "Getting Start" page which is already filed on Bug 447701

Comment 5

[Keng Susumpow]

ouch!

I accidentally pushed those fixes in attachment 491649 [details] [diff] [review] to mozilla-central before those get reviewed.

My intension is to commit-and-push only browser/chrome/browser/browser.properties for bug 576806.

photonnanoatomic:firefox.th.central keng$ hg commit -m 'bug 576806: Replace hardcoded "Firefox" with "#3" in addonError-4 on browser/chrome/browser/browser.properties'
browser/chrome/browser-region/region.properties
browser/chrome/browser/browser.properties
browser/searchplugins/list.txt
committed changeset 225:a6ead0aae370
photonnanoatomic:firefox.th.central keng$ hg push
pushing to ssh://hg.mozilla.org/l10n-central/th/
searching for changes
remote: adding changesets
remote: adding manifests
remote: adding file changes
remote: added 1 changesets with 3 changes to 3 files
remote: Trying to insert into pushlog.
remote: Please do not interrupt...
remote: Inserted into the pushlog db successfully.
photonnanoatomic:firefox.th.central keng$ hg status
photonnanoatomic:firefox.th.central keng$

Comment 6

[Seth Bindernagel]

Comment on attachment 491649 [details] [diff] [review]
patch for mozilla-central

Looks good.  Please commit this to l10n-central.  Add a comment to the checkin that references bug 604018 and this change.  Thank you.

Comment 7

[Seth Bindernagel]

Comment on attachment 491651 [details] [diff] [review]
patch for mozilla-1.9.2

Please check in and add a comment that references bug 604018 and this change.

Comment 8

[Seth Bindernagel]

Keng, before we close this, should we consider removing one search plugin from your Firefox 4 version.  If we go with the set from your patch, we'll have 7:

 amazondotcom
 bing
 creativecommons
 eBay
 google
 longdo
 wikipedia-th
 yahoo

Is Creative Commons still relevant?  Should we remove a different one?  I'll leave this bug open for the community to discuss.

Comment 9

[Keng Susumpow]

Seth, we've discussed about creative commons, and we're agree to keep creative commons search plugin.

attachment 491651 [details] [diff] [review] is landed to mozilla-1.9.2; changeset 9b18674c087c.
attachment 491649 [details] [diff] [review] is accidnetally landed to mozilla-central before it's get reviewed; changeset a6ead0aae370.

We're would like to change the Live bookmark to thai news agency's feed (http://www.mcot.net/cfcustom/cache_page/c109.xml), should we file another bug?

Comment 10

[Seth Bindernagel]

Yeah, please file another bug here:

https://bugzilla.mozilla.org/enter_bug.cgi?product=Mozilla%20Localizations

Component: Thai

We can take care of that there.

Comment 11

[Axel Hecht [:Pike]]

Updated l10n-src-verification for central, fwiw.

Comment 12

[Staś Małolepszy :stas]

...and for 1.9.2. Thanks.