Closed
Bug 604022
(fx40-p12n-zh-CN)
Opened 14 years ago
Closed 14 years ago
[zh-CN] Firefox 4.0 productization review for Chinese (Simplified)
Categories
(Mozilla Localizations :: zh-CN / Chinese (Simplified), defect)
Mozilla Localizations
zh-CN / Chinese (Simplified)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: stas, Assigned: shaohua.wen)
References
Details
(Keywords: productization, Whiteboard: [l10n-src-verification updated])
Attachments
(3 files)
964 bytes,
patch
|
sethb
:
review-
|
Details | Diff | Splinter Review |
1.27 KB,
patch
|
sethb
:
review+
|
Details | Diff | Splinter Review |
1.10 KB,
patch
|
sethb
:
review+
|
Details | Diff | Splinter Review |
As you might have seen in the newsgroups or on the Mozilla blog, there's a couple of changes to search engines planned for the 4.0 release for en-US: <http://groups.google.com/group/mozilla.dev.l10n/msg/81073d8d67e1c4c3>. We would like to use this opportunity to review the current productization setup for Chinese (Simplified) and make any changes that you think will be good for our users.
What is a productization review?
================================
Here's what we're interested in:
* search engines,
* protocol handlers,
* feed readers,
* live bookmark.
You can see what your locale currently ships with at <http://hg.mozilla.org/l10n/l10n-src-verification/file/default/reference/browser/2.0/zh-CN>
Please take a moment and review the choice of services available by default in your locale. If there have been any new services that have recently gained popularity and that offer good value for the users, please suggest adding them to your locale. On the other hand, if there are services that lost credibility (e.g. display too many adds) or have poor user experience, consider suggesting that we remove them. If in doubt, feel free to make a suggestion and we'll look at it together. You might find the guidelines at <https://wiki.mozilla.org/L10n:Productization> and <https://wiki.mozilla.org/L10n:Firefox/Productization> helpful, too.
Required changes
================
There's two things I would like to draw your attention to (if applicable):
1) if you have a google.xml file in your `searchplugins` directory, please remove it,
2) Bloglines is closing down on November 1st and we need to remove it from the feed reader options for all locales (see bug 595485). We suspect that it will make sense to move Google Reader up to the first position (if your locale has it). We will be offering technical help with this change, either in form of ready-made patches or a mass-landing by one of the l10n-drivers. If you don't think that moving Google Reader up is a good idea for your locale, please let us know!
Changes in en-US and en-GB
==========================
Here's the changes that we will be making in en-US and en-GB:
* add Bing as the 3rd general search engine (see bug 603298),
* remove Answers,
* remove Creative Commons.
We're making these changes in en-US and en-GB because we feel that they follow the recent market trends and user preferences in the US and the UK. We would like to go through the same thought process for your locale and see if any of these changes would make sense in Chinese (Simplified) builds as well. If you decide that implementing these changes would be in your users' best interest then please go ahead and include them in the patch you'll attach to this bug.
Implementation
==============
Please make suggestions for changes and attach patches that Seth, Axel or I will review. Please note that since Bing provides a global plugin which does the locale detection itself, you will only need to add "bing" to your list.txt if you decide to include it. The XML file will be automatically pulled from en-US.
Once a review is granted, you can land the patch on l10n-central if your locale actively maintains it. Otherwise, please wait for further instructions which will be put in the comments of this bug and announced in mozilla.dev.l10n (we're still unsure when the branching will happen). Please do not land any changes except for the required ones (google.xml, Bloglines) on 1.9.2.
If you do not wish to make any changes, let us know, and we'll only work on removing Bloglines.
Thanks!
Comment 1•14 years ago
|
||
Seems like http://hg.mozilla.org/l10n-central/zh-CN/diff/9706209bbd2e/browser/chrome/browser-region/region.properties landed accidently.
I'm not going to reject the sign-off based on that, please revert that change, or come to a resolution with this bug.
Assignee | ||
Comment 2•14 years ago
|
||
Is this OK?
Comment 3•14 years ago
|
||
Comment on attachment 483672 [details] [diff] [review]
patch to rollback and add bing to list
This looks ok to me, putting a real review request on seth.
This is somewhat obsoleted by http://hg.mozilla.org/l10n-central/zh-CN/diff/e623fee760bc/browser/chrome/browser-region/region.properties, though. That added a third plugin ordering, which I can't find a plugin for?
Attachment #483672 -
Flags: review?(sethb)
Comment 4•14 years ago
|
||
Comment on attachment 483672 [details] [diff] [review]
patch to rollback and add bing to list
1) It seems you have added Bing, but you have not removed Bloglines. Please remove Bloglines from the set of browser.contentHandlers.types. You can move Google to the 0 position and Yahoo to the 1 position.
2) I will need to see a separate patch for the 1.9.2 branch that _only_ removes Bloglines.
I will need to see two separate patches, one for l10n-central and one for 1.9.2.
Attachment #483672 -
Flags: review?(sethb) → review-
Assignee | ||
Comment 5•14 years ago
|
||
(In reply to comment #3)
> though. That added a third plugin ordering, which I can't find a plugin for?
That's the Chinese name of Bing.
Assignee | ||
Comment 6•14 years ago
|
||
Attachment #487793 -
Flags: review?
Comment 7•14 years ago
|
||
Comment on attachment 487793 [details] [diff] [review]
remove Bloglines and using English name for Bing.
Please check this into l10n-central only, adding a comment that references bug 604022 and this change. I need a patch for 1.9.2 that removes bloglines. Please attach that.
Attachment #487793 -
Flags: review? → review+
Updated•14 years ago
|
Whiteboard: [update l10n-src-verification]
Assignee | ||
Comment 8•14 years ago
|
||
Attachment #491042 -
Flags: review?
Assignee | ||
Updated•14 years ago
|
Attachment #491042 -
Flags: review? → review?(sethb)
Comment 9•14 years ago
|
||
Comment on attachment 491042 [details] [diff] [review]
remove bloglines in 1.9.2
Please check this in and add a comment that references bug 604022 and this change. Thank you, Holy.
Attachment #491042 -
Flags: review?(sethb) → review+
Comment 10•14 years ago
|
||
Please close this bug after you check in the change.
Assignee | ||
Comment 11•14 years ago
|
||
committed.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Reporter | ||
Updated•14 years ago
|
Whiteboard: [update l10n-src-verification] → [l10n-src-verification updated]
Assignee | ||
Comment 12•14 years ago
|
||
Can you look at this bug also, about this productization.
Bug 614883 .
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 13•14 years ago
|
||
Holy, why did you reopen this bug? I'd argue that this bug should only be reopened if something that this bug intended to do didn't happen, or regressed.
The suggested changes in bug 614883 seem kinda orthogonal to me.
Assignee | ||
Comment 14•14 years ago
|
||
Sorry I think they are the same thing . At least I want to gain some attention from you :)
Assignee | ||
Comment 15•14 years ago
|
||
Actually bug 614883 is talking about search engines, which is mentioned in the bug description:
> What is a productization review?
> ================================
>
> Here's what we're interested in:
>* search engines,
Comment 16•14 years ago
|
||
All the relevant people are CCed on bug 614883. This bug is closed, really, as in, the offer to take changes in en-US to the zh-CN build are done. Marking FIXED again.
If you want to ping about a bug, please ping in the actual bug?
Status: REOPENED → RESOLVED
Closed: 14 years ago → 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•