605179 - Fix build warnings in gfx/

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

+    PRInt32 major = 0, minor = 0, final = 0;

Move these assignments to a "default:" case in the switch (and put an NS_ERROR there to say that it's unreached)

+    FcPattern* pattern = NULL;

I don't understand this one. pattern is assigned along both branches of the 'if'. Why is this needed?

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

(In reply to comment #1)
> +    PRInt32 major = 0, minor = 0, final = 0;
> 
> Move these assignments to a "default:" case in the switch (and put an NS_ERROR
> there to say that it's unreached)

Ok.

> +    FcPattern* pattern = NULL;
> 
> I don't understand this one. pattern is assigned along both branches of the
> 'if'. Why is this needed?

No idea. Compiler being stupid, I suppose.

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v2

(In reply to comment #2)
> > +    FcPattern* pattern = NULL;
> > 
> > I don't understand this one. pattern is assigned along both branches of the
> > 'if'. Why is this needed?
> 
> No idea. Compiler being stupid, I suppose.

Seems like it actually wasn't necessary. Not sure what happened here.

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v2.1

Merged to tip.

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch for checkin

Thanks.

Comment 6

[Dão Gottwald [:dao]]

patching file gfx/thebes/gfxASurface.cpp
Hunk #1 FAILED at 481

Comment 7

[Jonathan Watt [:jwatt]]

Pushed http://hg.mozilla.org/mozilla-central/rev/0ec22e77aefc

Comment 9

[timeless]

so, that mathematical impossibility isn't. it's a c feature:
 <signed int> <mod> <unsigned int> is underspecified.

e.g. -1 % 2 could be 1 or -1.

Comment 10

[Jeff Muizelaar [:jrmuizel]]

I would have rather we didn't take the qcms changes here. qcms is written in the subset of c99 supported by MSVC which include c++ style comments.