Closed
Bug 605179
Opened 14 years ago
Closed 14 years ago
Fix build warnings in gfx/
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: Ms2ger, Assigned: Ms2ger)
References
Details
(Whiteboard: [build_warning])
Attachments
(1 file, 3 obsolete files)
18.05 KB,
patch
|
Details | Diff | Splinter Review |
No description provided.
Flags: in-testsuite-
Attachment #484015 -
Flags: review?(roc)
+ PRInt32 major = 0, minor = 0, final = 0; Move these assignments to a "default:" case in the switch (and put an NS_ERROR there to say that it's unreached) + FcPattern* pattern = NULL; I don't understand this one. pattern is assigned along both branches of the 'if'. Why is this needed?
Assignee | ||
Comment 2•14 years ago
|
||
(In reply to comment #1) > + PRInt32 major = 0, minor = 0, final = 0; > > Move these assignments to a "default:" case in the switch (and put an NS_ERROR > there to say that it's unreached) Ok. > + FcPattern* pattern = NULL; > > I don't understand this one. pattern is assigned along both branches of the > 'if'. Why is this needed? No idea. Compiler being stupid, I suppose.
Assignee | ||
Comment 3•14 years ago
|
||
(In reply to comment #2) > > + FcPattern* pattern = NULL; > > > > I don't understand this one. pattern is assigned along both branches of the > > 'if'. Why is this needed? > > No idea. Compiler being stupid, I suppose. Seems like it actually wasn't necessary. Not sure what happened here.
Attachment #484015 -
Attachment is obsolete: true
Attachment #491902 -
Flags: review?(roc)
Attachment #484015 -
Flags: review?(roc)
Assignee | ||
Comment 4•14 years ago
|
||
Merged to tip.
Attachment #491902 -
Attachment is obsolete: true
Attachment #492051 -
Flags: review?(roc)
Attachment #491902 -
Flags: review?(roc)
Attachment #492051 -
Flags: review?(roc) → review+
Assignee | ||
Updated•14 years ago
|
Attachment #492051 -
Flags: approval2.0?
Updated•14 years ago
|
Attachment #492051 -
Flags: approval2.0? → approval2.0+
Assignee | ||
Updated•14 years ago
|
Keywords: checkin-needed
Comment 6•14 years ago
|
||
patching file gfx/thebes/gfxASurface.cpp Hunk #1 FAILED at 481
Keywords: checkin-needed
Comment 7•14 years ago
|
||
Pushed http://hg.mozilla.org/mozilla-central/rev/0ec22e77aefc
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
so, that mathematical impossibility isn't. it's a c feature: <signed int> <mod> <unsigned int> is underspecified. e.g. -1 % 2 could be 1 or -1.
Comment 10•13 years ago
|
||
I would have rather we didn't take the qcms changes here. qcms is written in the subset of c99 supported by MSVC which include c++ style comments.
You need to log in
before you can comment on or make changes to this bug.
Description
•