606327 - Investigate updating Thunderbird to the latest MozMill

Status: RESOLVED FIXED

(Thunderbird :: Testing Infrastructure, defect)

Description

[Mark Banner (:standard8)]

Attachment: WIP

MozMill 1.5.1 is soon to be released so we should consider upgrading. However, I really want to upgrade because it contains a fix whereby we can correctly run 32/64 bit universal binaries on 10.5 and 10.6.

With our current efforts to get 64 bit builders running, having packaged tests run on both platforms would give us a lot more confidence in the two.

I've updated my local copy to the latest git version (probably 7eedd5e23b8bc8751b6cba3d1e6a99e95570a576).

It fails to run mozmill - there's obviously some changes in place.

I have a work in progress patch (see attached), but at the moment, I can't seem to get it past ThunderTestCLI.__init_():

Traceback (most recent call last):
  File "runtest.py", line 396, in <module>
    ThunderTestCLI(args=sys.argv[1:]).run()
  File "runtest.py", line 280, in __init__
    mozmill.CLI.__init__(self, args)
  File "/Users/moztest/comm/mozmill/mozmill/mozmill/mozmill/__init__.py", line 493, in __init__
    handler = handlers.instantiate_handler(cls, self.options)
  File "/Users/moztest/comm/mozmill/mozmill/mozmill/mozmill/handlers.py", line 31, in instantiate_handler
    args = argspec.args[1:] # don't need to pass self
AttributeError: 'tuple' object has no attribute 'args'

Help/advice/patches welcome.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Bug 607264 is for master only, so I don't think it will block you from switching to Mozmill 1.5.1. :) Removing dependency.

Comment 2

[Mark Banner (:standard8)]

Attachment: The fix

MozMill 1.5 likes to have results as strings, so we need to convert them back to objects.

In addition, MozMill 1.5 also does the TEST-UNEXPECTED-FAIL and TEST-PASS that tinderbox wants.

As developers still need a sane exception tree output that is also at the end of the log (rather than looking through miles of debug), I've kept our output at the end, but in the MozMill 1.5 case, I've changed TEST-UNEXPECTED-FAIL to SUMMARY-UNEXPECTED-FAIL so that we don't get double-counting.

I think this is a reasonable compromise for now, and lets us support both MozMill 1.4 and 1.5, which makes the transition slightly easier.

Comment 3

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 491525 [details] [diff] [review]
The fix

You probably want to use "basestring" instead of "str" since:

In [21]: str.__mro__
Out[21]: (<type 'str'>, <type 'basestring'>, <type 'object'>)

In [22]: unicode.__mro__
Out[22]: (<type 'unicode'>, <type 'basestring'>, <type 'object'>)

Comment 4

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/38f77a75000d