606593 - Link to license is incorrect and has incorrect localization

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P4)

Description

[Matthew Turnbull [Bluefang]]

User-Agent:       Mozilla/5.0 (X11; Linux x86_64; rv:2.0b8pre) Gecko/20101022 Firefox/4.0b8pre
Build Identifier: 

I uploaded 2 new versions of an extension late October 19th. For some reason, the link to the source code license is different and the link text is Russian.

Link:
https://addons.mozilla.org/en-US/firefox/addon/235283/versions/

Screenshot:
http://files.bluefang-logic.com/images/amo_scl_oddity.png


Reproducible: Always

Steps to Reproduce:
Upload a new extension version, edit the version, and set the license to MPL 1.1
Actual Results:  
Позволяет делать экспорт писем
https://addons.mozilla.org/en-US/firefox/versions/license/119782

Expected Results:  
Mozilla Public License, version 1.1
http://www.mozilla.org/MPL/MPL-1.1.html

https://forums.addons.mozilla.org/viewtopic.php?f=20&t=1914

Comment 1

[Jeff Balogh (:jbalogh)]

Added a script to fix this up in http://github.com/jbalogh/zamboni/commit/275ec20.

This should get pushed out later today.

Comment 2

[Jeff Balogh (:jbalogh)]

Fixed on https://addons.mozilla.org/z/en-US/firefox/addon/235283/license/2010.10.19.22.

Adding the rewrites for the old version urls is bug 607817.

Comment 3

[krupa raj[:krupa]]

verified at https://addons.mozilla.org/en-US/firefox/addon/235283/versions/

Matthew, Can you confirm?

Comment 4

[Matthew Turnbull [Bluefang]]

Well, my two misbehaving versions were set to "Mozilla Public License, version 1.1" (which is what I wanted) and now they're set to "Custom license". The link text is now "Custom License", so that is correct for the locale and license selection.

However, the custom license text that now appears is:

https://addons.mozilla.org/en-US/firefox/addon/235283/license/2010.10.19.22

"You are free to use BitDefender QuickScan with any of the applications or services offered by Mozilla. All Other Rights Reserved."

Which has absolutely nothing to do with my extension. So overall, I'm classifying this as a step sideways rather than a step forwards.

Though, the link in bug 607817 ( https://addons.mozilla.org/en-US/firefox/versions/license/119782 ) is empty, which is what I'd expect since I've never set a custom license.



I edited version 2010.10.20.02 and set the license back to MPL and the link text and href were changed correctly. For the time being, I'll leave version 2010.10.19.22 unchanged with the 'custom license' that is not mine, in case you want to investigate that.

Comment 5

[krupa raj[:krupa]]

Issue from comment #4 was fixed in bug 608133

Verified FIXED-

https://addons.mozilla.org/en-US/firefox/addon/235283/license/2010.10.19.22 has MPL

https://addons.mozilla.org/en-US/firefox/addon/235283/versions/?page=1#version-2010.10.19.22