Tab close button doesn't show after moving some tabs to other group

VERIFIED FIXED in Firefox 4.0b8

Status

defect
P3
normal
VERIFIED FIXED
9 years ago
3 years ago

People

(Reporter: tabutils+bugzilla, Assigned: raymondlee)

Tracking

Trunk
Firefox 4.0b8
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

User-Agent:       Mozilla/5.0 (Windows NT 5.1; rv:2.0b8pre) Gecko/20101024 Firefox/4.0b8pre
Build Identifier: Mozilla/5.0 (Windows NT 5.1; rv:2.0b8pre) Gecko/20101024 Firefox/4.0b8pre

After moving some tabs to another group, tab close buttons doesn't appear on the background tabs even when they're wider than tabClipWidth.

Reproducible: Always

Steps to Reproduce:
1. Open 10 tabs or so, and tab close buttons on background tabs disappear.
2. Move tabs to another group one by one.
Blocks: 597043
Assignee: nobody → raymond
Status: UNCONFIRMED → NEW
Ever confirmed: true
Posted patch v1 (obsolete) — Splinter Review
Attachment #486668 - Flags: feedback?(ian)
Blocks: 606905
No longer blocks: 606905
Status: NEW → ASSIGNED
Blocks: 606905
OS: Windows XP → All
Hardware: x86 → All
Version: unspecified → Trunk
Comment on attachment 486668 [details] [diff] [review]
v1

Looks good to me.
Attachment #486668 - Flags: review?(dao)
Attachment #486668 - Flags: feedback?(ian)
Attachment #486668 - Flags: feedback+
Comment on attachment 486668 [details] [diff] [review]
v1

It seems to me that this should be done as part of hideTab and showTab.
Attachment #486668 - Flags: review?(dao) → review-
Posted patch v1 (obsolete) — Splinter Review
Based on dao's comment, put adjustTabstrip() in showTab() and hideTab()
Attachment #486668 - Attachment is obsolete: true
Attachment #486830 - Flags: feedback?(ian)
(In reply to comment #4)
> Based on dao's comment, put adjustTabstrip() in showTab() and hideTab()

Doesn't this add too many unnecessary adjustTabstrip calls? We don't have an UI command to trigger showTab/hideTab directly.
I filed another bug 608184, which is also related to moveTabToGroup.
Duplicate of this bug: 606905
(In reply to comment #5)
> We don't have an UI command to trigger showTab/hideTab directly.

Doesn't matter -- It's part of the tabbrowser API.
Comment on attachment 486830 [details] [diff] [review]
v1

Passed try!
Comment on attachment 486830 [details] [diff] [review]
v1

Looks good
Attachment #486830 - Flags: review?(dao)
Attachment #486830 - Flags: feedback?(ian)
Attachment #486830 - Flags: feedback+
Comment on attachment 486830 [details] [diff] [review]
v1

>+  // a setTimeout() in addTab is used to trigger adjustTabstrip() so we need a delay here as well.
>+  executeSoon(function() {
>+    is(gBrowser.tabContainer.getAttribute("closebuttons"), "activetab", "Only show button on selected tab.");

I wouldn't be surprised if this fails intermittently...
Attachment #486830 - Flags: review?(dao) → review+
Attachment #486830 - Flags: approval2.0?
Priority: -- → P3
Target Milestone: --- → Firefox 4.0b8
Could someone give approval2.0 to this please?
Comment on attachment 486830 [details] [diff] [review]
v1

a=beltzner
Attachment #486830 - Flags: approval2.0? → approval2.0+
Attachment #486830 - Attachment is obsolete: true
Keywords: checkin-needed
Passed Try
http://hg.mozilla.org/mozilla-central/rev/b1eda2bd8812
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: in-testsuite+
Keywords: checkin-needed
Resolution: --- → FIXED
verified in current minefield nightly.
Status: RESOLVED → VERIFIED
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.