609163 - Get rid of Item.locked

Status: RESOLVED FIXED

(Firefox Graveyard :: Panorama, defect, P4)

Description

[Ian Gilman [:iangilman]]

We used to use .locked for the "new tab" group, but that's gone and we haven't found any other use for the property, so it's probably time to clean it out. 

This would probably be a good time to get rid of GroupItems.killNewTabGroup as well... it's been around long enough.

Comment 1

[Kevin Hanes]

Punting.

Comment 2

[Michael Yoshitaka Erlewine [:mitcho]]

Attachment: Trivial patch

Pushed to try.

Comment 3

[Michael Yoshitaka Erlewine [:mitcho]]

(In reply to comment #0)
> This would probably be a good time to get rid of GroupItems.killNewTabGroup as
> well... it's been around long enough.

For better or for worse, I created bug 628051 before seeing this comment. We could safely put them together if you'd like.

Comment 4

[Michael Yoshitaka Erlewine [:mitcho]]

Passed try.

Comment 5

[Ian Gilman [:iangilman]]

Comment on attachment 506190 [details] [diff] [review]
Trivial patch

Looks good, even if it is a bug marked "future"... :P

Comment 6

[Michael Yoshitaka Erlewine [:mitcho]]

Attachment: Patch for checkin

Comment 7

[Jonathan Watt [:jwatt]]

The patch does not apply.

Comment 8

[Michael Yoshitaka Erlewine [:mitcho]]

Attachment: Patch for checkin, unrotted

Comment 9

[Jonathan Watt [:jwatt]]

Push http://hg.mozilla.org/mozilla-central/rev/0e50480c408f