Closed Bug 609163 Opened 14 years ago Closed 13 years ago

Get rid of Item.locked

Categories

(Firefox Graveyard :: Panorama, defect, P4)

defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 4.0b11

People

(Reporter: iangilman, Assigned: mitcho)

References

Details

(Whiteboard: [qa-][cleanup][good first bug])

Attachments

(1 file, 2 obsolete files)

We used to use .locked for the "new tab" group, but that's gone and we haven't found any other use for the property, so it's probably time to clean it out. 

This would probably be a good time to get rid of GroupItems.killNewTabGroup as well... it's been around long enough.
Punting.
No longer blocks: 608028
Target Milestone: --- → Future
Whiteboard: [qa-][cleanup][good first bug]
Attached patch Trivial patch (obsolete) — Splinter Review
Pushed to try.
Assignee: nobody → mitcho
Status: NEW → ASSIGNED
Attachment #506190 - Flags: review?(ian)
(In reply to comment #0)
> This would probably be a good time to get rid of GroupItems.killNewTabGroup as
> well... it's been around long enough.

For better or for worse, I created bug 628051 before seeing this comment. We could safely put them together if you'd like.
Passed try.
Comment on attachment 506190 [details] [diff] [review]
Trivial patch

Looks good, even if it is a bug marked "future"... :P
Attachment #506190 - Flags: review?(ian) → review+
Attachment #506190 - Flags: approval2.0?
Attachment #506190 - Flags: approval2.0? → approval2.0+
Attached patch Patch for checkin (obsolete) — Splinter Review
Attachment #506190 - Attachment is obsolete: true
Blocks: 627096
Target Milestone: Future → ---
The patch does not apply.
Attachment #507360 - Attachment is obsolete: true
Push http://hg.mozilla.org/mozilla-central/rev/0e50480c408f
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Keywords: checkin-needed
Target Milestone: --- → Firefox 4.0b11
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.