609878 - no longer generating en-US langpacks after bug 578393

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[[e-mail] (:bhearsum)]

bug 578393 changed the upload logic a bit and ended up dropping the $(LANGPACK) upload line altogether. In this diff:
http://hg.mozilla.org/mozilla-central/rev/ab6d8c5a300a
there needs to be a $(LANGPACK) line in UPLOAD_FILES similar to the one being removed towards the end.

Comment 2

[[e-mail] (:bhearsum)]

I'm likely to be fixing this soon.

Comment 3

[[e-mail] (:bhearsum)]

Attachment: [checked in] re-add $(LANGPACK) to the list of potential upload files

Comment 4

[[e-mail] (:bhearsum)]

I'd like to land this prior to beta 8 so we can finally do a release with en-US.xpi's. It's also blocking at least one q4 releng goal. I believe that it is very safe.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I suspect that removal was a merging error, since
http://hg.mozilla.org/mozilla-central/rev/6a3204b41219
landed only a week or so before.

Comment 6

[[e-mail] (:bhearsum)]

Comment on attachment 496899 [details] [diff] [review]
[checked in] re-add $(LANGPACK) to the list of potential upload files

Landed this on the default branch of mozilla-central:
0ca6c4e19f46

Comment 7

[[e-mail] (:bhearsum)]

Seems to be working fine after landing.

Comment 8

[[e-mail] (:bhearsum)]

Drivers, I would like to take this patch on 1.9.1 and 1.9.2 as well, in order to keep the releng l10n repack code consistent across all branches. I've tested it, and believe it will cause no issues, and it has already landed without issue on trunk.

Comment 9

[Brandon Sterne (:bsterne)]

Comment on attachment 496899 [details] [diff] [review]
[checked in] re-add $(LANGPACK) to the list of potential upload files

a=bsterne for 1.9.2.14 and 1.9.1.17.

Comment 10

[[e-mail] (:bhearsum)]

Landed on 1.9.1 and 1.9.2.

Comment 11

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

If this was the result of a mismerge why was it needed on the older branches?  Was the same mistake made there?

Comment 12

[Daniel Veditz [:dveditz]]

Marking branch fixed based on
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/702b35a5935a
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/f4c422de6fce

But it'd be good to get an answer to khuey's question in comment 11

Comment 13

[[e-mail] (:bhearsum)]

tl;dr version: didn't need it on 1.9.1/1.9.2 before, now we do

The original bug that turned this on was bug 485860, which at the time, was only wanted for mozilla-central. The thing that prompted me to fix this regression will end up touching all active branches on which we have l10n, so I figured I may as well land on all of them now.

Comment 14

[[e-mail] (:bhearsum)]

We're still generating langpacks in the wrong place on 1.9.1 and 1.9.2, but I can't figure out why. They should end up dist/$platform/xpi, but they're still in "dist".