The default bug view has changed. See this FAQ.

[1.9.1 & 1.9.2] put en-US.xpi under obj-firefox/dist/platform/xpi rather than obj-firefox/dist

RESOLVED FIXED

Status

()

Core
Build Config
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: armenzg, Assigned: bhearsum)

Tracking

1.9.2 Branch
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(status2.0 unaffected, blocking1.9.2 -, status1.9.2 .17-fixed, blocking1.9.1 -, status1.9.1 .19-fixed)

Details

(Whiteboard: [l10n])

Attachments

(1 attachment)

Created attachment 506896 [details] [diff] [review]
[checked in][1.9.1][1.9.2] generate en-US.xpi under dist/linux-i686/xpi

on trunk: Uploading /builds/slave/rel-cen-lnx-bld/build/obj-firefox/dist/linux-i686/xpi/en-US.xpi
on 1.9.2: Uploading /builds/slave/rel-192-lnx-bld/build/obj-firefox/dist/en-US.xpi

Making langpack /builds/slave/rel-192-lnx-bld/build/obj-firefox/dist/en-US.xpi
Making langpack /builds/slave/rel-cen-lnx-bld/build/obj-firefox/browser/locales/../../dist/linux-i686/xpi/en-US.xpi

I believe attachment 479776 [details] [diff] [review] did not ever land on 1.9.1/1.9.2

See also bug 485860, bug 609878 and maybe maybe bug 587984.
(Assignee)

Comment 1

6 years ago
I dug into this a little bit and couldn't figure out why this is still happening. In the l10n makefiles $(LANGPACK_FILE) is the same on all branches. $(PKG_LANGPACK_BASENAME) and $(PKG_LANGPACK_PATH) are the same on all branches.

Moving this Core: Build Config, too.
Blocks: 627271
Component: Release Engineering → Build Config
Product: mozilla.org → Core
QA Contact: release → build-config
Version: other → 1.9.2 Branch
(Assignee)

Updated

6 years ago
Blocks: 629398
(Assignee)

Comment 2

6 years ago
I didn't see your patch when I first commented here, Armen. This looks quite like it's likely to be the fix, I'll test it out today.
(Assignee)

Updated

6 years ago
Assignee: nobody → bhearsum
(Assignee)

Comment 3

6 years ago
Comment on attachment 506896 [details] [diff] [review]
[checked in][1.9.1][1.9.2] generate en-US.xpi under dist/linux-i686/xpi

This is a follow-up to bugs 485860 and 609878. In the latter, we landed the second hunk of the patch from 485860 on all branches. But since the original patch never landed on 1.9.1 and 1.9.2 we ended up uploading en-US.xpi in the wrong place on these branches. This patch is simply the first hunk from bug 485860, which we need on 1.9.1 and 1.9.2 to upload en-US.xpi to the right location.

I tested it on Linux/Windows without issue.
Attachment #506896 - Flags: review?(khuey)
Attachment #506896 - Flags: review?(khuey) → review+
(Assignee)

Updated

6 years ago
Attachment #506896 - Attachment description: [untested][1.9.1][1.9.2] generate en-US.xpi under dist/linux-i686/xpi → [1.9.1][1.9.2] generate en-US.xpi under dist/linux-i686/xpi
(Assignee)

Comment 4

6 years ago
Drivers, this is a extremely low risk patch that's been on trunk for a long time. It only affects where we build en-US.xpi, and landing it allows us to land bug 629398, which is a big improvement to overall end2end time of a release. I'd like to land this on both 1.9.1 and 1.9.2.
blocking1.9.1: --- → ?
blocking1.9.2: --- → ?
Comment on attachment 506896 [details] [diff] [review]
[checked in][1.9.1][1.9.2] generate en-US.xpi under dist/linux-i686/xpi

a=beltzner for both branches
Attachment #506896 - Flags: approval1.9.2.15+
Attachment #506896 - Flags: approval1.9.1.18+
blocking1.9.1: ? → -
blocking1.9.2: ? → -
status1.9.1: --- → wanted
status1.9.2: --- → wanted
(Assignee)

Comment 6

6 years ago
Comment on attachment 506896 [details] [diff] [review]
[checked in][1.9.1][1.9.2] generate en-US.xpi under dist/linux-i686/xpi

Landed on both branches.
Attachment #506896 - Attachment description: [1.9.1][1.9.2] generate en-US.xpi under dist/linux-i686/xpi → [checked in][1.9.1][1.9.2] generate en-US.xpi under dist/linux-i686/xpi
(Assignee)

Updated

6 years ago
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
status1.9.1: wanted → .18-fixed
status1.9.2: wanted → .15-fixed
status2.0: --- → unaffected
Flags: in-testsuite-
OS: Mac OS X → All
Hardware: x86 → All
Blocks: 630562
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/8adc32f4b045
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/a16b0d96e0ab
The "3.6.15" we're releasing today does not fix this bug, the release containing this bug fix has been renamed to "3.6.16" and the bugzilla flags will be updated to reflect that soon. Today's release is a re-release of 3.6.14 plus a fix for a bug that prevented many Java applets from starting up.
You need to log in before you can comment on or make changes to this bug.