610922 - "Options..." and "Show All Bookmarks..." should not end with an ellipsis

Status: VERIFIED FIXED

(Firefox :: Menus, defect)

Description

[Alex Faaborg [:faaborg] (Firefox UX)]

The menu commands "Options..." and "Show All Bookmarks..." both currently end with an ellipsis, even though the command is carried out as soon as the user selections the option without needing any further input. (As an example "About Firefox" also does not use an ellipsis).

Even if we can't break string freeze, we may want to update these for en-us and then try to update them for other locals later.  "Options..." stands out right now since it is the only item in the right pane that contains an ellipsis (even though every item in that pane loads a tab or window).  And "Show All Bookmarks..." isn't internally consistent with the related command "Show All History"

Comment 1

[Frank Yan (:fryn)]

Attachment: patch for en-US

took it because I get annoyed by inconsistencies like this :P

Comment 2

[Axel Hecht [:Pike]]

Switching bug markup to [strings] whiteboard.

I don't think we should do this with "just en-US tweaking", some localizers are going to find it and complain, for one.

Also, a bug is either important to fix or not.

Comment 3

[Alex Faaborg [:faaborg] (Firefox UX)]

>Also, a bug is either important to fix or not.

makes sense, sorry about catching this so late in the process

Comment 4

[Justin Dolske [:Dolske]]

Comment on attachment 489410 [details] [diff] [review]
patch for en-US

Yeah, what Pike said. Should rev the entities so it gets picked up by l10n.

Do the l10n tools show localizers the previous value of the string? That would be nice so it's clear that the only change is the ellipsis-removal.

Comment 5

[Justin Dolske [:Dolske]]

Durr, I guess they wouldn't, since there's not really a way to know that the two entity names are related.

Another reason to hate the entity-name-changing system.

Comment 6

[Axel Hecht [:Pike]]

Well, they kinda do, if you're looking at https://l10n-stage-sj.mozilla.org/dashboard/compare?run=104442 for example, you see that it says "this goes away, this is new". Humans are OK to guess on related entry names to be related strings.

It doesn't show the difference between the two en-US strings, though.

Then again, one of your localizer uses three-way merge tools to do l10n for a reason ;-).

But yeah, room for improvement, and we're having that on our mind for l20n.

Comment 7

[Frank Yan (:fryn)]

Attachment: patch

Revs the entities.

Mac will still get the ellipsis after Preferences for platform consistency.

Comment 8

[Frank Yan (:fryn)]

Pushed.

http://hg.mozilla.org/mozilla-central/rev/76b44542c5c7

Comment 9

[Frank Yan (:fryn)]

Had to fix a typo.

http://hg.mozilla.org/mozilla-central/rev/d1228efe31dd

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

(In reply to comment #9)
> Had to fix a typo.
> 
> http://hg.mozilla.org/mozilla-central/rev/d1228efe31dd

Why are you modifying content in testing/tools/profiles/createTestingProfile.py?

Comment 11

[Frank Yan (:fryn)]

(In reply to comment #10)
> (In reply to comment #9)
> > Had to fix a typo.
> > 
> > http://hg.mozilla.org/mozilla-central/rev/d1228efe31dd
> 
> Why are you modifying content in
> testing/tools/profiles/createTestingProfile.py?

That was to re-land a line that I backed out from another patch that I simultaneously pushed before I figured out what actually was causing the bustage.
See http://hg.mozilla.org/mozilla-central/rev/bacd5fbd6456
and http://hg.mozilla.org/mozilla-central/rev/90cbd8bf83e2

Comment 12

[Axel Hecht [:Pike]]

More detail from #developers, 
<fryn> Pike: the pref was removed by my patch, so i removed all instances of it in our code base.
which is part of bug 604419.

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

Verified fixed with Mozilla/5.0 (Windows NT 5.1; rv:2.0b8pre) Gecko/20101202 Firefox/4.0b8pre

Updates Litmus tests:
https://litmus.mozilla.org/show_test.cgi?id=10033
https://litmus.mozilla.org/show_test.cgi?id=10032