612228 - Move Reload/Bookmark All Tabs to the List All Tabs menu

Status: RESOLVED WONTFIX

(Firefox :: Menus, defect)

Description

[ithinc]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; zh-CN; rv:1.9.2.12) Gecko/20101026 Firefox/3.6.12 (.NET CLR 3.5.30729)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; zh-CN; rv:1.9.2.12) Gecko/20101026 Firefox/3.6.12 (.NET CLR 3.5.30729)

As these items operate on all tabs, it would be more suitable for them to stay in the List All Tabs menu.

Reproducible: Always

Comment 1

[Marco Bonardo [:mak]]

Someone in UX may comment on this suggestion please?

Comment 2

[Siddhartha Dugar [:sdrocking]]

Reload is only for the current tabs and must not be in the list all tabs menu. We can have the undo close tab option.

Comment 3

[Evan Tseng [:evanxd]]

Move to QX Holding area to consider the priority.

Comment 4

[Evan Tseng [:evanxd]]

Attachment: bug-612228.patch

Finished the patch.

Now need UX inputs for it. Don't know who charge of the module yet. Finding...

The try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3571eadbadd9

Comment 5

[Evan Tseng [:evanxd]]

Attachment: list-all-tabs-menu.png

BTW, one question for UX issue, do we need two new icons for "Reload All Tabs" and "Bookmark All Tabs..." items(like the icon for "Undo Close Tab" item)?

Comment 6

[Evan Tseng [:evanxd]]

Added a video[1] for UI review.

[1]: https://youtu.be/4f74r2Xtvqo

Comment 7

[Evan Tseng [:evanxd]]

Comment on attachment 8789707 [details] [diff] [review]
bug-612228.patch

Hi Stephen,

Could you help review the UI change? You can see it on the video[1] or download the build[2] to test it.

And one question here, do we need two new icons for "Reload All Tabs" and "Bookmark All Tabs..." items(like the icon for "Undo Close Tab" item[3]) on the all tabs menu?

Thanks.

[1]: https://youtu.be/4f74r2Xtvqo
[2]: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3571eadbadd9&selectedJob=27204739
[3]: https://bug612228.bmoattachments.org/attachment.cgi?id=8789709

Comment 8

[Evan Tseng [:evanxd]]

Comment on attachment 8789707 [details] [diff] [review]
bug-612228.patch

Made a mistake on Comment 7.

Switch to "ui-review" from "review".

Comment 9

[Evan Tseng [:evanxd]]

Comment on attachment 8789707 [details] [diff] [review]
bug-612228.patch

Hi Marco,

Could you give feedbacks for the patch?

Thanks.

Comment 10

[Franck (Wip)]

I am a little concerned.

The "List all tabs" menu only appears when the tab strip overflows which requires to have many open tabs.
It obviously depends of the resolution but on my quite old computer (1680x945) this means at least 15 tabs.
(note: it required 13 tabs on your own screenshot)

How will I reload all my tabs if I only have 8 of them, knowing there is no shortcut ?

How do casual users having just a few tabs open discover how to bookmark all tabs since the tab context menu is the ONLY place where the command appear (it is no even in the bookmark menu) ?

Adding these command to "List all tabs" seems logical.
AFAIC their removal from the tab context menu is a regression.

Regards

Comment 11

[Evan Tseng [:evanxd]]

Attachment: bookmarks-menu.png

(In reply to Franck (Wip) from comment #10)
> I am a little concerned.
> 
> The "List all tabs" menu only appears when the tab strip overflows which
> requires to have many open tabs.
> It obviously depends of the resolution but on my quite old computer
> (1680x945) this means at least 15 tabs.
> (note: it required 13 tabs on your own screenshot)
> 
> How will I reload all my tabs if I only have 8 of them, knowing there is no
> shortcut ?
There is no way to do that. Good point, I also think we should keep the item on the context menu.
 
> How do casual users having just a few tabs open discover how to bookmark all
> tabs since the tab context menu is the ONLY place where the command appear
> (it is no even in the bookmark menu) ?
There is a "Bookmark All Tabs..." item in the "Bookmarks" menu(see it in the "bookmarks-menu.png" attachment).

> Adding these command to "List all tabs" seems logical.
> AFAIC their removal from the tab context menu is a regression.
I agree. But let's wait and see UX feedback.

Comment 12

[Stephen Horlander [:shorlander]]

There are already two ways to get to these options: right-click on a tab or right-click on an empty place in the tab strip.

This control has a specific purpose for showing tab overflow, which is why it is transient. I don't like the idea of overloading a transient control with options we have elsewhere.

NI-ing Philipp to get his thoughts.

Comment 13

[Franck (Wip)]

Since the empty space of the tab strip reacts as a title bar (at least on Windows) I never tried to open the context menu on it. It is good to know, thanks.

Comment 14

[Franck (Wip)]

Attachment: Bookmark menu of Nightly 51 on Windows 7

Thank you Evan for your reply and the screenshot.
What's interesting is that there is no "Bookmark All Tabs..." menu entry on Windows.
I suppose I should fill a new bug.

Comment 15

[Franck (Wip)]

FYI: bug 1302548 - [Bookmark menu] 'Bookmark All Tabs' is missing on Windows

Comment 16

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

(In reply to Stephen Horlander [:shorlander] from comment #12)
> There are already two ways to get to these options: right-click on a tab or
> right-click on an empty place in the tab strip.
> 
> This control has a specific purpose for showing tab overflow, which is why
> it is transient. I don't like the idea of overloading a transient control
> with options we have elsewhere.
> 
> NI-ing Philipp to get his thoughts.

Yes, I agree. Both of those actions are fairly uncommon and reloading all tabs can be a real performance hit when so many tabs are open (which is, by definition, the case when that menu shows up).
Let's not expose these options here. As Stephen mentioned, they are already available through other means.

Comment 17

[Evan Tseng [:evanxd]]

Comment on attachment 8789707 [details] [diff] [review]
bug-612228.patch

Since it's a WONTFIX bug, remove the feedback request.